* [bug#34646] [PATCH] gnu: openssh: Add libedit support.
@ 2019-02-25 13:08 Gábor Boskovits
[not found] ` <handler.34646.B.15511001546204.ack@debbugs.gnu.org>
2019-02-26 23:22 ` bug#34646: [PATCH] gnu: openssh: Add libedit support Gábor Boskovits
0 siblings, 2 replies; 4+ messages in thread
From: Gábor Boskovits @ 2019-02-25 13:08 UTC (permalink / raw)
To: 34646; +Cc: Gábor Boskovits
* gnu/packages/ssh.scm (openssh)[native-inputs]: Add pkg-config.
[inputs]: Add libedit.
[arguments](configure-flags): Add --with-libedit.
---
gnu/packages/ssh.scm | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 1928ea7634..968118ad19 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -11,6 +11,7 @@
;;; Copyright © 2017 Ricardo Wurmus <rekado@elephly.net>
;;; Copyright © 2017 Nils Gillmann <ng0@n0.is>
;;; Copyright © 2018 Manuel Graf <graf@init.at>
+;;; Copyright © 2019 Gábor Boskovits <boskovits@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -39,6 +40,7 @@
#:use-module (gnu packages gperf)
#:use-module (gnu packages groff)
#:use-module (gnu packages guile)
+ #:use-module (gnu packages libedit)
#:use-module (gnu packages linux)
#:use-module (gnu packages logging)
#:use-module (gnu packages m4)
@@ -154,8 +156,10 @@ a server that supports the SSH-2 protocol.")
(base32
"1b8sy6v0b8v4ggmknwcqx3y1rjcpsll0f1f8f4vyv11x4ni3njvb"))))
(build-system gnu-build-system)
- (native-inputs `(("groff" ,groff)))
- (inputs `(("openssl" ,openssl)
+ (native-inputs `(("groff" ,groff)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("libedit" ,libedit)
+ ("openssl" ,openssl)
("pam" ,linux-pam)
("mit-krb5" ,mit-krb5)
("zlib" ,zlib)
@@ -175,6 +179,9 @@ a server that supports the SSH-2 protocol.")
(assoc-ref %build-inputs "mit-krb5")
"/bin")
+ ;; libedit needed for sftp completion
+ "--with-libedit"
+
;; Enable PAM support in sshd.
"--with-pam")
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#34646] Acknowledgement ([PATCH] gnu: openssh: Add libedit support.)
[not found] ` <handler.34646.B.15511001546204.ack@debbugs.gnu.org>
@ 2019-02-25 13:16 ` Gábor Boskovits
2019-02-26 4:44 ` Leo Famulari
0 siblings, 1 reply; 4+ messages in thread
From: Gábor Boskovits @ 2019-02-25 13:16 UTC (permalink / raw)
To: 34646
Hello,
This is to enable sftp completion support.
The problem was noticed by tune on IRC.
Wdyt?
Best regards,
g_bor
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#34646] Acknowledgement ([PATCH] gnu: openssh: Add libedit support.)
2019-02-25 13:16 ` [bug#34646] Acknowledgement ([PATCH] gnu: openssh: Add libedit support.) Gábor Boskovits
@ 2019-02-26 4:44 ` Leo Famulari
0 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2019-02-26 4:44 UTC (permalink / raw)
To: Gábor Boskovits; +Cc: 34646
[-- Attachment #1: Type: text/plain, Size: 291 bytes --]
On Mon, Feb 25, 2019 at 02:16:32PM +0100, Gábor Boskovits wrote:
> Hello,
>
> This is to enable sftp completion support.
> The problem was noticed by tune on IRC.
> Wdyt?
Sounds good, I did some basic tests. But can you try updating libedit
to the latest release before pushing?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#34646: [PATCH] gnu: openssh: Add libedit support.
2019-02-25 13:08 [bug#34646] [PATCH] gnu: openssh: Add libedit support Gábor Boskovits
[not found] ` <handler.34646.B.15511001546204.ack@debbugs.gnu.org>
@ 2019-02-26 23:22 ` Gábor Boskovits
1 sibling, 0 replies; 4+ messages in thread
From: Gábor Boskovits @ 2019-02-26 23:22 UTC (permalink / raw)
To: 34646-done
Libedit updated in 1094f1216f21a52453b54b43ff88b856f4fac94d.
Patch pushed as 618631f3683e7caf5b0336ce06abf62a25ce119b.
Closing.
Thanks for the review.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-26 23:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-25 13:08 [bug#34646] [PATCH] gnu: openssh: Add libedit support Gábor Boskovits
[not found] ` <handler.34646.B.15511001546204.ack@debbugs.gnu.org>
2019-02-25 13:16 ` [bug#34646] Acknowledgement ([PATCH] gnu: openssh: Add libedit support.) Gábor Boskovits
2019-02-26 4:44 ` Leo Famulari
2019-02-26 23:22 ` bug#34646: [PATCH] gnu: openssh: Add libedit support Gábor Boskovits
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).