From: "Gábor Boskovits" <boskovits@gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com>
Cc: 33217@debbugs.gnu.org
Subject: [bug#33217] Modifying the commit message to gnu-Add-r-weights
Date: Mon, 5 Nov 2018 23:19:57 +0100 [thread overview]
Message-ID: <CAE4v=pirGnP9AF3kXhvssM9OP17wr1MTus8=4EGKQ7Hh=1cpKQ@mail.gmail.com> (raw)
In-Reply-To: <CAE4v=pjXvSap2Je0uv0e6PksTXCdJc5n35xssh2PKVVWSLOT+Q@mail.gmail.com>
Hello Lakshmi,
It would be nice if you could give this another shot, if not I will
commit it tomorrow with
some minor changes.
The commit message seems to be missing the second line (what has changed).
The license field still misses the prefix. See the mail from Björn earlier.
Could you squash your changes to a single commit?
(You can either do this on a throw-away branch with a git merge --squash, or
you can use git rebase -i, see this for more info
https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history.)
Best regards,
g_bor
next prev parent reply other threads:[~2018-11-05 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+H0LRPa=f1J4yXixg-=bFHEwRiwuaE1Eg=COVidnf1RFkaggg@mail.gmail.com>
2018-11-01 18:14 ` [bug#33217] Modifying the commit message to gnu-Add-r-weights Lakshmi Prasannakumar
2018-11-04 16:27 ` Lakshmi Prasannakumar
2018-11-04 17:05 ` Gábor Boskovits
2018-11-04 21:12 ` Gábor Boskovits
2018-11-05 20:41 ` Lakshmi Prasannakumar
2018-11-05 21:43 ` Gábor Boskovits
2018-11-05 22:19 ` Gábor Boskovits [this message]
2018-11-08 4:07 ` Lakshmi Prasannakumar
2018-11-08 19:35 ` Gábor Boskovits
2018-11-08 20:36 ` Lakshmi Prasannakumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=pirGnP9AF3kXhvssM9OP17wr1MTus8=4EGKQ7Hh=1cpKQ@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=33217@debbugs.gnu.org \
--cc=lakshmiprasannakumaran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).