From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebmeQ-0004DK-M4 for guix-patches@gnu.org; Wed, 17 Jan 2018 07:17:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebmeM-0005Qk-Ne for guix-patches@gnu.org; Wed, 17 Jan 2018 07:17:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebmeM-0005QU-Ja for guix-patches@gnu.org; Wed, 17 Jan 2018 07:17:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebmeM-0005og-CR for guix-patches@gnu.org; Wed, 17 Jan 2018 07:17:02 -0500 Subject: [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: <87zi5cga5w.fsf@gmail.com> References: <20171229191700.981-1-boskovits@gmail.com> <87zi5cga5w.fsf@gmail.com> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Wed, 17 Jan 2018 13:15:56 +0100 Message-ID: Content-Type: multipart/alternative; boundary="f403045fad483cdf980562f7cfef" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 29897@debbugs.gnu.org --f403045fad483cdf980562f7cfef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2018-01-17 9:30 GMT+01:00 Chris Marusich : > G=C3=A1bor Boskovits writes: > > > * gnu/packages/java.scm (java-aqute-libg)[arguments]: Add keyword > make-flags to use > > source and target 1.7. > > As a matter of Git style, the first line of a commit message should not > be longer than about 50 characters, and it should not span more than 1 > line. Maybe we could replace the first line with the following instead? > > gnu: java-aqute-libg: Explicitly build for Java 7. > > In addition, the comment in the commit message is helpful, but it would > be better to move it or copy it into the actual source code. That way, > when somebody reads the source, they'll know immediately why we > explicitly build for Java 7 without having to resort to searching the > Git history. > > > + #:make-flags (list (string-append "-Dant.build.javac.source=3D" > "1.7") > > + (string-append "-Dant.build.javac.target=3D" > "1.7")) > > You can also write this list in the following form, which is simpler: > > (list "-Dant.build.javac.source=3D1.7" "-Dant.build.javac.target=3D1.7"= ) > > I'll make these changes and commit this in the next day or two, unless > you have additional comments or you submit a new patch before then. > > - > Chris > Thanks for the corrections. Looks good to me, I won't send an updated patch then. Please commit with the modifications. --f403045fad483cdf980562f7cfef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2018= -01-17 9:30 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:
G=C3=A1bor Boskovits= <boskovits@gmail.com> wri= tes:

> * gnu/packages/java.scm (java-aqute-libg)[arguments]: Add keyword make= -flags to use
>=C2=A0 =C2=A0source and target 1.7.

As a matter of Git style, the first line of a commit message should = not
be longer than about 50 characters, and it should not span more than 1
line.=C2=A0 Maybe we could replace the first line with the following instea= d?

=C2=A0 gnu: java-aqute-libg: Explicitly build for Java 7.

In addition, the comment in the commit message is helpful, but it would
be better to move it or copy it into the actual source code.=C2=A0 That way= ,
when somebody reads the source, they'll know immediately why we
explicitly build for Java 7 without having to resort to searching the
Git history.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:make-flags (list (string-append "-D= ant.build.javac.source=3D" "1.7")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 (string-append "-Dant.build.javac.target=3D"= ; "1.7"))

You can also write this list in the following form, which is simpler= :

=C2=A0 (list "-Dant.build.javac.source=3D1.7" "-Dant.build.j= avac.target=3D1.7")

I'll make these changes and commit this in the next day or two, unless<= br> you have additional comments or you submit a new patch before then.

-
Chris
=C2=A0
Thanks for the corrections.
Looks good to me,
I won't send an updated patch then.
Please commit with the modifications.
--f403045fad483cdf980562f7cfef--