unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gábor Boskovits" <boskovits@gmail.com>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: Ricardo Wurmus <rekado@elephly.net>, 29896@debbugs.gnu.org
Subject: [bug#29896] [PATCH] gnu: java-asm: Update to 6.0.
Date: Fri, 19 Jan 2018 09:11:58 +0100	[thread overview]
Message-ID: <CAE4v=phv7gHHsSmThvOtwvAj3QQ3Q+f+DUZu2nQ7ih_iwZ6gRg@mail.gmail.com> (raw)
In-Reply-To: <87efmmtky1.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

Actually I did forget to check if it is used runtime.
It is used to build and OSGi bundle.
At first I tried to fake the dependency like for the ant tasks,
but I got compilation errors.

2018-01-19 7:35 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:

> Gábor Boskovits <boskovits@gmail.com> writes:
>
> > +    (inputs
> > +     `(("java-aqute-bndlib" ,java-aqute-bndlib)
> > +       ("java-aqute-libg" ,java-aqute-libg)))
> >      (arguments
> >       `(#:build-target "compile"
> >         ;; The tests require an old version of Janino, which no longer
> compiles
> > @@ -2679,7 +2682,9 @@ archives (jar).")
> >         #:tests? #f
> >         ;; We don't need these extra ant tasks, but the build system
> asks us to
> >         ;; provide a path anyway.
> > -       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=
> foo"))
> > +       #:make-flags (list (string-append "-Dobjectweb.ant.tasks.path=
> foo")
> > +                          (string-append "-Dbiz.aQute.bnd.path="
> > +                                         (assoc-ref %build-inputs
> "java-aqute-bndlib")))
>
> Even though we added some inputs, there appear to be no retained
> references in the output, as shown by this command:
>
>   guix gc --referrers $(./pre-inst-env guix build java-asm)
>
> Is this expected?  At first blush, this seems reasonable only if
> java-aqute-bndlib and java-aqute-libg are not required at runtime.
> Perhaps Ricardo knows more, since he has more experience working with
> the ant-build-system.
>
> --
> Chris
>

[-- Attachment #2: Type: text/html, Size: 2270 bytes --]

  reply	other threads:[~2018-01-19  8:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 19:00 [bug#29896] [PATCH core-updates] gnu: java-asm: Update to 6.0 Gábor Boskovits
2018-01-07 21:23 ` [bug#29896] [PATCH] " Gábor Boskovits
2018-01-07 21:27   ` Gábor Boskovits
2018-01-19  6:35   ` Chris Marusich
2018-01-19  8:11     ` Gábor Boskovits [this message]
2018-01-19  9:59       ` Chris Marusich
2018-01-19 12:13         ` Ricardo Wurmus
2018-01-20  0:12     ` Leo Famulari
2018-01-20  7:50       ` Chris Marusich
2018-01-20  9:08         ` Gábor Boskovits
2018-01-20 11:24           ` Julien Lepiller
2018-01-20 21:43           ` bug#29896: " Chris Marusich
2018-01-21 13:52             ` [bug#29896] " Ricardo Wurmus
2018-01-20 11:29         ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE4v=phv7gHHsSmThvOtwvAj3QQ3Q+f+DUZu2nQ7ih_iwZ6gRg@mail.gmail.com' \
    --to=boskovits@gmail.com \
    --cc=29896@debbugs.gnu.org \
    --cc=cmmarusich@gmail.com \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).