From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDp53-0003Fm-St for guix-patches@gnu.org; Sat, 20 Oct 2018 07:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDp50-0001a1-MJ for guix-patches@gnu.org; Sat, 20 Oct 2018 07:06:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56045) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDp50-0001Zv-H2 for guix-patches@gnu.org; Sat, 20 Oct 2018 07:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDp4z-0006Mz-JM for guix-patches@gnu.org; Sat, 20 Oct 2018 07:06:02 -0400 Subject: [bug#33099] [PATCH] I add r-aspi package appended to cran.scm file Resent-Message-ID: MIME-Version: 1.0 References: <8736t12frf.fsf@mdc-berlin.de> In-Reply-To: From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Sat, 20 Oct 2018 13:05:24 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: Laura Lazzati , 33099@debbugs.gnu.org Hello Laura, G=C3=A1bor Boskovits ezt =C3=ADrta (id=C5=91pont: 201= 8. okt. 20., Szo, 10:43): > > Hello Laura, > > Ricardo Wurmus ezt =C3=ADrta (id=C5=91pont= : 2018. > okt. 20., Szo, 10:17): > > > > > > Hi Laura, > > > > congratulations on your first patch to Guix! > > > > What follows are a few comments on minor changes that I would like to > > see before applying the patch to Guix. > > > > > From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 200= 1 > > > From: laura > > > Date: Fri, 19 Oct 2018 19:15:37 -0300 > > > Subject: [PATCH] I add r-aspi package appended to cran.scm file > > > > > > --- > > > gnu/packages/cran.scm | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > For commits to Guix, we use a somewhat strict commit message format. > > You can take a look at the commit log to get a feel for it. In the cas= e > > of adding r-aspi to cran.scm this would be the expected commit message: > > > > --8<---------------cut here---------------start------------->8--- > > gnu: Add r-aspi. > > > > * gnu/packages/cran.scm (r-aspi): New variable. > > --8<---------------cut here---------------end--------------->8--- > > > > The first line is always a concise summary. This is followed by a > > change log listing modified files and how they were modified. > > > > You can also see git log for examples. > > > > diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm > > > index efcc2dccb..0d8ee6a97 100644 > > > --- a/gnu/packages/cran.scm > > > +++ b/gnu/packages/cran.scm > > > @@ -6256,3 +6256,22 @@ a header row or not. The dataset should conta= in > > > only one independent variable > > > (x) and one dependent variable (y) and can contain a weight for each > > > observation.") > > > (license license:gpl2))) > > > + > > > +(define-public r-aspi > > > + (package > > > + (name "r-aspi") > > > + (version "0.2.0") > > > + (source > > > + (origin > > > + (method url-fetch) > > > + (uri (cran-uri "aspi" version)) > > > + (sha256 > > > + (base32 > > > + "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87")))) > > > + (build-system r-build-system) > > > + (home-page "https://cran.r-project.org/web/packages/aspi/") > > > + (synopsis "Analysis of Symmetry of Parasitic Infections") > > > > Please use lowercase for all words except for the first. CRAN synopses > > are usually in titlecase and the importer can=E2=80=99t automatically f= igure out > > which words should be converted, so this needs to be done manually. > > > > > + (description > > > + "Tools for the analysis and visualization of bilateral asymmetr= y in > > > + parasitic infections.") > > > > Please use a complete sentence for the description. The easiest way is > > probably to just prepend =E2=80=9CThis package provides=E2=80=9D. > > > > > + (license license:gpl3))) > > > > I checked the source files and noticed that it=E2=80=99s actually GPL 3= or > > later. Here=E2=80=99s an except from the header of aspi.R: > > > > --8<---------------cut here---------------start------------->8--- > > # Analysis of Symmetry of Parasitic Infections is free software: you c= an # > > # redistribute it and/or modify it under the terms of the GNU General = Public # > > # License as published by the Free Software Foundation, either version= 3 of # > > # the License, or (at your option) any later version. = # > > --8<---------------cut here---------------end--------------->8--- > > > > So this really should be =E2=80=9Clicense:gpl3+=E2=80=9D. > > > > (I haven=E2=80=99t tried building the package yet.) > > > > I will try this and report back. > It builds for me fine, so with the suggestions Ricardo mentioned I think it is good to go. > > I think it=E2=80=99s fine to apply the patch with these minor changes. > > > > -- > > Ricardo I had problem with applying this directly with git am, it kept telling me the patch is corrupt on line 10. Can someone have a look? > > Thanks Ricardo for the fast review! > > Best regards, > g_bor Best regards, g_bor