From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50882) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKq62-0005Jg-E9 for guix-patches@gnu.org; Thu, 08 Nov 2018 14:36:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKq5y-0001NH-8V for guix-patches@gnu.org; Thu, 08 Nov 2018 14:36:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:37655) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKq5y-0001M3-1H for guix-patches@gnu.org; Thu, 08 Nov 2018 14:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKq5x-0006TO-OM for guix-patches@gnu.org; Thu, 08 Nov 2018 14:36:01 -0500 Subject: [bug#33217] Modifying the commit message to gnu-Add-r-weights Resent-Message-ID: MIME-Version: 1.0 References: In-Reply-To: From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Thu, 8 Nov 2018 20:35:00 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000591c17057a2c55a1" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Lakshmi Prasannakumar Cc: 33217@debbugs.gnu.org --000000000000591c17057a2c55a1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I used the version where the most things were fixed, applied it to the commit in Bj=C3=B6rn's message, created a branch, rebased on current master= , then fixed the commit message using amend, signed off and pushed. There is no additional thing to do. 2018. nov. 8., Cs 5:07 d=C3=A1tummal Lakshmi Prasannakumar < lakshmiprasannakumaran@gmail.com> ezt =C3=ADrta: > Hi G=C3=A1bor, > > I am extremely sorry that , I did miss out this mail. I would like to kno= w > , if there is anything more that I need to do on r-weights package > addition. > If not could you tell me how you fixed this to do the final commit ? > > Thanks, > > On Tue 6 Nov, 2018, 3:50 AM G=C3=A1bor Boskovits >> Hello Lakshmi, >> >> It would be nice if you could give this another shot, if not I will >> commit it tomorrow with >> some minor changes. >> >> The commit message seems to be missing the second line (what has changed= ). >> >> The license field still misses the prefix. See the mail from Bj=C3=B6rn >> earlier. >> >> Could you squash your changes to a single commit? >> >> (You can either do this on a throw-away branch with a git merge --squash= , >> or >> you can use git rebase -i, see this for more info >> >> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewrit= ing-history >> .) >> >> Best regards, >> g_bor >> > --000000000000591c17057a2c55a1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I used the version where the most things were fixed,= applied it to the commit in Bj=C3=B6rn's message, created a branch, re= based on current master, then fixed the commit message using amend, signed = off and pushed. There is no additional thing to do.

2018. nov. 8., Cs 5:07 d=C3=A1tummal Lakshmi Pr= asannakumar <lakshmi= prasannakumaran@gmail.com> ezt =C3=ADrta:
Hi=C2=A0G=C3=A1bor,

I am extremely sorry that , I = did miss out this mail. I would like to know , if there is anything more th= at I need to do on r-weights package addition.=C2=A0
If not could you tell me how you fixed this to do the final co= mmit ?=C2=A0

Thanks,=C2=A0

On Tue 6 Nov, 2018, 3:50 AM G=C3=A1bor Boskovits <boskovits@gmail.com wrote:
Hello Lakshmi,

It would be nice if you could give this another shot, if not I will
commit it tomorrow with
some minor changes.

The commit message seems to be missing the second line (what has changed).<= br>
The license field still misses the prefix. See the mail from Bj=C3=B6rn ear= lier.

Could you squash your changes to a single commit?

(You can either do this on a throw-away branch with a git merge --squash, o= r
you can use git rebase -i, see this for more info
https://robots.thoughtbot.com/git-interactive-rebase-squash= -amend-rewriting-history.)

Best regards,
g_bor
--000000000000591c17057a2c55a1--