unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Gábor Boskovits" <boskovits@gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com>
Cc: 33217@debbugs.gnu.org
Subject: [bug#33217] Modifying the commit message to gnu-Add-r-weights
Date: Thu, 8 Nov 2018 20:35:00 +0100	[thread overview]
Message-ID: <CAE4v=phgS1GFe+Swih8KbEA4M6FWdinzL3W7UXNsx=CmfHy1dw@mail.gmail.com> (raw)
In-Reply-To: <CA+H0LRO0er3_JwzywALeZWYVMcq6nTzcYqQ9iCXjX0faR0FL-g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

I used the version where the most things were fixed, applied it to the
commit in Björn's message, created a branch, rebased on current master,
then fixed the commit message using amend, signed off and pushed. There is
no additional thing to do.

2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
lakshmiprasannakumaran@gmail.com> ezt írta:

> Hi Gábor,
>
> I am extremely sorry that , I did miss out this mail. I would like to know
> , if there is anything more that I need to do on r-weights package
> addition.
> If not could you tell me how you fixed this to do the final commit ?
>
> Thanks,
>
> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:
>
>> Hello Lakshmi,
>>
>> It would be nice if you could give this another shot, if not I will
>> commit it tomorrow with
>> some minor changes.
>>
>> The commit message seems to be missing the second line (what has changed).
>>
>> The license field still misses the prefix. See the mail from Björn
>> earlier.
>>
>> Could you squash your changes to a single commit?
>>
>> (You can either do this on a throw-away branch with a git merge --squash,
>> or
>> you can use git rebase -i, see this for more info
>>
>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>> .)
>>
>> Best regards,
>> g_bor
>>
>

[-- Attachment #2: Type: text/html, Size: 2663 bytes --]

  reply	other threads:[~2018-11-08 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+H0LRPa=f1J4yXixg-=bFHEwRiwuaE1Eg=COVidnf1RFkaggg@mail.gmail.com>
2018-11-01 18:14 ` [bug#33217] Modifying the commit message to gnu-Add-r-weights Lakshmi Prasannakumar
2018-11-04 16:27   ` Lakshmi Prasannakumar
2018-11-04 17:05     ` Gábor Boskovits
2018-11-04 21:12       ` Gábor Boskovits
2018-11-05 20:41         ` Lakshmi Prasannakumar
2018-11-05 21:43           ` Gábor Boskovits
2018-11-05 22:19             ` Gábor Boskovits
2018-11-08  4:07               ` Lakshmi Prasannakumar
2018-11-08 19:35                 ` Gábor Boskovits [this message]
2018-11-08 20:36                   ` Lakshmi Prasannakumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE4v=phgS1GFe+Swih8KbEA4M6FWdinzL3W7UXNsx=CmfHy1dw@mail.gmail.com' \
    --to=boskovits@gmail.com \
    --cc=33217@debbugs.gnu.org \
    --cc=lakshmiprasannakumaran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).