From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ef538-0001q1-SI for guix-patches@gnu.org; Fri, 26 Jan 2018 09:32:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ef535-0003Gq-IP for guix-patches@gnu.org; Fri, 26 Jan 2018 09:32:14 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:35380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ef535-0003GU-D4 for guix-patches@gnu.org; Fri, 26 Jan 2018 09:32:11 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ef0mj-0004Zq-QC for guix-patches@gnu.org; Fri, 26 Jan 2018 04:59:01 -0500 Subject: [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8. Resent-Message-ID: MIME-Version: 1.0 In-Reply-To: References: <20171229191700.981-1-boskovits@gmail.com> <87zi5cga5w.fsf@gmail.com> <87r2qel1zl.fsf@gmail.com> From: =?UTF-8?Q?G=C3=A1bor?= Boskovits Date: Fri, 26 Jan 2018 10:58:23 +0100 Message-ID: Content-Type: multipart/alternative; boundary="94eb2c042a96ec628d0563aaef13" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 29897@debbugs.gnu.org --94eb2c042a96ec628d0563aaef13 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Actually, is seems that I was wrong after all, I could not move the testresources to a location which is good. I've checked in build.gradle how is it done. The relevant part is this: /* test folders are not part of jar but used by unit tests */ def testfolders =3D ['testresources/', 'testdata/'] jar { projectDirInputsExcludes << '.*' projectDirInputsExcludes +=3D testfolders } test { testLogging { exceptionFormat 'full' } inputs.files fileTree(projectDir) { include testfolders exclude { def f =3D it.file if (f.directory && f.list().length =3D=3D 0) { return true } try { return "git check-ignore ${f}".execute().waitFor() =3D=3D 0 } catch (Exception e) { return false } } } How could we replicate this behaviour? It would also worth checking if the situation regarding these test is the same in version 3.5.0? Currently I see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D30062 as a blocking issue to the upgrade. 2018-01-25 22:47 GMT+01:00 G=C3=A1bor Boskovits : > It seems, that moving the tests and not moving the tesresources directory > breaks the relatitve paths in the tests. > Tomorrow I will check what happens if we also move the testresources. > > 2018-01-25 10:30 GMT+01:00 Chris Marusich : > >> G=C3=A1bor Boskovits writes: >> >> > Thanks for the corrections. >> > Looks good to me, >> > I won't send an updated patch then. >> > Please commit with the modifications. >> >> I made the modifications and also tried to enable the tests (see >> attached patch), but I discovered that some of the tests are failing >> (and some are passing). Perhaps we should try fixing the tests while >> we're here? If you do >> >> /pre-inst-env guix build --keep-failed java-aqute-libg >> >> you can see the failures. The build directory will be kept. If we go >> to it, we can find a report of the test failures under the path: >> >> bnd-3.4.0.REL/aQute.libg/test/test-reports >> >> Unfortunately, the ant-build-system doesn't compile the classes with >> debug info by default. To enable line numbers etc. in the stack traces, >> we'll need to add >> >> debug=3D"true" >> >> to the relevant tags, as described here: >> >> https://ant.apache.org/manual/Tasks/javac.html >> >> If you could help debug the failures, that would be nice. I will also >> look as I get time. >> >> -- >> Chris >> > > --94eb2c042a96ec628d0563aaef13 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Actually, is seems that I was wrong after all, I could not= move the testresources to a location which is good.
I've checked i= n build.gradle how is it done. The relevant part is this:

=C2=A0 =C2=A0 /* test folders are not part of jar but used by = unit tests=C2=A0 */
=C2=A0 =C2=A0 def testfolders =3D ['testr= esources/', 'testdata/']
=C2=A0 =C2=A0 jar {
=C2=A0 =C2=A0 =C2=A0 projectDirInputsExcludes << '.*'
=
=C2=A0 =C2=A0 =C2=A0 projectDirInputsExcludes +=3D testfolders
=C2=A0 =C2=A0 }
=C2=A0 =C2=A0 test {
=C2=A0 =C2=A0 = =C2=A0 testLogging {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 exceptionFormat = 'full'
=C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2= =A0 inputs.files fileTree(projectDir) {
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 include testfolders
=C2=A0 =C2=A0 =C2=A0 =C2=A0 exclude {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 def f =3D it.file
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (f.directory && f.list().length = =3D=3D 0) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return true=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 try {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= return "git check-ignore ${f}".execute().waitFor() =3D=3D 0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 } catch (Exception e) {
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 return false
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 }

How could we replic= ate this behaviour?

It would also worth checking i= f the situation regarding these test is the same in version 3.5.0?

Currently I see=C2=A0https://debbugs.gnu.org/cgi/bugreport.cgi?bug= =3D30062=C2=A0=C2=A0as a blocking issue to the upgrade.

2018-01-25 22:47 GMT+01:00 = G=C3=A1bor Boskovits <boskovits@gmail.com>:
It seems, that movi= ng the tests and not moving the tesresources directory breaks the relatitve= paths in the tests.
Tomorrow I will check what happens if we also move= the testresources.

2018-01-2= 5 10:30 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:<= br>
G=C3=A1bor Bosko= vits <boskovits= @gmail.com> writes:

> Thanks for the corrections.
> Looks good to me,
> I won't send an updated patch then.
> Please commit with the modifications.

I made the modifications and also tried to enable the tests (see
attached patch), but I discovered that some of the tests are failing
(and some are passing).=C2=A0 Perhaps we should try fixing the tests while<= br> we're here?=C2=A0 If you do

=C2=A0 /pre-inst-env guix build --keep-failed java-aqute-libg

you can see the failures.=C2=A0 The build directory will be kept.=C2=A0 If = we go
to it, we can find a report of the test failures under the path:

=C2=A0 bnd-3.4.0.REL/aQute.libg/test/test-reports

Unfortunately, the ant-build-system doesn't compile the classes with debug info by default.=C2=A0 To enable line numbers etc. in the stack trace= s,
we'll need to add

=C2=A0 debug=3D"true"

to the relevant <javac> tags, as described here:

https://ant.apache.org/manual/Tasks/javac.html

If you could help debug the failures, that would be nice.=C2=A0 I will also=
look as I get time.
<= br> --
Chris


--94eb2c042a96ec628d0563aaef13--