From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KPoqNQweZl/iYQAA0tVLHw (envelope-from ) for ; Sat, 19 Sep 2020 15:04:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UA0cMQweZl9oMwAA1q6Kng (envelope-from ) for ; Sat, 19 Sep 2020 15:04:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 32F199402AA for ; Sat, 19 Sep 2020 15:04:44 +0000 (UTC) Received: from localhost ([::1]:41320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJePr-0005om-1g for larch@yhetil.org; Sat, 19 Sep 2020 11:04:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJePC-0005XS-NE for guix-patches@gnu.org; Sat, 19 Sep 2020 11:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36247) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJePC-0007fe-EH for guix-patches@gnu.org; Sat, 19 Sep 2020 11:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJePC-00006j-Aj for guix-patches@gnu.org; Sat, 19 Sep 2020 11:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43320] Add emacs-html-to-hiccup package Resent-From: Jesse Dowell Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Sep 2020 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43320 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 43320@debbugs.gnu.org Received: via spool by 43320-submit@debbugs.gnu.org id=B43320.1600527831394 (code B ref 43320); Sat, 19 Sep 2020 15:04:02 +0000 Received: (at 43320) by debbugs.gnu.org; 19 Sep 2020 15:03:51 +0000 Received: from localhost ([127.0.0.1]:47793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJeP1-00006I-2I for submit@debbugs.gnu.org; Sat, 19 Sep 2020 11:03:51 -0400 Received: from mail-lf1-f49.google.com ([209.85.167.49]:46458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJeP0-000065-0Q for 43320@debbugs.gnu.org; Sat, 19 Sep 2020 11:03:50 -0400 Received: by mail-lf1-f49.google.com with SMTP id b22so9270008lfs.13 for <43320@debbugs.gnu.org>; Sat, 19 Sep 2020 08:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/hv5jRJMzb5ZZlxTfEXIMNhokjWEX/FP3zgxes/cdow=; b=DRpUIDeuzLw2NCwmlGP/iIRxQ4mljbL+q79WSLIeI1X//kx6H8UpLcyUjdu+IMQsox CnHplc3/j3KAckj2+yiXoRQuct7DzIG4l2jLHvagB0RBGYCFYEuwc01JsX8Yc2oy3ikI SIF6OliIXDJ31WBJrs60QKKVYUHOepUDX9WmMgb4niLAj32wTrMPdB7ncZkr5sDLUKWO 9uYVuA/fKLb+scrOAQWI6G/b5ejcZ29JN/P/glZQpHjx+EGLAvuLsYvb90j7nixLsZNh e/FZlDl1Vm4PciCh7BwkARR850xr1h8MGgdRrM9lbRAuy+YYN1WVrrqPM9ft4r7tnLRS o83w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/hv5jRJMzb5ZZlxTfEXIMNhokjWEX/FP3zgxes/cdow=; b=fVJuQ5ggQJT7kqheARtTbltlTylZLzpyvPogYDhy+pa/G4/BP3MzZsLm8916CHfSJ2 P6E9mPG5aj61cGpGeCSKzc+Ow383AT0H0V+bsfGlCR83F67HwUOVWtPTiz2KPt/HE8mq DLPBL50pVdY4nOWBEl0nfW1LKFGjZcI3w6oRvESphDC3lsTfJ3pv3R9fcK6vwTW2EYp9 LGSjTxICrsTDdyvkZ3YisIm+H1bMcD3t04EQIgtmPnpR0Enx0jsSP28DAAuGNmaqOgNW T9Dc3tE3tHTSEdgq8A6HlyTvy4V5SX8g3BR/D2QSTnD8Q+YKw4j7PGfh2D3RzGS9va5I +eMw== X-Gm-Message-State: AOAM5323lOfEIdryZkcNqPz7ogtNkOroaxsprxQeXF6yLb/1t/d7U8CH mNJgUzgbAeoNwgplGIhAGauSImgA/eqAB46WhrE= X-Google-Smtp-Source: ABdhPJybaJaDeyOAKJGpa/vBwU9pBikByhudsc8y5xdH439d1rOKYOy47p9AroySc2SDRbjDadjekaipcLAtc5QQi4E= X-Received: by 2002:ac2:43d5:: with SMTP id u21mr14610918lfl.135.1600527823961; Sat, 19 Sep 2020 08:03:43 -0700 (PDT) MIME-Version: 1.0 References: <87mu1p1oa5.fsf@nicolasgoaziou.fr> In-Reply-To: <87mu1p1oa5.fsf@nicolasgoaziou.fr> From: Jesse Dowell Date: Sat, 19 Sep 2020 11:03:32 -0400 Message-ID: Content-Type: multipart/mixed; boundary="00000000000066f37305afabecd5" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-Mailman-Approved-At: Sat, 19 Sep 2020 11:04:31 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=gmail.com header.s=20161025 header.b=DRpUIDeu; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 1.19 X-TUID: ex7aivKzILtD --00000000000066f37305afabecd5 Content-Type: multipart/alternative; boundary="00000000000066f37105afabecd3" --00000000000066f37105afabecd3 Content-Type: text/plain; charset="UTF-8" On Wed, Sep 16, 2020 at 4:04 PM Nicolas Goaziou wrote: > Hello, > > Jesse Dowell writes: > > > I'm hoping the following patch can be useful for others. It's a package > for > > emacs-html-to-hiccup which can be very handy when working with clojure > > programs that use hiccup syntax. > > Thank you. > > Could you send the patch with "git format-patch" or "git send-email" ? > > > > --8<---------------cut here---------------start------------->8--- > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > > index ff043463cc..253e51a79c 100644 > > --- a/gnu/packages/emacs-xyz.scm > > +++ b/gnu/packages/emacs-xyz.scm > > @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.") > > label references and citations in LaTeX. It is based on RefTeX, which > is > > included with Emacs.") > > (license license:gpl3+))) > > + > > +(define-public emacs-html-to-hiccup > > + (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1") > > + (revision "0")) > > Could you add a comment explaining why we provide a non-released version > (here because there is no release anyway). > > + (package > > + (name "emacs-html-to-hiccup") > > + (version (git-version "20190909" revision commit)) > > It should be version "1.0" according to keyword in main file. > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/plexus/html-to-hiccup") > > + (commit commit))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp")))) > > Could you move the string on the line above ? > > > + (build-system emacs-build-system) > > + (propagated-inputs > > + `(("dash" ,emacs-dash) > > + ("s" ,emacs-s))) > > There is an indentation issue here. > > > + (home-page "https://github.com/plexus/html-to-hiccup") > > + (synopsis "Emacs package that turns HTML into Hiccup syntax") > > It could be > > "Turn HTML into Hiccup syntax" > > > + (description > > + "Emacs package that turns HTML into Hiccup syntax, a notation > > popular > > +when doing Clojure/ClojureScript web development.") > > The description should be comprised of full sentences. Calling "guix > lint" on your definition should report it. Here, it could be: > > This Emacs package turns HTML... > > > + (license license:mpl2.0)))) > > LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe > you should add a comment about it. > > Could you send an updated patch? > > Regards, > -- > Nicolas Goaziou > Thanks for the feedback. I've attached a patch that incorporates all of your suggestions. Best, Jesse --00000000000066f37105afabecd3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Sep 16, 2020 at 4:04 PM Nicolas G= oaziou <mail@nicolasgoaziou.fr= > wrote:
Hello,

Jesse Dowell <jesse.dowell@gmail.com> writes:

> I'm hoping the following patch can be useful for others. It's = a package for
> emacs-html-to-hiccup which can be very handy when working with clojure=
> programs that use hiccup syntax.

Thank you.

Could you send the patch with "git format-patch" or "git sen= d-email" ?
>
> --8<---------------cut here---------------start------------->8--= -
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index ff043463cc..253e51a79c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.")
>=C2=A0 label references and citations in LaTeX.=C2=A0 It is based on Re= fTeX, which is
>=C2=A0 included with Emacs.")
>=C2=A0 =C2=A0 =C2=A0 (license license:gpl3+)))
> +
> +(define-public emacs-html-to-hiccup
> +=C2=A0 (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1&q= uot;)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 (revision "0"))

Could you add a comment explaining why we provide a non-released version (here because there is no release anyway).
> +=C2=A0 =C2=A0 (package
> +=C2=A0 =C2=A0 =C2=A0 (name "emacs-html-to-hiccup")
> +=C2=A0 =C2=A0 =C2=A0 (version (git-version "20190909" revis= ion commit))

It should be version "1.0" according to keyword in main file.
> +=C2=A0 =C2=A0 =C2=A0 (source
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0(origin
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(method git-fetch)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "https://github.com/plexus/html-to-hiccup")
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(commit commit= )))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name vers= ion))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))
Could you move the string on the line above ?

> +=C2=A0 =C2=A0 =C2=A0 (build-system emacs-build-system)
> +=C2=A0 =C2=A0 =C2=A0 (propagated-inputs
> +=C2=A0 =C2=A0 =C2=A0`(("dash" ,emacs-dash)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0("s" ,emacs-s)))

There is an indentation issue here.

> +=C2=A0 =C2=A0 =C2=A0 (home-page "https://github.c= om/plexus/html-to-hiccup")
> +=C2=A0 =C2=A0 =C2=A0 (synopsis "Emacs package that turns HTML in= to Hiccup syntax")

It could be

=C2=A0 "Turn HTML into Hiccup syntax"

> +=C2=A0 =C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"Emacs package that turns HTML into H= iccup syntax, a notation
> popular
> +when doing Clojure/ClojureScript web development.")

The description should be comprised of full sentences. Calling "guix lint" on your definition should report it. Here, it could be:

=C2=A0 =C2=A0This Emacs package turns HTML...

> +=C2=A0 =C2=A0 =C2=A0 (license license:mpl2.0))))

LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe
you should add a comment about it.

Could you send an updated patch?

Regards,
--
Nicolas Goaziou

Thanks for the feedback= . I've attached a patch that incorporates all of your suggestions.

Best,
Jesse
--00000000000066f37105afabecd3-- --00000000000066f37305afabecd5 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-gnu-Add-emacs-html-to-hiccup.patch" Content-Disposition: attachment; filename="0001-gnu-Add-emacs-html-to-hiccup.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kf9sxbx60 RnJvbSA0NDIzMjQzYzRlODY3NzllNzkwZWIxZGEwMDNmYTM3MzQxNWIzNDdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXNzZSBEb3dlbGwgPGplc3NlZG93ZWxsQGdtYWlsLmNvbT4K RGF0ZTogU2F0LCAxOSBTZXAgMjAyMCAxMDo0NTo1MCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIGdu dTogQWRkIGVtYWNzLWh0bWwtdG8taGljY3VwLgoKLS0tCiBnbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSB8IDMyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdl ZCwgMzIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXou c2NtIGIvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KaW5kZXggMTVmMjRjZGE1ZC4uY2EyZTI5 NmY0YSAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20KKysrIGIvZ251L3Bh Y2thZ2VzL2VtYWNzLXh5ei5zY20KQEAgLTI0NjIzLDMgKzI0NjIzLDM1IEBAIHB1YmxpY2FsbHkt YWNjZXNzaWJsZSBIVFRQIHNlcnZlci4iKQogbGFiZWwgcmVmZXJlbmNlcyBhbmQgY2l0YXRpb25z IGluIExhVGVYLiAgSXQgaXMgYmFzZWQgb24gUmVmVGVYLCB3aGljaCBpcwogaW5jbHVkZWQgd2l0 aCBFbWFjcy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMyspKSkKKworKGRlZmluZS1wdWJs aWMgZW1hY3MtaHRtbC10by1oaWNjdXAKKyAgOzsgUGFja2FnZSBoYXMgbm8gcmVsZWFzZS4gIFZl cnNpb24gaXMgZXh0cmFjdGVkIGZyb20gIlZlcnNpb246IiBrZXl3b3JkIGluCisgIDs7IG1haW4g ZmlsZS4KKyAgKGxldCAoKGNvbW1pdCAiNTBhNTJlMmIwZDEzZDg2NTE4N2FjZGY3NzViODIwM2Q1 MDAzZjJmMSIpCisgICAgICAgIChyZXZpc2lvbiAiMCIpKQorICAgIChwYWNrYWdlCisgICAgICAo bmFtZSAiZW1hY3MtaHRtbC10by1oaWNjdXAiKQorICAgICAgKHZlcnNpb24gKGdpdC12ZXJzaW9u ICIxIiByZXZpc2lvbiBjb21taXQpKQorICAgICAgKHNvdXJjZQorICAgICAgIChvcmlnaW4KKyAg ICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQorICAgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQor ICAgICAgICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXRodWIuY29tL3BsZXh1cy9odG1sLXRvLWhp Y2N1cCIpCisgICAgICAgICAgICAgICAoY29tbWl0IGNvbW1pdCkpKQorICAgICAgICAgKGZpbGUt bmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgKHNoYTI1NgorICAg ICAgICAgIChiYXNlMzIgIjFxaTA5Mm13Mm4wOHY2eXIwajZobHB4MHBubGNuaHhqcWJzcmx3OXBu NHlpbjZ6azkxeXAiKSkpKQorICAgICAgKGJ1aWxkLXN5c3RlbSBlbWFjcy1idWlsZC1zeXN0ZW0p CisgICAgICAocHJvcGFnYXRlZC1pbnB1dHMKKyAgICAgICBgKCgiZGFzaCIgLGVtYWNzLWRhc2gp CisgICAgICAgICAoInMiICxlbWFjcy1zKSkpCisgICAgICAoaG9tZS1wYWdlICJodHRwczovL2dp dGh1Yi5jb20vcGxleHVzL2h0bWwtdG8taGljY3VwIikKKyAgICAgIChzeW5vcHNpcyAiVHVybiBI VE1MIGludG8gSGljY3VwIHN5bnRheCIpCisgICAgICAoZGVzY3JpcHRpb24KKyAgICAgICAiVGhp cyBpcyBhbiBFbWFjcyBwYWNrYWdlIHRoYXQgdHVybnMgSFRNTCBpbnRvIEhpY2N1cCBzeW50YXgK K3doaWNoIGlzIGEgcG9wdWxhciBub3RhdGlvbiB0byB1c2Ugd2hlbiBkb2luZyBDbG9qdXJlL0Ns b2p1cmVTY3JpcHQKK3dlYiBkZXZlbG9wbWVudC4iKQorICAgICAgOzsgVGhlcmUgaXMgYSBjb25m bGljdCBiZXR3ZWVuIHRoZSByZXBvc2l0b3J5IG9mZmljaWFsIExJQ0VOU0UKKyAgICAgIDs7IGZp bGUgYW5kIHRoZSBoZWFkZXIgb2YgdGhlIG1haW4gZWxpc3AgZmlsZSB3aGljaCBpbmRpY2F0ZXMK KyAgICAgIDs7IHRoYXQgaXQgaXMgbGljZW5zZWQgdW5kZXIgdGhlIEdQTCB2ZXJzaW9uIDMgb3Ig bGF0ZXIuCisgICAgICAobGljZW5zZSAobGlzdCBsaWNlbnNlOm1wbDIuMCBsaWNlbnNlOmdwbDMr KSkpKSkKLS0gCjIuMjguMAoK --00000000000066f37305afabecd5--