On Wed, Sep 16, 2020 at 4:04 PM Nicolas Goaziou wrote: > Hello, > > Jesse Dowell writes: > > > I'm hoping the following patch can be useful for others. It's a package > for > > emacs-html-to-hiccup which can be very handy when working with clojure > > programs that use hiccup syntax. > > Thank you. > > Could you send the patch with "git format-patch" or "git send-email" ? > > > > --8<---------------cut here---------------start------------->8--- > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > > index ff043463cc..253e51a79c 100644 > > --- a/gnu/packages/emacs-xyz.scm > > +++ b/gnu/packages/emacs-xyz.scm > > @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.") > > label references and citations in LaTeX. It is based on RefTeX, which > is > > included with Emacs.") > > (license license:gpl3+))) > > + > > +(define-public emacs-html-to-hiccup > > + (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1") > > + (revision "0")) > > Could you add a comment explaining why we provide a non-released version > (here because there is no release anyway). > > + (package > > + (name "emacs-html-to-hiccup") > > + (version (git-version "20190909" revision commit)) > > It should be version "1.0" according to keyword in main file. > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url "https://github.com/plexus/html-to-hiccup") > > + (commit commit))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp")))) > > Could you move the string on the line above ? > > > + (build-system emacs-build-system) > > + (propagated-inputs > > + `(("dash" ,emacs-dash) > > + ("s" ,emacs-s))) > > There is an indentation issue here. > > > + (home-page "https://github.com/plexus/html-to-hiccup") > > + (synopsis "Emacs package that turns HTML into Hiccup syntax") > > It could be > > "Turn HTML into Hiccup syntax" > > > + (description > > + "Emacs package that turns HTML into Hiccup syntax, a notation > > popular > > +when doing Clojure/ClojureScript web development.") > > The description should be comprised of full sentences. Calling "guix > lint" on your definition should report it. Here, it could be: > > This Emacs package turns HTML... > > > + (license license:mpl2.0)))) > > LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe > you should add a comment about it. > > Could you send an updated patch? > > Regards, > -- > Nicolas Goaziou > Thanks for the feedback. I've attached a patch that incorporates all of your suggestions. Best, Jesse