unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / Atom feed
From: Jesse Dowell <jesse.dowell@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 43320@debbugs.gnu.org
Subject: [bug#43320] Add emacs-html-to-hiccup package
Date: Sat, 19 Sep 2020 11:03:32 -0400
Message-ID: <CADdvwM-JBok=g9hKRevYd0sjiz0EGvYAroYTxGyh4KeAjSLT1w@mail.gmail.com> (raw)
In-Reply-To: <87mu1p1oa5.fsf@nicolasgoaziou.fr>


[-- Attachment #1.1: Type: text/plain, Size: 2824 bytes --]

On Wed, Sep 16, 2020 at 4:04 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Jesse Dowell <jesse.dowell@gmail.com> writes:
>
> > I'm hoping the following patch can be useful for others. It's a package
> for
> > emacs-html-to-hiccup which can be very handy when working with clojure
> > programs that use hiccup syntax.
>
> Thank you.
>
> Could you send the patch with "git format-patch" or "git send-email" ?
> >
> > --8<---------------cut here---------------start------------->8---
> > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> > index ff043463cc..253e51a79c 100644
> > --- a/gnu/packages/emacs-xyz.scm
> > +++ b/gnu/packages/emacs-xyz.scm
> > @@ -24550,4 +24550,29 @@ publically-accessible HTTP server.")
> >  label references and citations in LaTeX.  It is based on RefTeX, which
> is
> >  included with Emacs.")
> >      (license license:gpl3+)))
> > +
> > +(define-public emacs-html-to-hiccup
> > +  (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1")
> > +        (revision "0"))
>
> Could you add a comment explaining why we provide a non-released version
> (here because there is no release anyway).
> > +    (package
> > +      (name "emacs-html-to-hiccup")
> > +      (version (git-version "20190909" revision commit))
>
> It should be version "1.0" according to keyword in main file.
> > +      (source
> > +       (origin
> > +         (method git-fetch)
> > +         (uri (git-reference
> > +               (url "https://github.com/plexus/html-to-hiccup")
> > +               (commit commit)))
> > +         (file-name (git-file-name name version))
> > +         (sha256
> > +          (base32
> > "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))
>
> Could you move the string on the line above ?
>
> > +      (build-system emacs-build-system)
> > +      (propagated-inputs
> > +     `(("dash" ,emacs-dash)
> > +       ("s" ,emacs-s)))
>
> There is an indentation issue here.
>
> > +      (home-page "https://github.com/plexus/html-to-hiccup")
> > +      (synopsis "Emacs package that turns HTML into Hiccup syntax")
>
> It could be
>
>   "Turn HTML into Hiccup syntax"
>
> > +      (description
> > +       "Emacs package that turns HTML into Hiccup syntax, a notation
> > popular
> > +when doing Clojure/ClojureScript web development.")
>
> The description should be comprised of full sentences. Calling "guix
> lint" on your definition should report it. Here, it could be:
>
>    This Emacs package turns HTML...
>
> > +      (license license:mpl2.0))))
>
> LICENSE file is mpl2.0, but the Elisp library has GPL3+ headers. Maybe
> you should add a comment about it.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>

Thanks for the feedback. I've attached a patch that incorporates all of
your suggestions.

Best,
Jesse

[-- Attachment #1.2: Type: text/html, Size: 4047 bytes --]

[-- Attachment #2: 0001-gnu-Add-emacs-html-to-hiccup.patch --]
[-- Type: text/x-patch, Size: 2013 bytes --]

From 4423243c4e86779e790eb1da003fa373415b347a Mon Sep 17 00:00:00 2001
From: Jesse Dowell <jessedowell@gmail.com>
Date: Sat, 19 Sep 2020 10:45:50 -0400
Subject: [PATCH] gnu: Add emacs-html-to-hiccup.

---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 15f24cda5d..ca2e296f4a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24623,3 +24623,35 @@ publically-accessible HTTP server.")
 label references and citations in LaTeX.  It is based on RefTeX, which is
 included with Emacs.")
     (license license:gpl3+)))
+
+(define-public emacs-html-to-hiccup
+  ;; Package has no release.  Version is extracted from "Version:" keyword in
+  ;; main file.
+  (let ((commit "50a52e2b0d13d865187acdf775b8203d5003f2f1")
+        (revision "0"))
+    (package
+      (name "emacs-html-to-hiccup")
+      (version (git-version "1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/plexus/html-to-hiccup")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1qi092mw2n08v6yr0j6hlpx0pnlcnhxjqbsrlw9pn4yin6zk91yp"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("dash" ,emacs-dash)
+         ("s" ,emacs-s)))
+      (home-page "https://github.com/plexus/html-to-hiccup")
+      (synopsis "Turn HTML into Hiccup syntax")
+      (description
+       "This is an Emacs package that turns HTML into Hiccup syntax
+which is a popular notation to use when doing Clojure/ClojureScript
+web development.")
+      ;; There is a conflict between the repository official LICENSE
+      ;; file and the header of the main elisp file which indicates
+      ;; that it is licensed under the GPL version 3 or later.
+      (license (list license:mpl2.0 license:gpl3+)))))
-- 
2.28.0


  reply	other threads:[~2020-09-19 15:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 20:43 Jesse Dowell
2020-09-16 20:04 ` Nicolas Goaziou
2020-09-19 15:03   ` Jesse Dowell [this message]
2020-09-22  9:48     ` bug#43320: " Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADdvwM-JBok=g9hKRevYd0sjiz0EGvYAroYTxGyh4KeAjSLT1w@mail.gmail.com' \
    --to=jesse.dowell@gmail.com \
    --cc=43320@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

unofficial mirror of guix-patches@gnu.org 

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix-patches/1 guix-patches/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 guix-patches guix-patches/ https://yhetil.org/guix-patches \
		guix-patches@gnu.org
	public-inbox-index guix-patches

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://news.yhetil.org/yhetil.gnu.guix.patches


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git