From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uEnGAIjfTWOMnAAAbAwnHQ (envelope-from ) for ; Tue, 18 Oct 2022 01:04:40 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KITVAIjfTWNSMQEAauVa8A (envelope-from ) for ; Tue, 18 Oct 2022 01:04:40 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65950F46B for ; Tue, 18 Oct 2022 01:04:39 +0200 (CEST) Received: from localhost ([::1]:33052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1okZ9y-000315-CJ for larch@yhetil.org; Mon, 17 Oct 2022 19:04:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52238) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okZ9Q-0002yW-Eq for guix-patches@gnu.org; Mon, 17 Oct 2022 19:04:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okZ9Q-0002UE-6a for guix-patches@gnu.org; Mon, 17 Oct 2022 19:04:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1okZ9Q-00085E-1c for guix-patches@gnu.org; Mon, 17 Oct 2022 19:04:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57590] [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted. Resent-From: Lukasz Olszewski Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Oct 2022 23:04:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57590 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 57590@debbugs.gnu.org Received: via spool by 57590-submit@debbugs.gnu.org id=B57590.166604778530937 (code B ref 57590); Mon, 17 Oct 2022 23:04:04 +0000 Received: (at 57590) by debbugs.gnu.org; 17 Oct 2022 23:03:05 +0000 Received: from localhost ([127.0.0.1]:50402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okZ8S-00082o-As for submit@debbugs.gnu.org; Mon, 17 Oct 2022 19:03:05 -0400 Received: from mail-oa1-f43.google.com ([209.85.160.43]:42659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okO2o-0002hx-PF for 57590@debbugs.gnu.org; Mon, 17 Oct 2022 07:12:31 -0400 Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-1370acb6588so12814442fac.9 for <57590@debbugs.gnu.org>; Mon, 17 Oct 2022 04:12:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lukaszolszewski-info.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hqwq3fJb6i7eOQ9945UHe2F0kjvvy5//ZlgfshCTHW8=; b=q+uqxf/F3cNkFtUmZ8lA28SIB9wwShetY7XIHs/aOJ8yD6jSspDNUChEesrmjUQO35 AEvNtx9eH9ouNJv+D0M91ojPSCVHTUZdWMd6+1R0npCx/DW3M9zsNe30W8VTjiuOvbz1 ntn0SlsRPHfEiIA+RuYtTz1cuhe5kMY9xenHQkGN8OxeDTvhI4Nvnduz8oKZBZddlJxv M+L/u3icSZkKJuarPfsFIFCXB+3cvIX/Lg68+yWWLbF6oh/zpwDSm1jmgS7AXsBx7Gc0 ljzNUzydDhFu0LBkNYWBBhkFNrG298dkfq8vpcu53QRPZowB+WgyWSd6bQhB9CnHHTdd 9ukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hqwq3fJb6i7eOQ9945UHe2F0kjvvy5//ZlgfshCTHW8=; b=lGYX6R1zKk6w2fde1XKk8sIawcsfF7z82enwQgUkDJ7TdP4qqsiQz12qfwYNcXVSRK BU6CuFh0VM9yMAaNBRRgzCytyLTTaeWv09KxJvQCy/meVt178GQl0d6+ySoG+tBhBh1y jwaLrgr/sRUGXK65xyrntiOkNmYHhzfEwDkFIKCkrDDSresXKZ6zUGLAk61ZNdlbuFLS coDhGyPNDQ026JMzEBWTGoLCjF1n1w6mQrcdgU5P9gQLnpgef6iDlPy+wvTPS2uLRLgt AHPvuB64sKZZQxSOb9vVYOy08n+T+NzC6X3UQhtl4OXyNICTxXff9abDJpL3Fc0IA9A2 ZqlA== X-Gm-Message-State: ACrzQf3libWxXog5owO1lo5tHGeHWE97tqM+SBOoOVHwBYvbsccDV0yj 3TmUSg1mhUuvyU1ecrn1q+92hOFJTQbxgN8xFfXKaA== X-Google-Smtp-Source: AMsMyM5L3Hbwy0cvEtA8wcjof7zmLD6M2n/J51f+ospByjGIilOsUsaHeKsBYrBeJ1HxYQFT6XN4xFwpvX6pOMa8s2M= X-Received: by 2002:a05:6870:c084:b0:132:f48a:b488 with SMTP id c4-20020a056870c08400b00132f48ab488mr15154370oad.94.1666005144789; Mon, 17 Oct 2022 04:12:24 -0700 (PDT) MIME-Version: 1.0 References: <87tu42ho62.fsf@gnu.org> In-Reply-To: <87tu42ho62.fsf@gnu.org> From: Lukasz Olszewski Date: Mon, 17 Oct 2022 13:12:13 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000d97c0005eb390c1c" X-Mailman-Approved-At: Mon, 17 Oct 2022 19:03:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666047879; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hqwq3fJb6i7eOQ9945UHe2F0kjvvy5//ZlgfshCTHW8=; b=errWg4Qs/fxAUXLvDrArSBDMRBeqZofZoTyUqrkt13UkqZ+u0JZN8N5b4b4U8PO4PEFHqB tSOiGHIAEsr07DRYoe4GX/HMRJ/7Cq2MpVXrsL9LS9MQ7Qz7y1OQ/MrOghsJaGO/F23Cou Jf+hUHd/wKNCCPj7ADITaHi8Ufqqyj5T+w+5im7O1AOYbNrNCDRR0Rw+Nm5xdpnAGxvNR+ Sduzhs6yvfvjvcA3yBR5zcFf5JMwgAWznbHIsAdeahD/gfSQAYe0S+kxoQ293a9FUFv+Cr 6/zFfg8hXBhV85jRvFls5xA3WdJF40ny6JwvVl984O3YuKgagZ+3Yrxv1k5A+Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666047879; a=rsa-sha256; cv=none; b=c0s+ul5m5ugeAVd5Px9XQbXe6OTTgH521K+DVgYo29rkZWFXJQZt+DPGkWedY8uXg4QZUM YC84zq2qKcUVw+oElg5ZzgMK4WqLQMgiUKr3FEMl3IRs1Bc8SzwuTg5WAb9Tf75Zf3Ax5i YBnIl5lEUV1nkoLOXuTln1YSeZsDuPtz9KQufjVK0euacBn1+iIR73wCoXeiz2I+aVJs8M PMoDqo2ClHCNmU+MGF26CrQwkPdSRJX1gijaerppO2U9TxcPmS51wZ+wr1B+drgzKruTZ6 LwTZEpAmwsGBGGvoyzCuG8i7T0d3k0H+VR5t/+LeWy0N8CTcmjCtjJCmt6D7wg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lukaszolszewski-info.20210112.gappssmtp.com header.s=20210112 header.b="q+uqxf/F"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.58 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lukaszolszewski-info.20210112.gappssmtp.com header.s=20210112 header.b="q+uqxf/F"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 65950F46B X-Spam-Score: 2.58 X-Migadu-Scanner: scn1.migadu.com X-TUID: kKRTUn7ZkviM --000000000000d97c0005eb390c1c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, No problem at all regarding the delay. Unfortunately I've been busier than usual in last few weeks (this is likely to continue for few more weeks). Regarding the comments please see inline below. On Mon, 17 Oct 2022, 10:03 Ludovic Court=C3=A8s, wrote: > Hi Lukasz, > > Apologies for the delay! > > I think the patch series is close to being ready; we=E2=80=99ll need a fe= w > changes before we=E2=80=99re done. > > Lukasz Olszewski skribis: > > > --- > > gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++++++++ > > gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++ > > Please make one patch adding the package, and another one adding the > service. > > In each patch, please make sure to add the new file to gnu/local.mk (you > can check the Git history for examples.) > Ok, will do. > > +++ b/gnu/packages/libldm.scm > > @@ -0,0 +1,70 @@ > > +(define-module (gnu packages libldm) > > We=E2=80=99ll need the license/copyright header as you noted. > I've posted a later patch that included those, but it was posted as a patch on top of a patch so perhaps it wasn't well visible. I'll integrate it in the next version. > > + (arguments > > + '(#:tests? #f > > Please add a comment explaining why tests are skipped. That should be a > last resort. > > > + #:parallel-build? #t > > This is unnecessary. > Are parallel builds enabled by default? Or is there a convention not to enable then unless some requirements are met? > > + #:phases (modify-phases %standard-phases > > + (add-before 'configure 'set-env > > + (lambda _ > > + (setenv "CONFIG_SHELL" > > + (which "")) #t)) > > I don=E2=80=99t think this can work because (which "") returns #f but =E2= =80=98setenv=E2=80=99 > expects a string. > I'll have to test it without. If setenv indeed fails now then it should continue to work without it. > > + (replace 'bootstrap > > + (lambda _ > > + (invoke "autoreconf" "-fiv")))))) > > Is it necessary? The default =E2=80=98bootstrap=E2=80=99 phase does some= thing similar. > I've copied this phase from another package. If I remember correctly the configure phase failed without. I'll have to test again to check. > > + (license license:gpl3))) > > This should be =E2=80=98license:gpl3+=E2=80=99 because source file header= s carry the =E2=80=9Cor > any later version=E2=80=9D wording. > Ok, will do. > > +(define-record-type* > > + libldm-configuration > > + make-libldm-configuration > > + libldm-configuration? > > + (package > > + libldm-configuration-package > > + (default libldm)) > > + (action libldm-configuration-action > > + (default '("create" "all")))) > > Indentation is off here (I noticed that =E2=80=98guix style=E2=80=99 got = it wrong so I=E2=80=99m > fixing it now=E2=80=A6). > OK, I'll keep the above. > > +(define (libldm-shepherd-service config) > > + "Return a for libldm with CONFIG" > > + (let* ((libldm (libldm-configuration-package config)) > > + (action (libldm-configuration-action config))) > > + (list (shepherd-service (documentation > > + "Run ldmtool to create Windows dynamic > > disc device nodes at startup.") > > Maybe s/disc/disk/ throughout for consistency? > Ok > > +(define libldm-service-type > > + (service-type (name 'libldm) > > + (extensions (list (service-extension > > + shepherd-root-service-type > > + libldm-shepherd-service))) > > + (default-value (libldm-configuration)) > > + (description > > + "Run ldmtool to create device nodes for Windows > > dynamic discs so they can be mounted"))) > > Please add a period at the end, and write @command{ldmtool}. > > One last thing: could you add documentation for the service in > doc/guix.texi, maybe under =E2=80=9CVirtualization=E2=80=9D or in some ne= w section? > Please include a paragraph giving some context and an example. > OK, will do. > Could you send updated patches? > If I don't manage to do it this week, then on the weekend. > > Thanks in advance! > > Ludo=E2=80=99. > Regards, Lukasz > --000000000000d97c0005eb390c1c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,=C2=A0

No problem=C2=A0at all regarding the delay. Unfortunately I'v= e been busier than usual in last few weeks (this is likely to continue for = few more weeks).=C2=A0

R= egarding the comments please see inline below.=C2=A0

On Mon, 17 O= ct 2022, 10:03 Ludovic Court=C3=A8s, <lu= do@gnu.org> wrote:
Hi Lukas= z,

Apologies for the delay!

I think the patch series is close to being ready; we=E2=80=99ll need a few<= br> changes before we=E2=80=99re done.

Lukasz Olszewski <dev@lukaszolszewski.info> skribis:

> ---
>=C2=A0 gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++= ++++++
>=C2=A0 gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++

Please make one patch adding the package, and another one adding the
service.

In each patch, please make sure to add the new file to gnu/local.mk (y= ou
can check the Git history for examples.)

Ok, will do.=C2=A0

=

> +++ b/gnu/packages/libldm.scm
> @@ -0,0 +1,70 @@
> +(define-module (gnu packages libldm)

We=E2=80=99ll need the license/copyright header as you noted.

I've poste= d a later patch that included those, but it was posted as a patch on top of= a patch so perhaps it wasn't well visible. I'll integrate it in th= e next version.=C2=A0


> +=C2=A0 =C2=A0 (arguments
> +=C2=A0 =C2=A0 =C2=A0'(#:tests? #f

Please add a comment explaining why tests are skipped.=C2=A0 That should be= a
last resort.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:parallel-build? #t

This is unnecessary.

Are parallel builds enabled by default? Or is there a c= onvention not to enable then unless some requirements are met?=C2=A0
<= div dir=3D"auto">

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0#:phases (modify-phases %standard-phases > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-b= efore 'configure 'set-env
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (setenv "CONFIG_SHELL"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (which "")) #t))

I don=E2=80=99t think this can work because (which "") returns #f= but =E2=80=98setenv=E2=80=99
expects a string.

<= div dir=3D"auto">I'll have to test it without. If setenv indeed fails n= ow then it should continue to work without it.=C2=A0


> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (repla= ce 'bootstrap
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (lambda _
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 (invoke "autoreconf" "-fiv"))))))

Is it necessary?=C2=A0 The default =E2=80=98bootstrap=E2=80=99 phase does s= omething similar.

<= div dir=3D"auto">I've copied this phase from another package. If I reme= mber correctly the configure phase failed without. I'll have to test ag= ain to check.=C2=A0


> +=C2=A0 =C2=A0 (license license:gpl3)))

This should be =E2=80=98license:gpl3+=E2=80=99 because source file headers = carry the =E2=80=9Cor
any later version=E2=80=9D wording.

Ok, will do.=C2=A0


> +(define-record-type* <libldm-configuration>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0libldm-configuration
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0make-libldm-configuration
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0libldm-configuration?
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(package
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0libldm-configuration-package
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0(default libldm))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(action libldm-configuration-action
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(default '("create" "= all"))))

Indentation is off here (I noticed that =E2=80=98guix style=E2=80=99 got it= wrong so I=E2=80=99m
fixing it now=E2=80=A6).

=
OK, I'll keep the above.=C2=A0

=

> +(define (libldm-shepherd-service config)
> +=C2=A0 "Return a <shepherd-service> for libldm with CONFIG= "
> +=C2=A0 (let* ((libldm (libldm-configuration-package config))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(action (libldm-configuration-actio= n config)))
> +=C2=A0 =C2=A0 (list (shepherd-service (documentation
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Run ldmtool to create Windows dyna= mic
> disc device nodes at startup.")

Maybe s/disc/disk/ throughout for consistency?
=

Ok

> +(define libldm-service-type
> +=C2=A0 (service-type (name 'libldm)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (extensions (= list (service-extension
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0shepherd-root-servi= ce-type
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libldm-shepherd-ser= vice)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (default-valu= e (libldm-configuration))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (description<= br> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"R= un ldmtool to create device nodes for Windows
> dynamic discs so they can be mounted")))

Please add a period at the end, and write @command{ldmtool}.

One last thing: could you add documentation for the service in
doc/guix.texi, maybe under =E2=80=9CVirtualization=E2=80=9D or in some new = section?
Please include a paragraph giving some context and an example.

OK, will do.= =C2=A0


Could you send updated patches?

If I don't manage to do it this week, th= en on the weekend.=C2=A0



Thanks in advance!

Ludo=E2=80=99.

Regards,=C2=A0
Lukasz=C2=A0
--000000000000d97c0005eb390c1c--