[-- Attachment #1: Type: text/plain, Size: 243 bytes --] I would like to reuse assert-valid-graph function for home-shepherd-service for `guix home` I'm currently implementing. It seems reasonable to make this function public instead of copying or reimplementing it. -- Best regards, Andrew Tropin [-- Attachment #2: 0001-gnu-services-shepherd-Make-assert-valid-graph-public.patch --] [-- Type: application/x-patch, Size: 758 bytes --]
Hi Andrew,
Andrew Tropin <andrew@trop.in> skribis:
> From ffc244f5845996bf4b0365024ac866c86cef81df Mon Sep 17 00:00:00 2001
> From: Andrew Tropin <andrew@trop.in>
> Date: Thu, 18 Feb 2021 13:30:22 +0300
> Subject: [PATCH] gnu: services: shepherd: Make assert-valid-graph public
>
> ---
> gnu/services/shepherd.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
I added a commit log and pushed as
63bee8f0addc95c81426199c9fbf1d0bcf7f1450.
As mentioned on IRC, note that this kind of procedure doesn’t make for a
great API, which is why it’s usually kept private. Second, if a
procedure like this one doesn’t have any user in Guix proper, it could
well be removed or changed incompatibly, so beware.
In this case, I think it’s acceptable to make it public though.
Thanks and apologies for the delay!
Ludo’.
> As mentioned on IRC, note that this kind of procedure doesn\u2019t make for a > great API, which is why it's usually kept private. Second, if a > procedure like this one doesn't have any user in Guix proper, it could > well be removed or changed incompatibly, so beware. Took into account. Hope, it will be used by one small guix's module someday) Plan to propose to include `guix home` in guix repo. https://git.sr.ht/~abcdw/rde/tree/master/item/gnu > > In this case, I think it's acceptable to make it public though. > > Thanks and apologies for the delay! > > Ludo'. Thank you for all your work! -- Best regards, Andrew Tropin