From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oDoHD4nbs19fNQAA0tVLHw (envelope-from ) for ; Tue, 17 Nov 2020 14:17:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id uNvFConbs19YRgAAbx9fmQ (envelope-from ) for ; Tue, 17 Nov 2020 14:17:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 665F594050F for ; Tue, 17 Nov 2020 14:17:43 +0000 (UTC) Received: from localhost ([::1]:38882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kf1ni-0003K8-MZ for larch@yhetil.org; Tue, 17 Nov 2020 09:17:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kf1kB-0007br-Dc for guix-patches@gnu.org; Tue, 17 Nov 2020 09:14:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kf1kA-0002Lm-Io for guix-patches@gnu.org; Tue, 17 Nov 2020 09:14:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kf1kA-0006F4-Dv for guix-patches@gnu.org; Tue, 17 Nov 2020 09:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44269] [PATCH] gnu: Add eosio-cdt. Resent-From: Jesse Eisses Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 17 Nov 2020 14:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44269 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 44269@debbugs.gnu.org Received: via spool by 44269-submit@debbugs.gnu.org id=B44269.160562240623907 (code B ref 44269); Tue, 17 Nov 2020 14:14:02 +0000 Received: (at 44269) by debbugs.gnu.org; 17 Nov 2020 14:13:26 +0000 Received: from localhost ([127.0.0.1]:58739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf1jX-0006DT-Dx for submit@debbugs.gnu.org; Tue, 17 Nov 2020 09:13:25 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:36223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kewEL-0001cu-6R for 44269@debbugs.gnu.org; Tue, 17 Nov 2020 03:20:50 -0500 Received: by mail-pl1-f177.google.com with SMTP id k7so9851324plk.3 for <44269@debbugs.gnu.org>; Tue, 17 Nov 2020 00:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unraveled-tech.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mZgroCHFzqmWXGSr4kP0viUKDG7NVT76Q9j0eOFIpP8=; b=ZPSR8B8XRoqtV5mnh/yPTgrpgVm1fBR+osD+9M2lbVwALLhTq4GaNt38/71xLYJrWR PM+e5kNFiY1AbRAPc94voCA50ZYHaR4YAft1ftUvGtd06/5yInmDrQ/sqgO7i+G1kzcS XqOiRUp64HmT8pYtAYJMft1fF8P/dzzbqwocP+Fu5B9H9r1VhKAh7+FANLKTyMj/ZzQA 1cbAxNtChFk6ulZ4Tz2Wz/kAgP6hjLv9pG+ELqSReyXhTYLcU+RgGxYlJdKFIHUX9lY6 0CKwPzGIvvZmIrWJnLpjF7phvTDADDnIsMYpd6eGjsYimDU2IVSewQqpYGU7Cl+2UiDv MOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mZgroCHFzqmWXGSr4kP0viUKDG7NVT76Q9j0eOFIpP8=; b=ZpP6s2QXOSxdwjWZMgMUVM8yjumiu1Q9tpKRsWRJGYQNWB4xqH+6TsexxS9oG9jLET gW564ChiMVT9hhs5Bfc5TbKsWuvIwh8OR/P0e5XGLAn9sp9dn+n4c4kOHoZKP58l59rY w1KdK2oy/4SIGIFH4JWrvCO/Ca0HaE/LShubtZgFiLL+TPouvw+92L92Q+L+wv3tNlK3 BFGC16cWjD2a85gZKILcS5EI/XNmYgVn6ApD56YFa8AcWNfwrV1HC5NmQcGTtXik2oIt H9HDeQ0icY23Im+gtBlVoxlE9ZJOp9CPHYTh/GGcBcd3VxcmIMqYqhlKBSgQXGt7WAxi HPeg== X-Gm-Message-State: AOAM533BVcb0rTEK55kVePJvL0m1+kNaRYPGPUqY9MerQXjD8xVKlgYU KHtxxYLvuI2OLDMFufwy8+8UIvEg9UfTURUAzHRK6AaKUJSr7iHo X-Google-Smtp-Source: ABdhPJymLjGK4hMM426gwaChCaenF5W7rb/ggy8/JABc+GPOCHr3TNEoAkES88+4Yaainev51o5F74GiPBjsumr95pg= X-Received: by 2002:a17:90b:19d8:: with SMTP id nm24mr3491695pjb.144.1605601243207; Tue, 17 Nov 2020 00:20:43 -0800 (PST) MIME-Version: 1.0 References: <20201027211246.573113-1-jesse@unraveled.tech> <87eel1dkt9.fsf@gnu.org> In-Reply-To: <87eel1dkt9.fsf@gnu.org> From: Jesse Eisses Date: Tue, 17 Nov 2020 09:20:32 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Tue, 17 Nov 2020 09:13:21 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=unraveled-tech.20150623.gappssmtp.com header.s=20150623 header.b=ZPSR8B8X; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: kSfIz9JGiOT0 Thanks for the feedback As there are changes made to LLVM and libcxx for eosio-cdt I think we have to compile them. These large dependencies are included as git submodules though, so I will try to put them in separate packages. The comments are clear; I'm working on an updated patch :) - Jesse Op di 10 nov. 2020 om 21:22 schreef Marius Bakke : > > jesse@unraveled.tech writes: > > > Hi all! > > > > This is my first patch, I hope I'm doing it correctly. > > Cool, welcome! > > The patch is lacking a proper commit message, but looks pretty good > overall. Some comments follow. > > > The patch below adds the Contract Development Toolkit (compiler) for smart > > contracts on the EOS blockchain. I also have a package for EOS itself that is > > a bit more involved, so I'll submit separately. > > > > Total package size is 607MB of which self is 329MB. It takes a while to > > compile (about an hour on my i7 laptop). > > I suppose some of that time is because of the bundled LLVM, libcxx, > etc. Do you know if it's possible to remove those, or at least build > them separately? > > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > > index 4397cf8ba8..0e661c4b56 100644 > > --- a/gnu/packages/finance.scm > > +++ b/gnu/packages/finance.scm > > Can you also add your name to the list of authors at the top of the file? > > > @@ -59,6 +59,7 @@ > > #:use-module (gnu packages compression) > > #:use-module (gnu packages crypto) > > #:use-module (gnu packages curl) > > + #:use-module (gnu packages cmake) > > I believe this import is unused. > > [...] > > > +(define-public eosio-cdt > > + (package > > + (name "eosio-cdt") > > + (version "1.7.0") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference (url "https://github.com/EOSIO/eosio.cdt") > > + (commit (string-append "v" version)) > > + (recursive? #t))) > > + (sha256 > > + (base32 > > + "1mrc8dn7sf086456c63rlha4j3fh0g1a59dbd6in6nyhan712xps")) > > + (file-name (git-file-name name version)))) > > + (build-system cmake-build-system) > > + (native-inputs > > + `(("git" ,git) > > It looks like the git dependency comes from > "modules/ClangExternalProject.txt". Though I don't see it being used. > Can you try to substitute* out the "find_package(Git ...)" statement and > see if it's possible to make it work without it? > > It's not uncommon that build scripts look for git even when it's not > strictly needed. By removing the dependency we avoid needlessly > rebuilding this package every time git is updated. > > > + ("doxygen" ,doxygen) > > + ("pkg-config" ,pkg-config) > > + ("curl" ,curl))) > > + (inputs > > + `(("gmp" ,gmp) > > + ("openssl" ,openssl) > > + ("python" ,python-3))) > > + (arguments > > + `(#:build-type "Release")) > > Is there a particular reason to use a "Release" build here (as opposed > to the default "RelWithDebInfo")? Guix is a hackers distro, and > debugging symbols are nice. :-) > > > + (home-page "https://developers.eos.io/manuals/eosio.cdt/latest/index") > > + (synopsis "EOSIO.CDT is a suite of tools used to build EOSIO contracts") > > Just "Suite of tools to build EOSIO contracts". > > Otherwise the patch looks great. Can you send an updated version?