From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EHveLIA232MvBAEAbAwnHQ (envelope-from ) for ; Sun, 05 Feb 2023 05:54:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2B/MLIA232MqIgEAauVa8A (envelope-from ) for ; Sun, 05 Feb 2023 05:54:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47086299C7 for ; Sun, 5 Feb 2023 05:54:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOX2S-0008El-Ha; Sat, 04 Feb 2023 23:54:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOX2Q-0008EA-Ht for guix-patches@gnu.org; Sat, 04 Feb 2023 23:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOX2Q-0001sN-9k for guix-patches@gnu.org; Sat, 04 Feb 2023 23:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOX2Q-00014N-5g for guix-patches@gnu.org; Sat, 04 Feb 2023 23:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61263] [PATCH] gnu: dbacl: Fix failing check phase. Resent-From: "Danny O'Brien" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Feb 2023 04:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61263 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 61263@debbugs.gnu.org X-Debbugs-Original-Cc: 61263@debbugs.gnu.org, guix-patches@gnu.org Received: via spool by 61263-submit@debbugs.gnu.org id=B61263.16755728214076 (code B ref 61263); Sun, 05 Feb 2023 04:54:02 +0000 Received: (at 61263) by debbugs.gnu.org; 5 Feb 2023 04:53:41 +0000 Received: from localhost ([127.0.0.1]:43748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOX25-00013b-9c for submit@debbugs.gnu.org; Sat, 04 Feb 2023 23:53:41 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:35346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOX20-00013B-2D for 61263@debbugs.gnu.org; Sat, 04 Feb 2023 23:53:38 -0500 Received: by mail-wm1-f43.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso8634163wms.0 for <61263@debbugs.gnu.org>; Sat, 04 Feb 2023 20:53:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0c74Er792dBL+6mAI+CYKC3cHyGWIu22HLtubxnKF1o=; b=rvR1bxnZBoQ9WsgIjLj/aBnIZ+ku4XD5yw92GqqE31C8vZqFQj57KPqYlXiTAhSJd3 NZBS6EFZSxAGMDkSG8i/6R/mYp3G8tTn82P9hOufhoCfHVfEH85nO2ADmcSvsCn0JDAp zSOHYyZe2VGeVg3+nA7trNh8vnwdwUNHWhILyjeOQKLeLCWcq8gSk1Rh0sz0dRfrZ7o3 biaMJR5m3JX0lsY9wxTPAPLHebOv6I1cG8SoMiqN6CcjwjUQ+VcapPD2SomeYQkTNVjR LBu3j1MNftNe8hKGSrtd2/gkG1PVANRNxan+U/ejBC0gVzJHlekyizpSx3FSIeDk/QjF pu2g== X-Gm-Message-State: AO0yUKUoqhTsT8T0euwpaC9PTNnFxiLyyX3bLvFlx54FbRoZFWI4czQ+ 5ss/vPVa1xzKS9/jXEkIxJvWxVwga9OXDx4s2rPZZVI= X-Google-Smtp-Source: AK7set/NqSVi7vh8JvPEOtGQrRzmWSjBRsWDO5jlABpq6Y1hkx8xkws7wBPCzn9gmVGZG1iVQ7PwLHv6s/RvcfppXyU= X-Received: by 2002:a05:600c:4313:b0:3df:fbd5:6a2 with SMTP id p19-20020a05600c431300b003dffbd506a2mr34087wme.204.1675572810125; Sat, 04 Feb 2023 20:53:30 -0800 (PST) Received: from 649336022844 named unknown by gmailapi.google.com with HTTPREST; Sat, 4 Feb 2023 23:53:29 -0500 Mime-Version: 1.0 X-Superhuman-Draft-ID: draft002156fcd2a565e4 In-Reply-To: <1FBBFFA5-565C-4CD2-8744-518652E1DC53@tobias.gr> References: <2f81f17ea425ae674aedb7f92826e58c8bea4412.1675487305.git.danny@spesh.com> <1FBBFFA5-565C-4CD2-8744-518652E1DC53@tobias.gr> From: "Danny O'Brien" X-Mailer: Superhuman Web (2023-02-04T00:25:39Z) X-Superhuman-ID: ldqwrxr2.dfc1cd4e-7db2-46d5-b9e4-69c2fe5ecb3f Date: Sat, 4 Feb 2023 23:53:29 -0500 Message-ID: Content-Type: multipart/alternative; boundary="00000000000024955705f3ecb22d" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675572864; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=0c74Er792dBL+6mAI+CYKC3cHyGWIu22HLtubxnKF1o=; b=aWuXIWlGHhc2wR1iT1C99IUevoJM+p71yUl262XzGfzu5tfs98IW6xSoIW/mlZWf4Sp0If 9Jfl3So8GMDjwIS7/PUr/rlZpl+jy5hFdLkH+HqXv1C48DZhJKG94nswWpeGMmFUt8Sd2u ZdcJHDAumJXJsFh1I5vKOZCLtN0BhPb9eB1RFrLDlGKC53/yDC8kNR3GDbpGC5x1mxglIn fh7cqhu9QKdX+fH4XvO6dy4xbFuqbBC8NpfS/KGjwd0dZqVLxfg0hYBNIjbM7rvbSiJLgv XocBRw3r56WoaO0WPAwl9SD3Z6WYoygqZKluc5MrpkrVYdBJYQETWOYpjZMilw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675572864; a=rsa-sha256; cv=none; b=TFWcsLqAnFlJNAhwxpMOfBLniGE2w3gc0ZFmfPW07Ycyt786i0zSpzVsg1IvZAI3Pe1lYW iXtSVcjWX8s+8HI1oEWhjhJHIXEh+1j1bGWdWDfOxVrvkrlrn2ngiGVTC1GbD4xumRQt/q tB8bbfJzxqQ+DW7KW4BFPMfChMMp+ES3Oz4JLc21DPIBeuio9Ag2hlU9nUBMsui1XyeKdG J0QKGE8ateBfqoNwrBSXdCa4Xdfy5CzPn7dto86nVw9ff0SgcQy7BA65LGQfWRf2GNk+6I CmdG+CrqS0r1SiPv4jUWvOhAAJ1gHB/2G8JHQCt0WSd/MW9EoEi/qkz578LYGA== X-Migadu-Spam-Score: -1.59 X-Spam-Score: -1.59 X-Migadu-Queue-Id: 47086299C7 Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-Migadu-Scanner: scn1.migadu.com X-TUID: 2EANF9KS98vp --00000000000024955705f3ecb22d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 04, 2023 at 2:07 AM, Tobias Geerinckx-Rice wrote= : > Hi Danny, > > Low-quality review incoming. > > I've merged the two duplicate-looking bugs 61263 & 61270. What happened? > I think I didn't spot that the earlier submission went through. > When adding new patch files, you need also add them to gnu/local.mk's > sorted dist_patch_DATA list. Thanks for submitting it upstream! > Ah, will do! Reviewing the rest in K-9 is difficult because of the sweeping indentation > changes. Could you submit a v2 without them? > > I suspect I'm disagreeing with 'guix style' and not with you, but the > 'source' , '#t', and comment changes are steps back IMO (that poor "/"!). > > As a rule, there's no requirement to blanket reformat existing code in > Guix. 'guix style' isn't there yet. > > Removing the obsolete '#t's entirely is welcome though=E2=80=94in a separ= ate > commit. > > Thanks! > > T G-R > > Sent on the go. Excuse or enjoy my brevity. > Yep, that was all due to `guix style` =E2=80=94 the instructions say to run= it, but that may be different if it's just tweaking an existing hand-crafted package description. I'll re-submit. Thanks for your suggestions! d. --00000000000024955705f3ecb22d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable




On Sat, Feb 04, 2023= at 2:07 AM, Tobias Geerinckx-Rice <me@tobias.gr><= /span> wrote:
=

Hi Danny,

Low-quality review incoming.

I've merged the two duplicate-looking bugs 61263 & 61270. What hap= pened?


I think I didn't spot that the earlier subm= ission went through.


When adding new patch files, you need also add them to = gnu/local.mk's sorted dist_patch_DATA list. Thanks for s= ubmitting it upstream!


Ah, will do!



Reviewing the rest in K-9 is difficult because of the sweeping indentation = changes. Could you submit a v2 without them?

I suspect I'm disagreeing with 'guix style' and not with you, b= ut the 'source' , '#t', and comment changes are steps back = IMO (that poor "/"!).

As a rule, there's no requirement to blanket reformat existing code in = Guix. 'guix style' isn't there yet.

Removing the obsolete '#t's entirely is welcome though=E2=80=94in a= separate commit.

Thanks!

T G-R

Sent on the go. Excuse or enjoy my brevity.



Yep, that was = all due to `guix style` =E2=80=94 the instructions say to run it, but that = may be different if it's just tweaking an existing hand-crafted package= description. I'll re-submit.

Thanks for y= our suggestions!

d.

--00000000000024955705f3ecb22d--