unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Brian Leung <bkleung89@gmail.com>
To: 36999@debbugs.gnu.org, Oleg Pykhalov <go.wigust@gmail.com>
Subject: [bug#36999] [PATCH] gnu: Add emacs-forge.
Date: Wed, 14 Aug 2019 08:08:23 +0200	[thread overview]
Message-ID: <CAAc=MEyGTJ5rc1v_0rTXacx6ViXk6RUy-qVgwmj6b_pLarj8ng@mail.gmail.com> (raw)
In-Reply-To: <CAAc=MExLy10n8RvUJ14bMU5qhTmgoJAsgoiNgy3x1J0iDi6diA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 672 bytes --]

Hi Oleg,

I've made a patch off the latest master branch with a version of emacs-ghub
that should meet the requirements of emacs-forge.

Best,
Brian

On Sun, Aug 11, 2019 at 7:39 PM Brian Leung <bkleung89@gmail.com> wrote:

> Hi Oleg,
>
> I notice that emacs-forge, in its forge-pkg.el file, mentions newer
> dependencies than what we currently have: ghub version 20190319, which
> apparently contains a fix for a relevant bug; and Magit version 20190408.
> I'm not sure how important the update to Magit is, and this newer version
> of Magit also happens to depend on an additional package, libegit2. It
> might be nice to update our version of ghub.
>
> Best,
> Brian
>

[-- Attachment #1.2: Type: text/html, Size: 1106 bytes --]

[-- Attachment #2: 0001-gnu-emacs-ghub-Update-to-3.2.0-1.7d59937.patch --]
[-- Type: text/x-patch, Size: 3399 bytes --]

From 8f7c7623743cf2b0bc06b9ae34bac7ac2b1e7994 Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Wed, 14 Aug 2019 08:04:20 +0200
Subject: [PATCH] gnu: emacs-ghub: Update to 3.2.0-1.7d59937.

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 3.2.0-1.7d59937.
---
 gnu/packages/emacs-xyz.scm | 62 ++++++++++++++++++++------------------
 1 file changed, 32 insertions(+), 30 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6e612cab56..23e5e09d2a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -521,39 +521,41 @@ deliver data to mobile and web apps.")
    (license license:gpl3+)))
 
 (define-public emacs-ghub
-  (package
-    (name "emacs-ghub")
-    (version "3.2.0")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                     (url "https://github.com/magit/ghub")
-                     (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "0lp52qygyavddl1lrgsyb6mq7hcf9h89dy2pzya3mb2va49f0vvl"))))
-    (build-system emacs-build-system)
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-before 'install 'make-info
-           (lambda _
-             (invoke "make" "info"))))))
-    (native-inputs
-     `(("texinfo" ,texinfo)))
-    (propagated-inputs
-     `(("dash" ,emacs-dash)
-       ("graphql" ,emacs-graphql)
-       ("treepy" ,emacs-treepy)))
-    (home-page "https://github.com/magit/ghub")
-    (synopsis "Emacs client libraries for the APIs of various Git forges")
-    (description
-     "Ghub provides basic support for using the APIs of various Git forges from
+  ;; We need a newer commit to avoid problems in emacs-forge.
+  (let ((commit "7d59937d7782d0062216130a4d059b45e8396f82")
+        (revision "1"))
+    (package
+      (name "emacs-ghub")
+      (version (git-version "3.2.0" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/magit/ghub")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1ngb61nij9gznqplwg1fmr1vq1czry759hmdibzngl4wqhxpfsjq"))))
+      (build-system emacs-build-system)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-before 'install 'make-info
+             (lambda _
+               (invoke "make" "info"))))))
+      (native-inputs
+       `(("texinfo" ,texinfo)))
+      (propagated-inputs
+       `(("dash" ,emacs-dash)
+         ("treepy" ,emacs-treepy)))
+      (home-page "https://github.com/magit/ghub")
+      (synopsis "Emacs client libraries for the APIs of various Git forges")
+      (description
+       "Ghub provides basic support for using the APIs of various Git forges from
 Emacs packages.  It supports the REST APIs of Github, Github GraphQL, Gitlab,
 Gitea, Gogs and Bitbucket.  It abstracts access to API resources using only a
 handful of functions that are not resource-specific.")
-    (license license:gpl3+)))
+      (license license:gpl3+))))
 
 (define-public emacs-scribble-mode
   (let ((commit "34e9e5edb921813b6483e0fefa848efb6ee4b314")
-- 
2.22.0


  reply	other threads:[~2019-08-14  6:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-10 16:18 [bug#36999] [PATCH] gnu: Add emacs-forge Oleg Pykhalov
2019-08-11 17:39 ` Brian Leung
2019-08-14  6:08   ` Brian Leung [this message]
2019-08-18  9:26     ` Oleg Pyhalov
2019-10-05 19:19 ` [bug#36999] [PATCH 0/4] More test and then merge to master Oleg Pykhalov
2019-10-05 19:19   ` [bug#36999] [PATCH 1/4] gnu: emacs-magit: Update to 2.90.1-1.c761d28 Oleg Pykhalov
2019-10-05 19:19   ` [bug#36999] [PATCH 2/4] gnu: emacs-ghub: Update to 3.2.0-1.cf0b13a Oleg Pykhalov
2019-10-05 19:19   ` [bug#36999] [PATCH 3/4] gnu: emacs-closql: Update to 1.0.0-1.70b98db Oleg Pykhalov
2019-10-05 19:19   ` [bug#36999] [PATCH 4/4] gnu: Add emacs-forge Oleg Pykhalov
2019-10-13 19:45 ` bug#36999: emacs-forge pushed to master Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAc=MEyGTJ5rc1v_0rTXacx6ViXk6RUy-qVgwmj6b_pLarj8ng@mail.gmail.com' \
    --to=bkleung89@gmail.com \
    --cc=36999@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).