From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56720) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i351z-0000HQ-6m for guix-patches@gnu.org; Wed, 28 Aug 2019 16:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i351x-0004AV-Ql for guix-patches@gnu.org; Wed, 28 Aug 2019 16:59:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i351x-0004AP-Ni for guix-patches@gnu.org; Wed, 28 Aug 2019 16:59:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i351x-0004Et-Ki for guix-patches@gnu.org; Wed, 28 Aug 2019 16:59:01 -0400 Subject: [bug#37138] [PATCH] gnu: Add speedcrunch. Resent-Message-ID: MIME-Version: 1.0 References: <87a7btgsh2.fsf@gnu.org> In-Reply-To: <87a7btgsh2.fsf@gnu.org> From: Steve Sprang Date: Wed, 28 Aug 2019 13:58:27 -0700 Message-ID: Content-Type: multipart/mixed; boundary="00000000000037043d059133a7b5" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 37138@debbugs.gnu.org --00000000000037043d059133a7b5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks for the feedback! Attached an updated patch. -Steve On Wed, Aug 28, 2019 at 9:33 AM Ludovic Court=C3=A8s wrote: > > Hello Steve, > > Steve Sprang skribis: > > > From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001 > > From: Steve Sprang > > Date: Wed, 21 Aug 2019 17:17:02 -0700 > > Subject: [PATCH] gnu: Add speedcrunch. > > > > * gnu/packages/maths.scm (speedcrunch): New variable. > > Nice. A couple of comments: > > > + (source (origin > > + (method url-fetch) > > + (uri (string-append "https://bitbucket.org/heldercorreia= /" > > + "speedcrunch/get/release-" version > > + ".tar.gz")) > > I suspect this /get URL returns a generated tarball, whose exact content > might change over time. If that is the case, could you instead use > =E2=80=98git-fetch=E2=80=99 (or =E2=80=98hg-fetch=E2=80=99)? > > > + (inputs `(("qt" ,qt))) > > Please use =E2=80=98qtbase=E2=80=99 & co., aka. the =E2=80=9Cmodular Qt p= ackages=E2=80=9D. The =E2=80=98qt=E2=80=99 > package is the old monolithic package and is actually deprecated. > > Could you send an updated patch? > > Thanks! > > Ludo=E2=80=99. --00000000000037043d059133a7b5 Content-Type: text/x-patch; charset="UTF-8"; name="0001-gnu-Add-speedcrunch.patch" Content-Disposition: attachment; filename="0001-gnu-Add-speedcrunch.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzvqqt020 RnJvbSA2NzI2ZmY1MWJkZTUyNDU5YzFiMjdiNDQ0MWMyZmQwNzBlNDg5MzY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGV2ZSBTcHJhbmcgPHNjc0BzdGV2ZXNwcmFuZy5jb20+CkRh dGU6IFdlZCwgMjEgQXVnIDIwMTkgMTc6MTc6MDIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBnbnU6 IEFkZCBzcGVlZGNydW5jaC4KCiogZ251L3BhY2thZ2VzL21hdGhzLnNjbSAoc3BlZWRjcnVuY2gp OiBOZXcgdmFyaWFibGUuCi0tLQogZ251L3BhY2thZ2VzL21hdGhzLnNjbSB8IDM0ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL21hdGhzLnNjbSBiL2dudS9wYWNrYWdlcy9t YXRocy5zY20KaW5kZXggNTdkZWIxNWQ3ZC4uMGYyYWNlY2UzYiAxMDA2NDQKLS0tIGEvZ251L3Bh Y2thZ2VzL21hdGhzLnNjbQorKysgYi9nbnUvcGFja2FnZXMvbWF0aHMuc2NtCkBAIC0zMSw2ICsz MSw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggSnVsaWVuIExlcGlsbGVyIDxqdWxpZW5AbGVw aWxsZXIuZXU+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTggQW1pbiBCYW5kYWxpIDxiYW5kYWxpQGdu dS5vcmc+CiA7OzsgQ29weXJpZ2h0IMKpIDIwMTkgTmljb2xhcyBHb2F6aW91IDxtYWlsQG5pY29s YXNnb2F6aW91LmZyPgorOzs7IENvcHlyaWdodCDCqSAyMDE5IFN0ZXZlIFNwcmFuZyA8c2NzQHN0 ZXZlc3ByYW5nLmNvbT4KIDs7OwogOzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBHdWl4Lgog Ozs7CkBAIC01MTM2LDMgKzUxMzcsMzYgQEAgYWxnb3JpdGhtLCBhIHBhcmFtZXRyaWMgaW50ZWdl ciBwcm9ncmFtbWluZyBzb2x2ZXIsIGFuZCBwcmltaXRpdmVzIGZvcgogdGVybWluYXRpb24gYW5h bHlzaXMgdmlhIHRoZSBhdXRvbWF0aWMgc3ludGhlc2lzIG9mIGxpbmVhciByYW5raW5nCiBmdW5j dGlvbnMuIikKICAgICAobGljZW5zZSBsaWNlbnNlOmdwbDMrKSkpCisKKyhkZWZpbmUtcHVibGlj IHNwZWVkY3J1bmNoCisgIChwYWNrYWdlCisgICAgKG5hbWUgInNwZWVkY3J1bmNoIikKKyAgICAo dmVyc2lvbiAiMC4xMi4wIikKKyAgICAoc291cmNlCisgICAgIChvcmlnaW4KKyAgICAgIChtZXRo b2QgZ2l0LWZldGNoKQorICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5jZQorICAgICAgICAodXJsICJo dHRwczovL2JpdGJ1Y2tldC5vcmcvaGVsZGVyY29ycmVpYS9zcGVlZGNydW5jaC5naXQiKQorICAg ICAgICAoY29tbWl0IChzdHJpbmctYXBwZW5kICJyZWxlYXNlLSIgdmVyc2lvbikpKSkKKyAgICAg IChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgIChzaGEyNTYK KyAgICAgICAoYmFzZTMyCisgICAgICAgICIwdmg3Y2QxOTE1YmpxemtkcDNzazI1bmd5OGNxNjI0 bWtoOGM1M2M1Ym56azM1N2tiMGZrIikpKSkKKyAgICAoYnVpbGQtc3lzdGVtIGNtYWtlLWJ1aWxk LXN5c3RlbSkKKyAgICAoaW5wdXRzIGAoKCJxdGJhc2UiICxxdGJhc2UpKSkKKyAgICAobmF0aXZl LWlucHV0cyBgKCgicXR0b29scyIgLHF0dG9vbHMpKSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAo IzpwaGFzZXMKKyAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAg ICAoYWRkLWFmdGVyICd1bnBhY2sgJ2NoZGlyLXRvLXNyYworICAgICAgICAgICAobGFtYmRhIF8g KGNoZGlyICJzcmMiKSAjdCkpKSkpCisgICAgKHN5bm9wc2lzICJIaWdoLXByZWNpc2lvbiBzY2ll bnRpZmljIGNhbGN1bGF0b3IiKQorICAgIChkZXNjcmlwdGlvbgorICAgICAiU3BlZWRDcnVuY2gg aXMgYSBoaWdoLXByZWNpc2lvbiBzY2llbnRpZmljIGNhbGN1bGF0b3IuICBJdCBmZWF0dXJlcyBh CitzeW50YXgtaGlnaGxpZ2h0ZWQgc2Nyb2xsYWJsZSBkaXNwbGF5IGFuZCBpcyBkZXNpZ25lZCB0 byBiZSBmdWxseSB1c2VkIHZpYQora2V5Ym9hcmQuICBTb21lIGRpc3RpbmN0aXZlIGZlYXR1cmVz IGFyZSBhdXRvLWNvbXBsZXRpb24gb2YgZnVuY3Rpb25zIGFuZAordmFyaWFibGVzLCBhIGZvcm11 bGEgYm9vaywgYW5kIHF1aWNrIGluc2VydGlvbiBvZiBjb25zdGFudHMgZnJvbSB2YXJpb3VzCitm aWVsZHMgb2Yga25vd2xlZGdlLiIpCisgICAgKGhvbWUtcGFnZSAiaHR0cDovL3NwZWVkY3J1bmNo Lm9yZy8iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6Z3BsMispKSkKKwotLSAKMi4yMy4wCgo= --00000000000037043d059133a7b5--