From: Steve Sprang <steve.sprang@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 37138@debbugs.gnu.org
Subject: [bug#37138] [PATCH] gnu: Add speedcrunch.
Date: Wed, 28 Aug 2019 13:58:27 -0700 [thread overview]
Message-ID: <CA+xn8YCGF6GiXwptAfrnQUfXioMGgsh=yvhBnBPcg15yQfK5Cw@mail.gmail.com> (raw)
In-Reply-To: <87a7btgsh2.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
Thanks for the feedback! Attached an updated patch.
-Steve
On Wed, Aug 28, 2019 at 9:33 AM Ludovic Courtès <ludo@gnu.org> wrote:
>
> Hello Steve,
>
> Steve Sprang <steve.sprang@gmail.com> skribis:
>
> > From a3dfe6c0fa6f5fddc3c47e7501e37ba11902eb80 Mon Sep 17 00:00:00 2001
> > From: Steve Sprang <scs@stevesprang.com>
> > Date: Wed, 21 Aug 2019 17:17:02 -0700
> > Subject: [PATCH] gnu: Add speedcrunch.
> >
> > * gnu/packages/maths.scm (speedcrunch): New variable.
>
> Nice. A couple of comments:
>
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "https://bitbucket.org/heldercorreia/"
> > + "speedcrunch/get/release-" version
> > + ".tar.gz"))
>
> I suspect this /get URL returns a generated tarball, whose exact content
> might change over time. If that is the case, could you instead use
> ‘git-fetch’ (or ‘hg-fetch’)?
>
> > + (inputs `(("qt" ,qt)))
>
> Please use ‘qtbase’ & co., aka. the “modular Qt packages”. The ‘qt’
> package is the old monolithic package and is actually deprecated.
>
> Could you send an updated patch?
>
> Thanks!
>
> Ludo’.
[-- Attachment #2: 0001-gnu-Add-speedcrunch.patch --]
[-- Type: text/x-patch, Size: 2219 bytes --]
From 6726ff51bde52459c1b27b4441c2fd070e489364 Mon Sep 17 00:00:00 2001
From: Steve Sprang <scs@stevesprang.com>
Date: Wed, 21 Aug 2019 17:17:02 -0700
Subject: [PATCH] gnu: Add speedcrunch.
* gnu/packages/maths.scm (speedcrunch): New variable.
---
gnu/packages/maths.scm | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 57deb15d7d..0f2acece3b 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -31,6 +31,7 @@
;;; Copyright © 2018 Julien Lepiller <julien@lepiller.eu>
;;; Copyright © 2018 Amin Bandali <bandali@gnu.org>
;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2019 Steve Sprang <scs@stevesprang.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -5136,3 +5137,36 @@ algorithm, a parametric integer programming solver, and primitives for
termination analysis via the automatic synthesis of linear ranking
functions.")
(license license:gpl3+)))
+
+(define-public speedcrunch
+ (package
+ (name "speedcrunch")
+ (version "0.12.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://bitbucket.org/heldercorreia/speedcrunch.git")
+ (commit (string-append "release-" version))))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0vh7cd1915bjqzkdp3sk25ngy8cq624mkh8c53c5bnzk357kb0fk"))))
+ (build-system cmake-build-system)
+ (inputs `(("qtbase" ,qtbase)))
+ (native-inputs `(("qttools" ,qttools)))
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'chdir-to-src
+ (lambda _ (chdir "src") #t)))))
+ (synopsis "High-precision scientific calculator")
+ (description
+ "SpeedCrunch is a high-precision scientific calculator. It features a
+syntax-highlighted scrollable display and is designed to be fully used via
+keyboard. Some distinctive features are auto-completion of functions and
+variables, a formula book, and quick insertion of constants from various
+fields of knowledge.")
+ (home-page "http://speedcrunch.org/")
+ (license license:gpl2+)))
+
--
2.23.0
next prev parent reply other threads:[~2019-08-28 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 0:25 [bug#37138] [PATCH] gnu: Add speedcrunch Steve Sprang
2019-08-28 16:33 ` Ludovic Courtès
2019-08-28 20:58 ` Steve Sprang [this message]
2019-08-31 18:58 ` bug#37138: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+xn8YCGF6GiXwptAfrnQUfXioMGgsh=yvhBnBPcg15yQfK5Cw@mail.gmail.com' \
--to=steve.sprang@gmail.com \
--cc=37138@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).