From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id sHvXOLEqIWfzGAEAe85BDQ:P1 (envelope-from ) for ; Tue, 29 Oct 2024 18:34:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id sHvXOLEqIWfzGAEAe85BDQ (envelope-from ) for ; Tue, 29 Oct 2024 19:34:26 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=VaKZcULS; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K7DcLrEh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730226864; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9f0NHDTrTDmwSVVjSmyLdcxUbsNhUcVBTPXbB7hkWkU=; b=V2lzqQHbZLEiGsLOlqt/XfHmaYlu9DLg67rORApBd+/D1t8bWcKsqd2hlwQk084Elsuhwn cDvyg1zL0I6WdsSlF57755514bT1sqc9Hjwl8uJ6z58H2Babv8zxWqhxjDjEqcBhL2Z3dM A2oNmD4A7vYqVttkJQpIo0UG7Gjeg2hGRAYz5eKi+wnyvxDtspeuujejihUWZeQlu1jmKa m3TPUF+mrdO5CyIyZFUrPCmBp2/lR/XtzNlvPOAjKGRgzMNrLG8g5TaskNrduDelZ52BRu 0L2FbwcyCul6lVSQE/3HSQiuUgZCS2wrAGrGUuB4l90466WJwZB/wkEgW0e3+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=VaKZcULS; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K7DcLrEh; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730226864; a=rsa-sha256; cv=none; b=HTkgvON7TWgolpBj8nuGTYekzqsfY3WUlUpEI7++8toAc5md8BFRWpTDlnojMQWOWY7X40 CTbXlYD7BBVAqxGJGO9nwDleH58WBNBEVejaPDXPU3emv12D9NducsPBvi71nAoIyV7XNx UtuDgYJxKQdjStKkTQVa0JlP7dhGb/U4SK/UklYVSW55EAZjy7wLHdGz+WRcgIkS9r02MV zsRCjhvyEls0dIAzl7XaBMRnDSAKWxxq8Y1TPlfwAZwxDaTaoh6vw/cqoQxjmqjLNowqZt 8sNC9LpxTXtNnUNfA8ivXpz0b9O2f0jL4aB6WfiwhrgV5GGhSHB07lAnmiWTfQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B4C6D8F409 for ; Tue, 29 Oct 2024 19:34:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5r2b-0001k2-27; Tue, 29 Oct 2024 14:34:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5r2Z-0001jo-EZ for guix-patches@gnu.org; Tue, 29 Oct 2024 14:34:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5r2Y-0006hY-Ph for guix-patches@gnu.org; Tue, 29 Oct 2024 14:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=9f0NHDTrTDmwSVVjSmyLdcxUbsNhUcVBTPXbB7hkWkU=; b=VaKZcULSPmmdZdmebnAUNU8qPDxQuzn8uu2g0SiBLuLwksr8V3vVyfn+rxnX+HHMpzx+h4/lMuBCsyLoGL1Q1ktDhUBk6U2afoGX98LRSLYJc1m7AJftl1cOS3yF5RB5yQEGzO9jMx3/U5YHX1OU6hKDcYYZ/d0nu3AmTAO+THxFhn7238YxEXY/0zBFANCHwB+s6x36nRZiCDSD7g2yf9fjM5TsXwZVDEL0itj7vO0JTC21h20uQ7GbIZF87nsHubkivCF4PaLO/lkOYID2QoA0/DEXdoKAy1xPdWyUK30X7MztD2cbK7ZF7VbE8EcTcZMsQxaV11QPb8xoZ9uQWQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5r2Y-0005ua-G8 for guix-patches@gnu.org; Tue, 29 Oct 2024 14:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74092] [PATCH] fix gnutls package Resent-From: Adam Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Oct 2024 18:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74092 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tomas Volf <~@wolfsden.cz> Cc: 74092@debbugs.gnu.org Received: via spool by 74092-submit@debbugs.gnu.org id=B74092.173022681022712 (code B ref 74092); Tue, 29 Oct 2024 18:34:02 +0000 Received: (at 74092) by debbugs.gnu.org; 29 Oct 2024 18:33:30 +0000 Received: from localhost ([127.0.0.1]:57996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5r21-0005uG-Go for submit@debbugs.gnu.org; Tue, 29 Oct 2024 14:33:30 -0400 Received: from [209.85.215.171] (port=38021 helo=mail-pg1-f171.google.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5r1x-0005u4-JG for 74092@debbugs.gnu.org; Tue, 29 Oct 2024 14:33:28 -0400 Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7eb068dbf51so782608a12.0 for <74092@debbugs.gnu.org>; Tue, 29 Oct 2024 11:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730226729; x=1730831529; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9f0NHDTrTDmwSVVjSmyLdcxUbsNhUcVBTPXbB7hkWkU=; b=K7DcLrEhoB+5gSagRlyFMyfG7jESCGWddvjb4FslUAwKHymOtFlX2Ddg+fWtIo70IS 2cidYrx2y2X1/to5s1rAOK4o7PH8TRQ9T5uzU/oOKuyopDCfrZ8oOhDutLFFS/+aB4Is o5q3iIaZ8Jd0Q06sX0RDjvDRivlSeAwAVyHOrKLDp+GMR3TDTqUVsPF2SUfnqk9kW3vc J+g1Y4jVSL0+SjxnuLxDXkyYi5swzvbozCrV4pEFb6lOojzNv6AEgwlAYehUAovdieTJ TEFBWUihYRaLONlRLi7dOIP+M2FNVSqk4uZfhp1Oj4aHZ6KCDBEeRJtGEEOFusHng+Yc Os4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730226729; x=1730831529; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9f0NHDTrTDmwSVVjSmyLdcxUbsNhUcVBTPXbB7hkWkU=; b=nV/fqUEAKlTlG/KWPEaRx9jmxur2NI1vgB07HFCsjSyl8ZFWv9GYmHXf6ekfrY0AVn S/lMA/ZeaLklRty1sN/as7BDWZxwWjOaQn/j+E44WFZmaT5vNlyAow0RYiAdlORRqQZV vkfV2QRztHHMz+CgKoWJpfMI69lV5aTonezZONgv72m2b213+5Z5GNH8H9J7fJlwxYvs IGH7dzwMGFG9MVUHNw2P++hSJEHYmbB0xlHir0b7eLlRRDHeWg7aS4X7RVbFoK3rSrrx wksCCtMadb/EqLSuvN6+mg+LOgQDZAxh3st/sALe0lOL3bIU986UOVikJSjuRMwfDPJ+ E0RA== X-Gm-Message-State: AOJu0YwemJZCSqGRjXV4tivl+P3h/v9CodkYRtIE/SHa16sOwc2RfI2J FAUzuoLMlkqj00zaxWkMuaMtUsGN5/+6kASRLad4Ohy66w7e8ky/jcWlm5NWZhUdvZ2AFccKhLo DIk2WB3qsJwcYpMbLV71VkYnreYZCUA== X-Google-Smtp-Source: AGHT+IHgEiDJWwBkgqCY/sDoAX1ezlTR3n6+WolEn9lW4Lp79iIYrmjX9BDqvsu0c6ZTDcIcN1y4B8TdRyLvI1rhWhw= X-Received: by 2002:a05:6a00:3e26:b0:71e:459d:1fa3 with SMTP id d2e1a72fcca58-72063004c4amr7826232b3a.4.1730226729186; Tue, 29 Oct 2024 11:32:09 -0700 (PDT) MIME-Version: 1.0 References: <20241029173313.11755-1-adam.quandour@gmail.com> <87r07yiydx.fsf@wolfsden.cz> In-Reply-To: <87r07yiydx.fsf@wolfsden.cz> From: Adam Date: Tue, 29 Oct 2024 21:31:58 +0300 Message-ID: Content-Type: multipart/alternative; boundary="0000000000009304610625a1cddd" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 3.38 X-Spam-Score: 3.38 X-Migadu-Queue-Id: B4C6D8F409 X-TUID: mtJXtObRvBgy --0000000000009304610625a1cddd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The main reason I wrote the patch - I cannot build gnutls@3.8.3 from source code. This command ``` guix build gnutls@3.8.3 --no-substitutes ``` returns me this ``` expected hash: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp actual hash: 0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa hash mismatch for store item '/gnu/store/9zh4mcmwp2afyl4ig56943w64czdz2kp-gnutls-3.8.3.tar.xz' ``` Guix I'm using ``` guix: repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: 4009d1de954d694cb11af391d4113d29c5c1379d ``` Am I getting it right - you are suggesting I replace "mirror://gnupg/gnutls/v" with "https://gnutls.org/" or "ftp://gnutls.org" ? I'm asking because I'm not the original author of this package, so it's not obvious to me, what will be the right decision here? On Tue, Oct 29, 2024 at 8:59=E2=80=AFPM Tomas Volf <~@wolfsden.cz> wrote: > > Adam Quandour writes: > > > Actual hash of this package is not the same as the specified one. > > --- > > gnu/packages/tls.scm | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm > > index 1a1ce0d..4f862ff 100644 > > --- a/gnu/packages/tls.scm > > +++ b/gnu/packages/tls.scm > > @@ -212,7 +212,7 @@ (define-public gnutls > > (patches (search-patches "gnutls-skip-trust-store-test.patch")) > > (sha256 > > (base32 > > - "0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp")))) > > + "0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa")))) > > When I download the release from the official website[0], via the gnupg > ftp[1], I do get the file with the old hash[2]. > > I am not sure what is going on here, but the discrepancy should be > investigated and documented in the commit message. Just adjusting the > hash is probably not the best choice. > > I would assume the upstream[0] should be the authoritative source for > the hash, not the mirror. > > 0: https://gnutls.org/download.html > 1: https://www.gnupg.org/ftp/gcrypt/gnutls/v3.8/ > 2: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp > > > (build-system gnu-build-system) > > (arguments > > (list #:tests? (not (or (%current-target-system) > > Have a nice day, > Tomas > > -- > There are only two hard things in Computer Science: > cache invalidation, naming things and off-by-one errors. --0000000000009304610625a1cddd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The main reason I wrote the patch - I cannot build gn= utls@3.8.3 from source code.
This command
```
guix build gnutls@3.8.3 --no-substitutes
```
retur= ns me this
```
=C2=A0 expected hash: 0ghpyhhfa3nsraph6d= ws50jb3dc8g2cfl7dizdnyrm179fawakzp
=C2=A0 actual hash: =C2=A0 0kayjxy3rr= 2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa
hash mismatch for store item = '/gnu/store/9zh4mcmwp2afyl4ig56943w64czdz2kp-gnutls-3.8.3.tar.xz'```
Guix I'm using
```
=C2=A0 =C2=A0 guix:
=C2=A0 = =C2=A0 =C2=A0 repository URL: https://git.savannah.gnu.org/git/guix.git
=C2=A0 =C2=A0 =C2= =A0 branch: master
=C2=A0 =C2=A0 =C2=A0 commit: 4009d1de954d694cb11af391= d4113d29c5c1379d
```
Am I getting it right - you are suggesting I rep= lace=C2=A0"mirror://gnupg/gnutls/v" with=C2=A0
"https://gnutls.org/" or "ftp://gnutls.org" ?
I'm asking becau= se I'm not the original author of this package, so it's not obvious= to me,
what will be the right decision here?

On Tue, Oct = 29, 2024 at 8:59=E2=80=AFPM Tomas Volf <~@wolfsden.cz> wrote:
>
> Adam Quandour <adam.quandour@gmail.com> writes:
&g= t;
> > Actual hash of this package is not the same as the specifie= d one.
> > ---
> > =C2=A0gnu/packages/tls.scm | 2 +-
&= gt; > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >> > diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
>= ; > index 1a1ce0d..4f862ff 100644
> > --- a/gnu/packages/tls.sc= m
> > +++ b/gnu/packages/tls.scm
> > @@ -212,7 +212,7 @@ = (define-public gnutls
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0(patches (search-patches "gnutls-skip-trust-store-tes= t.patch"))
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(sha256
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 (base32
> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0"0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm179fawakzp= "))))
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0"0kayjxy3rr2y08jjimz5f0dx92pq3xjiaj2pdnsn15h1rp2k21pa"))))<= br>>
> When I download the release from the official website[0], v= ia the gnupg
> ftp[1], I do get the file with the old hash[2].
>= ;
> I am not sure what is going on here, but the discrepancy should b= e
> investigated and documented in the commit message.=C2=A0 Just adj= usting the
> hash is probably not the best choice.
>
> I = would assume the upstream[0] should be the authoritative source for
>= the hash, not the mirror.
>
> 0: https://gnutls.org/download.html
> 1: https://www.gnupg.org/ftp/gc= rypt/gnutls/v3.8/
> 2: 0ghpyhhfa3nsraph6dws50jb3dc8g2cfl7dizdnyrm= 179fawakzp
>
> > =C2=A0 =C2=A0 =C2=A0(build-system gnu-build= -system)
> > =C2=A0 =C2=A0 =C2=A0(arguments
> > =C2=A0 = =C2=A0 =C2=A0 (list #:tests? (not (or (%current-target-system)
>
&= gt; Have a nice day,
> Tomas
>
> --
> There are onl= y two hard things in Computer Science:
> cache invalidation, naming t= hings and off-by-one errors.
--0000000000009304610625a1cddd--