From: Adam <adam.quandour@gmail.com>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 71184@debbugs.gnu.org
Subject: [bug#71184] [PATCH] gnu: Add ruby-appraisal.
Date: Tue, 2 Jul 2024 15:58:43 +0300 [thread overview]
Message-ID: <CA+jnL0NPQqQgfRy3z5zAyHt2Gej4hm8tWDu+VJ1obMhCyh_cMg@mail.gmail.com> (raw)
In-Reply-To: <87ed8ejg9x.fsf@ngraves.fr>
Hi,
Yeah, I will prepare new patches.
On Mon, Jul 1, 2024 at 12:02 AM Nicolas Graves <ngraves@ngraves.fr> wrote:
>
>
> Hi,
>
> I notice two different packages, can you split the commit please?
>
> Also notice the lint warning on https://qa.guix.gnu.org/issue/71184 :
>
> gnu/packages/ruby.scm:1530:0: ruby-appraisal@2.5.0: line 1530 is way too long (99 characters)
> gnu/packages/ruby.scm:1530:14: ruby-appraisal@2.5.0: no article allowed at the beginning of the synopsis
> gnu/packages/ruby.scm:1530:14: ruby-appraisal@2.5.0: synopsis should be
> less than 80 characters long
>
> Otherwise: built reproducibly, package definitions themselves LGTM.
>
> --
> Best regards,
> Nicolas Graves
next prev parent reply other threads:[~2024-07-02 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 21:38 [bug#71184] [PATCH] gnu: Add ruby-appraisal Adam Quandour
2024-06-30 21:02 ` Nicolas Graves via Guix-patches via
2024-07-02 12:58 ` Adam [this message]
2024-07-02 13:35 ` [bug#71184] [PATCH 1/2] gnu: Add ruby-thor-0.14.6 Adam Quandour
2024-07-02 13:35 ` [bug#71184] [PATCH 2/2] gnu: Add ruby-appraisal Adam Quandour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+jnL0NPQqQgfRy3z5zAyHt2Gej4hm8tWDu+VJ1obMhCyh_cMg@mail.gmail.com \
--to=adam.quandour@gmail.com \
--cc=71184@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).