[bug#33217] Modifying the commit message to gnu-Add-r-weights

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Lakshmi Prasannakumar]

[-- Attachment #1.1: Type: text/plain, Size: 449 bytes --]

Hi,

Adding line breakers to the patch file. Please find the patch file attached
to this mail.

Thanks and Regards,
Lakshmi Prasannakumar
Bangalore


On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
lakshmiprasannakumaran@gmail.com> wrote:

> Hi,
> Please find the attached patch file with this mail.
> The changes made are to the cran.scm
> * gnu/packages/cran.scm (r-weights): New variable.
>
> Thanks,
> Lakshmi Prasannakumar
> Bangalore
>

[-- Attachment #1.2: Type: text/html, Size: 2411 bytes --]

[-- Attachment #2: 0001-gnu-Add-r-weights.patch --]
[-- Type: text/x-patch, Size: 1804 bytes --]

From 74abc72a7e22a03714d1ead77768536e651d54f3 Mon Sep 17 00:00:00 2001
From: lakshmi <lakshmiprasannakumaran@gmail.com>
Date: Wed, 31 Oct 2018 09:57:31 +0530
Subject: [PATCH] gnu: Add r-weights 

gnu/packages/cran.scm (r-weights): New variable
 

---
 gnu/packages/cran.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 7f2123b..fc95aaa 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -6693,3 +6693,27 @@ component analysis and correlation matrices, cluster analyses, scatter plots,
 stacked scales, effects plots of regression models (including interaction
 terms) and much more.  This package supports labelled data.")
     (license license:gpl3)))
+
+(define-public r-weights
+(package
+  (name "r-weights")
+  (version "1.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (cran-uri "weights" version))
+      (sha256
+        (base32
+          "0186bfpkhxngrshac6bpg37alp6slwhwd43inrm8hqg0vhpfgc4c"))))
+  (build-system r-build-system)
+  (propagated-inputs
+    `(("r-gdata" ,r-gdata)
+      ("r-hmisc" ,r-hmisc)
+      ("r-mice" ,r-mice)))
+  (home-page
+    "http://cran.r-project.org/web/packages/weights")
+  (synopsis "Weighting and weighted statistics")
+  (description
+    "This package provides a variety of functions for producing simple weighted statistics, such as weighted Pearson's correlations, partial correlations, Chi-Squared statistics, histograms, and t-tests. It also includes some softwares used for quickly recoding survey data and plotting point estimates from interaction terms in regressions which can be then multiplied with imputed regressions. Weighted partial correlation calculations are pulled to address a bug.")
+  (license gpl2+)))
+
-- 
2.9.3

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Lakshmi Prasannakumar]

[-- Attachment #1.1: Type: text/plain, Size: 716 bytes --]

Hi,

Pushing the cran.scm file to the latest branch.
Please find the attached file.

Thanks & Regards,
Lakshmi Prasannakumar
Bangalore


On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <
lakshmiprasannakumaran@gmail.com> wrote:

> Hi,
>
> Adding line breakers to the patch file. Please find the patch file
> attached to this mail.
>
> Thanks and Regards,
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> wrote:
>
>> Hi,
>> Please find the attached patch file with this mail.
>> The changes made are to the cran.scm
>> * gnu/packages/cran.scm (r-weights): New variable.
>>
>> Thanks,
>> Lakshmi Prasannakumar
>> Bangalore
>>
>

[-- Attachment #1.2: Type: text/html, Size: 4083 bytes --]

[-- Attachment #2: 0003-gnu-r-weights.-Add-r-weights.patch --]
[-- Type: text/x-patch, Size: 1731 bytes --]

From cb51b4f5199280e8af256fac12d32903d52857a3 Mon Sep 17 00:00:00 2001
From: lakshmi <lakshmiprasannakumaran@gmail.com>
Date: Sun, 4 Nov 2018 21:52:11 +0530
Subject: [PATCH 3/3] gnu:r-weights.:Add r-weights.

* gnu/packages/cran.scm (r-weight): New variable.

---
 gnu/packages/cran.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 28d0083..03969ca 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -7251,3 +7251,26 @@ using @dfn{penalized quasi-likelihood} (PQL) estimation (see Jaeger et
 al. (2016)).")
     (license license:gpl2)))
 >>>>>>> 30012b74088dccbb602e3592c61a5718fc5e5524
+
+(define-public r-weights
+  (package
+  (name "r-weights")
+  (version "1.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (cran-uri "weights" version))
+      (sha256
+        (base32
+          "0186bfpkhxngrshac6bpg37alp6slwhwd43inrm8hqg0vhpfgc4c"))))
+  (build-system r-build-system)
+  (propagated-inputs
+    `(("r-gdata" ,r-gdata)
+      ("r-hmisc" ,r-hmisc)
+      ("r-mice" ,r-mice)))
+  (home-page
+    "http://cran.r-project.org/web/packages/weights")
+  (synopsis "Weighting and Weighted Statistics")
+  (description
+    "Provides a variety of functions for producing simple weighted statistics, such as weighted Pearson's correlations, partial correlations, Chi-Squared statistics, histograms, and t-tests. This package also now includes some software for quickly recoding survey data and plotting point estimates from interaction terms in regressions (and multiply imputed regressions). It must be noted that Weighted partial correlation calculations pulled to address a bug.")
+  (license gpl2+)))
-- 
2.9.3

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Gábor Boskovits]

Hello,

Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
(időpont: 2018. nov. 4., V, 17:27):
>
> Hi,
>
> Pushing the cran.scm file to the latest branch.
> Please find the attached file.
>

I got it, will have a look later.

> Thanks & Regards,
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>>
>> Hi,
>>
>> Adding line breakers to the patch file. Please find the patch file attached to this mail.
>>
>> Thanks and Regards,
>> Lakshmi Prasannakumar
>> Bangalore
>>
>>
>> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>>>
>>> Hi,
>>> Please find the attached patch file with this mail.
>>> The changes made are to the cran.scm
>>> * gnu/packages/cran.scm (r-weights): New variable.
>>>
>>> Thanks,
>>> Lakshmi Prasannakumar
>>> Bangalore

Best regards,
g_bor

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Gábor Boskovits]

Hello Lakshmi,

There was a patch eariler in a better shape, this seems to be missing some
corrections you made earlier. Is that possible?

I intend to push a fixed version of the best patch we had so far
tomorrow, unless
I get a new version from you. WDYT?

Best regards,
g_bor
Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. nov.
4., V, 18:05):
>
> Hello,
>
> Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
> (időpont: 2018. nov. 4., V, 17:27):
> >
> > Hi,
> >
> > Pushing the cran.scm file to the latest branch.
> > Please find the attached file.
> >
>
> I got it, will have a look later.
>
> > Thanks & Regards,
> > Lakshmi Prasannakumar
> > Bangalore
> >
> >
> > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
> >>
> >> Hi,
> >>
> >> Adding line breakers to the patch file. Please find the patch file attached to this mail.
> >>
> >> Thanks and Regards,
> >> Lakshmi Prasannakumar
> >> Bangalore
> >>
> >>
> >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
> >>>
> >>> Hi,
> >>> Please find the attached patch file with this mail.
> >>> The changes made are to the cran.scm
> >>> * gnu/packages/cran.scm (r-weights): New variable.
> >>>
> >>> Thanks,
> >>> Lakshmi Prasannakumar
> >>> Bangalore
>
> Best regards,
> g_bor

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Lakshmi Prasannakumar]

[-- Attachment #1.1: Type: text/plain, Size: 2434 bytes --]

Hi Gábor,

As I pulled the latest updated version of cran.scm from git branch and
added the package definition to it, I missed to make the changes for
synopsis case. And the description went little off.
Comparing to the bug tracker, I followed the message lines and tried to
give a new message with the commit thinking it would resolve my build
issues, but I guess the format I followed was wrong again.
So, I have made the changes in cran.scm including all the corrections we
had done before and the commit message is made as the earlier version.
Sending in the updated patch file with this mail.
Kindly take a moment to review the same.

And as suggested, I have reworked on the timelines  where the videos can be
distributed.


Thanks and Regards,


Lakshmi Prasannakumar
Bangalore


On Mon, Nov 5, 2018 at 2:42 AM Gábor Boskovits <boskovits@gmail.com> wrote:

> Hello Lakshmi,
>
> There was a patch eariler in a better shape, this seems to be missing some
> corrections you made earlier. Is that possible?
>
> I intend to push a fixed version of the best patch we had so far
> tomorrow, unless
> I get a new version from you. WDYT?
>
> Best regards,
> g_bor
> Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. nov.
> 4., V, 18:05):
> >
> > Hello,
> >
> > Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
> > (időpont: 2018. nov. 4., V, 17:27):
> > >
> > > Hi,
> > >
> > > Pushing the cran.scm file to the latest branch.
> > > Please find the attached file.
> > >
> >
> > I got it, will have a look later.
> >
> > > Thanks & Regards,
> > > Lakshmi Prasannakumar
> > > Bangalore
> > >
> > >
> > > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> wrote:
> > >>
> > >> Hi,
> > >>
> > >> Adding line breakers to the patch file. Please find the patch file
> attached to this mail.
> > >>
> > >> Thanks and Regards,
> > >> Lakshmi Prasannakumar
> > >> Bangalore
> > >>
> > >>
> > >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> wrote:
> > >>>
> > >>> Hi,
> > >>> Please find the attached patch file with this mail.
> > >>> The changes made are to the cran.scm
> > >>> * gnu/packages/cran.scm (r-weights): New variable.
> > >>>
> > >>> Thanks,
> > >>> Lakshmi Prasannakumar
> > >>> Bangalore
> >
> > Best regards,
> > g_bor
>

[-- Attachment #1.2: Type: text/html, Size: 4928 bytes --]

[-- Attachment #2: 0001-gnu-Add-r-weights.patch --]
[-- Type: application/x-patch, Size: 1656 bytes --]

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Gábor Boskovits]

Thanks, I'll take a look.
Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
(időpont: 2018. nov. 5., H, 21:41):
>
> Hi Gábor,
>
> As I pulled the latest updated version of cran.scm from git branch and added the package definition to it, I missed to make the changes for synopsis case. And the description went little off.
> Comparing to the bug tracker, I followed the message lines and tried to give a new message with the commit thinking it would resolve my build issues, but I guess the format I followed was wrong again.
> So, I have made the changes in cran.scm including all the corrections we had done before and the commit message is made as the earlier version.
> Sending in the updated patch file with this mail.
> Kindly take a moment to review the same.
>
> And as suggested, I have reworked on the timelines  where the videos can be distributed.
>
>
> Thanks and Regards,
>
>
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Mon, Nov 5, 2018 at 2:42 AM Gábor Boskovits <boskovits@gmail.com> wrote:
>>
>> Hello Lakshmi,
>>
>> There was a patch eariler in a better shape, this seems to be missing some
>> corrections you made earlier. Is that possible?
>>
>> I intend to push a fixed version of the best patch we had so far
>> tomorrow, unless
>> I get a new version from you. WDYT?
>>
>> Best regards,
>> g_bor
>> Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. nov.
>> 4., V, 18:05):
>> >
>> > Hello,
>> >
>> > Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
>> > (időpont: 2018. nov. 4., V, 17:27):
>> > >
>> > > Hi,
>> > >
>> > > Pushing the cran.scm file to the latest branch.
>> > > Please find the attached file.
>> > >
>> >
>> > I got it, will have a look later.
>> >
>> > > Thanks & Regards,
>> > > Lakshmi Prasannakumar
>> > > Bangalore
>> > >
>> > >
>> > > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>> > >>
>> > >> Hi,
>> > >>
>> > >> Adding line breakers to the patch file. Please find the patch file attached to this mail.
>> > >>
>> > >> Thanks and Regards,
>> > >> Lakshmi Prasannakumar
>> > >> Bangalore
>> > >>
>> > >>
>> > >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>> > >>>
>> > >>> Hi,
>> > >>> Please find the attached patch file with this mail.
>> > >>> The changes made are to the cran.scm
>> > >>> * gnu/packages/cran.scm (r-weights): New variable.
>> > >>>
>> > >>> Thanks,
>> > >>> Lakshmi Prasannakumar
>> > >>> Bangalore
>> >
>> > Best regards,
>> > g_bor

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Gábor Boskovits]

Hello Lakshmi,

It would be nice if you could give this another shot, if not I will
commit it tomorrow with
some minor changes.

The commit message seems to be missing the second line (what has changed).

The license field still misses the prefix. See the mail from Björn earlier.

Could you squash your changes to a single commit?

(You can either do this on a throw-away branch with a git merge --squash, or
you can use git rebase -i, see this for more info
https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history.)

Best regards,
g_bor

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Lakshmi Prasannakumar]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

Hi Gábor,

I am extremely sorry that , I did miss out this mail. I would like to know
, if there is anything more that I need to do on r-weights package
addition.
If not could you tell me how you fixed this to do the final commit ?

Thanks,

On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:

> Hello Lakshmi,
>
> It would be nice if you could give this another shot, if not I will
> commit it tomorrow with
> some minor changes.
>
> The commit message seems to be missing the second line (what has changed).
>
> The license field still misses the prefix. See the mail from Björn earlier.
>
> Could you squash your changes to a single commit?
>
> (You can either do this on a throw-away branch with a git merge --squash,
> or
> you can use git rebase -i, see this for more info
>
> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
> .)
>
> Best regards,
> g_bor
>

[-- Attachment #2: Type: text/html, Size: 2018 bytes --]

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

I used the version where the most things were fixed, applied it to the
commit in Björn's message, created a branch, rebased on current master,
then fixed the commit message using amend, signed off and pushed. There is
no additional thing to do.

2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
lakshmiprasannakumaran@gmail.com> ezt írta:

> Hi Gábor,
>
> I am extremely sorry that , I did miss out this mail. I would like to know
> , if there is anything more that I need to do on r-weights package
> addition.
> If not could you tell me how you fixed this to do the final commit ?
>
> Thanks,
>
> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:
>
>> Hello Lakshmi,
>>
>> It would be nice if you could give this another shot, if not I will
>> commit it tomorrow with
>> some minor changes.
>>
>> The commit message seems to be missing the second line (what has changed).
>>
>> The license field still misses the prefix. See the mail from Björn
>> earlier.
>>
>> Could you squash your changes to a single commit?
>>
>> (You can either do this on a throw-away branch with a git merge --squash,
>> or
>> you can use git rebase -i, see this for more info
>>
>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>> .)
>>
>> Best regards,
>> g_bor
>>
>

[-- Attachment #2: Type: text/html, Size: 2663 bytes --]

[bug#33217] Modifying the commit message to gnu-Add-r-weights

[Lakshmi Prasannakumar]

[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]

Thank You Gábor,

I was planning to look for dependencies to work on adding anaconda as a
package. Just got my system upgraded and will get back to you with a
roadmap to proceed with.
Or do you think I need to start working on something else?

Regards,
Lakshmi Prasannakumar
Bangalore


On Fri, Nov 9, 2018 at 1:05 AM Gábor Boskovits <boskovits@gmail.com> wrote:

> I used the version where the most things were fixed, applied it to the
> commit in Björn's message, created a branch, rebased on current master,
> then fixed the commit message using amend, signed off and pushed. There is
> no additional thing to do.
>
> 2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> ezt írta:
>
>> Hi Gábor,
>>
>> I am extremely sorry that , I did miss out this mail. I would like to
>> know , if there is anything more that I need to do on r-weights package
>> addition.
>> If not could you tell me how you fixed this to do the final commit ?
>>
>> Thanks,
>>
>> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:
>>
>>> Hello Lakshmi,
>>>
>>> It would be nice if you could give this another shot, if not I will
>>> commit it tomorrow with
>>> some minor changes.
>>>
>>> The commit message seems to be missing the second line (what has
>>> changed).
>>>
>>> The license field still misses the prefix. See the mail from Björn
>>> earlier.
>>>
>>> Could you squash your changes to a single commit?
>>>
>>> (You can either do this on a throw-away branch with a git merge
>>> --squash, or
>>> you can use git rebase -i, see this for more info
>>>
>>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>>> .)
>>>
>>> Best regards,
>>> g_bor
>>>
>>

[-- Attachment #2: Type: text/html, Size: 4404 bytes --]