unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Greg Hogan <code@greghogan.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: ludo@gnu.org, 55976@debbugs.gnu.org
Subject: [bug#55976] [PATCH] gnu: valgrind/interactive: Update to 3.19.0.
Date: Wed, 15 Jun 2022 09:55:01 -0400	[thread overview]
Message-ID: <CA+3U0ZnDLEiXBT+6c06KEcENcXU5s5WVLgmDpv5ftzZnu0Ztug@mail.gmail.com> (raw)
In-Reply-To: <87v8t3vsra@nckx>

On Tue, Jun 14, 2022 at 5:29 PM Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>
> Hi Greg,
>
> Greg Hogan 写道:
> > * gnu/packages/valgrind.scm (valgrind/interactive): Update to
> > 3.19.0.
> > [home-page]: Update permanent redirect.
> > * gnu/packages/valgrind.scm (valgrind-3.18): Delete.
> > ---
> > This patch bumps the version of the non-hidden valgrind while
> > removing
> > the pinned-version package.
>
> Unless I'm mistaken these 2 tasks are independent, and should
> hence be split across 2 patches.

I will split the commit and send a v2 patchset upon confirmation of
the valgrind-3.18 removal..

> >                             Looking through the commit history,
> >                             I do see
> > a reason for having both a valgrind/interactive and
> > valgrind-3.18.
>
> I thought this was a typo for ‘don't’ at first, but I really can't
> tell.

You are correct, this should have said "don't see a reason".

> I don't see a reason to keep both now, but then I don't see one
> when 50f7402c was committed either.  Do you remember, Ludo'?
>
> Kind regards,
>
> T G-R

Thanks for the review!

Greg




  reply	other threads:[~2022-06-15 13:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 15:38 [bug#55976] [PATCH] gnu: valgrind/interactive: Update to 3.19.0 Greg Hogan
2022-06-14 21:19 ` Tobias Geerinckx-Rice via Guix-patches via
2022-06-15 13:55   ` Greg Hogan [this message]
2022-11-07 18:36     ` bug#55976: " Greg Hogan
2022-07-07 14:24 ` [bug#55976] [PATCH v2 0/2] Update valgrind Greg Hogan
2022-07-07 14:24   ` [bug#55976] [PATCH v2 1/2] gnu: valgrind/interactive: Update to 3.19.0 Greg Hogan
2022-07-07 14:24   ` [bug#55976] [PATCH v2 2/2] gnu: valgrind-3.18: Delete Greg Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+3U0ZnDLEiXBT+6c06KEcENcXU5s5WVLgmDpv5ftzZnu0Ztug@mail.gmail.com \
    --to=code@greghogan.com \
    --cc=55976@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).