From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GGFbMCjngV9ZMAAA0tVLHw (envelope-from ) for ; Sat, 10 Oct 2020 16:54:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id aJkiLCjngV9uOwAA1q6Kng (envelope-from ) for ; Sat, 10 Oct 2020 16:54:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24D029408E2 for ; Sat, 10 Oct 2020 16:54:00 +0000 (UTC) Received: from localhost ([::1]:51778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRI85-0004Io-PN for larch@yhetil.org; Sat, 10 Oct 2020 12:53:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRI5G-0002m2-7Y for guix-patches@gnu.org; Sat, 10 Oct 2020 12:51:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55108) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kRI5F-0000Ko-UY for guix-patches@gnu.org; Sat, 10 Oct 2020 12:51:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kRI5F-0002y1-RG for guix-patches@gnu.org; Sat, 10 Oct 2020 12:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43620] [PATCH 2/2] gnu: Add folly. Resent-From: Greg Hogan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Oct 2020 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43620 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 43620@debbugs.gnu.org Received: via spool by 43620-submit@debbugs.gnu.org id=B43620.160234864211376 (code B ref 43620); Sat, 10 Oct 2020 16:51:01 +0000 Received: (at 43620) by debbugs.gnu.org; 10 Oct 2020 16:50:42 +0000 Received: from localhost ([127.0.0.1]:38421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRI4s-0002xM-6G for submit@debbugs.gnu.org; Sat, 10 Oct 2020 12:50:42 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:33543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRI4m-0002x2-Nm for 43620@debbugs.gnu.org; Sat, 10 Oct 2020 12:50:37 -0400 Received: by mail-wr1-f66.google.com with SMTP id b8so392112wrn.0 for <43620@debbugs.gnu.org>; Sat, 10 Oct 2020 09:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greghogan-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HXKhOaWA0zfgpMns0GZ6F4eI5qP8ROy4e7/v8T6dmDw=; b=k4Sw5KqI7LM32LB5kRT9F2qhe20HEyJ0M6oEhVJYd/jCIRP8Y4H9frMl8Ps8RUDy2Y QwM7/AGioCz9W5a9Fv+zvQq1xjQzf/ipPm8og5drSzG9M+l1MGdqcMUdznlYjpQIji9z rcN1HhctZZm5rmoS9L7zGwdZjysq+lq/i+zQtxNraQo35ZQPchZkgmgRqZ9RWm6v3qdM nkM9eJ3j9vFXWJU6YvV7OfW+LFN35cBzC2lcdROAhizTGqnKe8EjIdcTNGLArSukrP6m PuxXz9FH64/3liKZVATGFr8E2cNCLIdWyjfwW1Kg0KuEJAd0JasQaq0BxeU+FhTlks5a kGLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HXKhOaWA0zfgpMns0GZ6F4eI5qP8ROy4e7/v8T6dmDw=; b=I/ss623owE+1eZ+wCm6of5jBBWd4Xtt+PGx1J3Xyt36mHsQniwlw7y/NmJhZCcBcyq f8Msffs3xLd0bzSKrpJAmnBGnfw4ZfRgAxcSA6kWsYjM50AieWFB6fwy9HyvsJx79Xhv m61hi06QdIc1iPNv0laHdiIh7vc7KK5vwD61q0jebXWaWXpxa4cEmKLb/AWy0fAkDIYS lMvFny61o++7Gsd0+N1hz2CNfILhc9j47Q9UPiZ8hKV1B24wAw1NPMIOCPM8D3DyD3XU Ed2mP76ENU+kWPgIs3AWxUEnZBJBZJNAuaxnUepRmLW0RkqNfxyccwhchLYBpkd81N3H jvfg== X-Gm-Message-State: AOAM531+KaX51BmOs4B6zp3G6r7WNn6xaSqgr87o7TVksAwM/HmklA1E D4QNRzgPbBnz3Ams1MgzJ/+J7Rd3z4YMu86pjrZPY3HRWh/BF/Cw X-Google-Smtp-Source: ABdhPJyuPAqvzBHZliEVs71Q2QANJ+vDFbWGCmvDI7yJgxJTgJbyBm2Prjp0U25Xn/xkE6mS843Wvd2/GfJikQVHWY0= X-Received: by 2002:a5d:5449:: with SMTP id w9mr22023587wrv.182.1602348626636; Sat, 10 Oct 2020 09:50:26 -0700 (PDT) MIME-Version: 1.0 References: <87r1qk48gv.fsf@gnu.org> In-Reply-To: <87r1qk48gv.fsf@gnu.org> From: Greg Hogan Date: Sat, 10 Oct 2020 12:50:15 -0400 Message-ID: Content-Type: multipart/alternative; boundary="000000000000b28d7505b153dc2e" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=greghogan-com.20150623.gappssmtp.com header.s=20150623 header.b=k4Sw5KqI; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 2.49 X-TUID: d1ovm8s4lbDS --000000000000b28d7505b153dc2e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This patch depends on #43619 Reworded synopsis and description. Updated to newest version. Limited to 64-bit architectures. >From 8e3df10ad8aa791e34a5a5abcaabe0438f7b063a Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Tue, 22 Sep 2020 15:22:32 +0000 Subject: [PATCH] gnu: Add folly. * gnu/packages/cpp.scm (folly): New variable. --- gnu/local.mk | 1 + gnu/packages/cpp.scm | 61 +++++++++++++++++++ .../patches/folly-add-missing-include.patch | 10 +++ 3 files changed, 72 insertions(+) create mode 100644 gnu/packages/patches/folly-add-missing-include.patch diff --git a/gnu/local.mk b/gnu/local.mk index 83d2d72ab1..155de6c590 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -966,6 +966,7 @@ dist_patch_DATA =3D \ %D%/packages/patches/findutils-localstatedir.patch \ %D%/packages/patches/findutils-test-rwlock-threads.patch \ %D%/packages/patches/flann-cmake-3.11.patch \ + %D%/packages/patches/folly-add-missing-include.patch \ %D%/packages/patches/foobillard++-pkg-config.patch \ %D%/packages/patches/foomatic-filters-CVE-2015-8327.patch \ %D%/packages/patches/foomatic-filters-CVE-2015-8560.patch \ diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm index d3daae74c0..680a2ad520 100644 --- a/gnu/packages/cpp.scm +++ b/gnu/packages/cpp.scm @@ -41,12 +41,22 @@ #:use-module (guix build-system python) #:use-module (gnu packages) #:use-module (gnu packages autotools) + #:use-module (gnu packages boost) #:use-module (gnu packages check) #:use-module (gnu packages code) #:use-module (gnu packages compression) + #:use-module (gnu packages crypto) + #:use-module (gnu packages gcc) + #:use-module (gnu packages libevent) + #:use-module (gnu packages libunwind) + #:use-module (gnu packages linux) #:use-module (gnu packages llvm) + #:use-module (gnu packages logging) + #:use-module (gnu packages maths) #:use-module (gnu packages perl) #:use-module (gnu packages pkg-config) + #:use-module (gnu packages popt) + #:use-module (gnu packages pretty-print) #:use-module (gnu packages tls) #:use-module (gnu packages web)) @@ -669,3 +679,54 @@ parsers according to a Parsing Expression Grammar (PEG).") standard GNU style syntax for options.") (home-page "https://github.com/jarro2783/cxxopts/wiki") (license license:expat))) + +(define-public folly + (package + (name "folly") + (version "2020.10.05.00") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/facebook/folly") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0q4w4cvjxffc462hvs8h4zryq4965j7015zvkwagcm6cj6wmz3cn")) + (patches (search-patches "folly-add-missing-include.patch")))) + (build-system cmake-build-system) + (arguments + '(;; Tests must be explicitly enabled + ;#:configure-flags + ;'("-DBUILD_TESTS=3DON"))) + ;; Leave tests disabled; see https://github.com/facebook/folly/issues/1456 + #:tests? #f)) + (propagated-inputs + `(("boost" ,boost) + ("gflags" ,gflags) + ("glog" ,glog) + ("liburing" ,liburing))) + (inputs + `(("bzip2" ,bzip2) + ("double-conversion" ,double-conversion) + ("fmt" ,fmt) + ("libaio" ,libaio) + ("libevent" ,libevent) + ("libiberty" ,libiberty) + ("libsodium" ,libsodium) + ("libunwind" ,libunwind) + ("lz4" ,lz4) + ("openssl" ,openssl) + ("snappy" ,snappy) + ("zlib" ,zlib) + ("zstd" ,zstd "lib"))) + (native-inputs + `(("googletest" ,googletest))) + (synopsis "Collection of C++ components complementing the standard library") + (description + "Folly (acronymed loosely after Facebook Open Source Library) is a library +of C++14 components which complements @code{std} and Boost.") + (home-page "https://github.com/facebook/folly/wiki") + ; 32-bit is not supported: https://github.com/facebook/folly/issues/10= 3 + (supported-systems '("aarch64" "x86_64-linux")) + (license license:asl2.0))) diff --git a/gnu/packages/patches/folly-add-missing-include.patch b/gnu/packages/patches/folly-add-missing-include.patch new file mode 100644 index 0000000000..929239233f --- /dev/null +++ b/gnu/packages/patches/folly-add-missing-include.patch @@ -0,0 +1,10 @@ +--- a/folly/concurrency/test/AtomicSharedPtrTest.cpp ++++ b/folly/concurrency/test/AtomicSharedPtrTest.cpp +@@ -27,6 +27,7 @@ + #include + #include + #include ++#include + + #include + --=20 2.28.0 On Tue, Sep 29, 2020 at 4:46 PM Ludovic Court=C3=A8s wrote: > Greg Hogan skribis: > > >>From 2835c2ac08db9b5887bcc33a3c15e84f26111864 Mon Sep 17 00:00:00 2001 > > From: Greg Hogan > > Date: Tue, 22 Sep 2020 15:22:32 +0000 > > Subject: [PATCH 2/2] gnu: Add folly. > > > > * gnu/packages/cpp.scm (folly): New variable. > > [...] > > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > + "0ppd02scbi4a52s99par4i17cys4z8gangpxa86yma48k72z5xvs"= )) > > + (patches (search-patches > > "folly-add-missing-include.patch")))) > > Looks like your mail client mangled the patch. > > > + (synopsis "An open-source C++ library developed and used at > Facebook") > > Everything is free software in here, no need to write it. Also, please > remove the initial article and somehow say what the library provides in > terms of features: > > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > > > + (description > > + "Folly (acronymed loosely after Facebook Open Source Library) is = a > > library > > + of C++14 components designed with practicality and efficiency in min= d. > > Folly > > + contains a variety of core library components used extensively at > > Facebook. In > > + particular, it's often a dependency of Facebook's other open source > C++ > > efforts > > + and place where those projects can share code. > > + > > + It complements (as opposed to competing against) offerings such as > Boost > > and of > > + course std. In fact, we embark on defining our own component only wh= en > > + something we need is either not available, or does not meet the need= ed > > + performance profile. We endeavor to remove things from folly if or > when > > std or > > + Boost obsoletes them. > > + > > + Performance concerns permeate much of Folly, sometimes leading to > > designs that > > + are more idiosyncratic than they would otherwise be (see e.g. > > PackedSyncPtr.h, > > + SmallLocks.h). Good performance at large scale is a unifying theme i= n > > all of Folly.") > > I=E2=80=99d strip all but one reference to Facebook, we=E2=80=99re not an= advertising > project. :-) > > Nitpick: please remove =E2=80=9Copen source=E2=80=9D, avoid marketing ter= ms > (=E2=80=9Ccompeting=E2=80=9D, =E2=80=9Cofferings=E2=80=9D, etc.), write @= code{std}, @file{SmallLocks.h} > and similar. > > Could you send an updated patch? > > Thank you! > > Ludo=E2=80=99. > --000000000000b28d7505b153dc2e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This patch depends = on #43619

Reworded synopsis=C2=A0and descripti= on. Updated to newest version. Limited to 64-bit architectures.
<= br>
From 8e3df10ad8aa791e34a5a5abcaabe0438f7b063a Mon Sep 17 00:0= 0:00 2001
From: Greg Hogan <code@greghogan.com>
Date: Tue, 22 Sep 2020 15:22:32 +0= 000
Subject: [PATCH] gnu: Add folly.

* g= nu/packages/cpp.scm (folly): New variable.
---
=C2=A0gn= u/local.mk =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| =C2=A01 +
=C2=A0gnu/packages/cpp.scm =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 61 +++++++++++++++++++
=C2=A0.../patches/folly-add-missing-i= nclude.patch =C2=A0 | 10 +++
=C2=A03 files changed, 72 insertions= (+)
=C2=A0create mode 100644 gnu/packages/patches/folly-add-missi= ng-include.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 83d2d72ab1..155de6c590 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -966,6 +966,7 @@ dist_patch_DATA =3D \
=C2=A0 =C2=A0%D%/packages/patches/findutils-localstatedir.patch \
= =C2=A0 =C2=A0%D%/packages/patches/findutils-test-rwlock-threads.patch \
=C2=A0 =C2=A0%D%/packages/patches/flann-cmake-3.11.patch \
+ =C2= =A0%D%/packages/patches/folly-add-missing-include.patch \
=C2=A0 =C2= =A0%D%/packages/patches/foobillard++-pkg-config.patch \
=C2=A0 =C2=A0= %D%/packages/patches/foomatic-filters-CVE-2015-8327.patch \
=C2=A0 =C2= =A0%D%/packages/patches/foomatic-filters-CVE-2015-8560.patch \
diff --= git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index d3daae74c= 0..680a2ad520 100644
--- a/gnu/packages/cpp.scm
+++ b/g= nu/packages/cpp.scm
@@ -41,12 +41,22 @@
=C2=A0 =C2=A0#:= use-module (guix build-system python)
=C2=A0 =C2=A0#:use-module (= gnu packages)
=C2=A0 =C2=A0#:use-module (gnu packages autotools)<= /div>
+ =C2=A0#:use-module (gnu packages boost)
=C2=A0 =C2=A0= #:use-module (gnu packages check)
=C2=A0 =C2=A0#:use-module (gnu = packages code)
=C2=A0 =C2=A0#:use-module (gnu packages compressio= n)
+ =C2=A0#:use-module (gnu packages crypto)
+ =C2=A0#= :use-module (gnu packages gcc)
+ =C2=A0#:use-module (gnu packages= libevent)
+ =C2=A0#:use-module (gnu packages libunwind)
+ =C2=A0#:use-module (gnu packages linux)
=C2=A0 =C2=A0#:use-mo= dule (gnu packages llvm)
+ =C2=A0#:use-module (gnu packages loggi= ng)
+ =C2=A0#:use-module (gnu packages maths)
=C2=A0 = =C2=A0#:use-module (gnu packages perl)
=C2=A0 =C2=A0#:use-module = (gnu packages pkg-config)
+ =C2=A0#:use-module (gnu packages popt= )
+ =C2=A0#:use-module (gnu packages pretty-print)
=C2= =A0 =C2=A0#:use-module (gnu packages tls)
=C2=A0 =C2=A0#:use-modu= le (gnu packages web))
=C2=A0
@@ -669,3 +679,54 @@ pars= ers according to a Parsing Expression Grammar (PEG).")
=C2= =A0standard GNU style syntax for options.")
=C2=A0 =C2=A0 = =C2=A0(home-page "https://github.com/jarro2783/cxxopts/wiki")
=C2=A0 =C2= =A0 =C2=A0(license license:expat)))
+
+(define-public f= olly
+ =C2=A0(package
+ =C2=A0 =C2=A0(name "folly&= quot;)
+ =C2=A0 =C2=A0(version "2020.10.05.00")
+ =C2=A0 =C2=A0(source (origin
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0(method git-fetch)
+ =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(uri (git-reference
+ =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(url "https://github.com/facebook/folly&quo= t;)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(commit (string-append "v" version))))
+ =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name (git-file-name name= version))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha= 256
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"0q4w= 4cvjxffc462hvs8h4zryq4965j7015zvkwagcm6cj6wmz3cn"))
+ =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(patches (search-patches "fo= lly-add-missing-include.patch"))))
+ =C2=A0 =C2=A0(build-sys= tem cmake-build-system)
+ =C2=A0 =C2=A0(arguments
+ =C2= =A0 =C2=A0 '(;; Tests must be explicitly enabled
+ =C2=A0 =C2= =A0 =C2=A0 ;#:configure-flags
+ =C2=A0 =C2=A0 =C2=A0 ;'("= ;-DBUILD_TESTS=3DON")))
+ =C2=A0 =C2=A0 =C2=A0 ;; Leave test= s disabled; see h= ttps://github.com/facebook/folly/issues/1456
+ =C2=A0 =C2=A0 = =C2=A0 #:tests? #f))
+ =C2=A0 =C2=A0(propagated-inputs
= + =C2=A0 =C2=A0 `(("boost" ,boost)
+ =C2=A0 =C2=A0 =C2= =A0 ("gflags" ,gflags)
+ =C2=A0 =C2=A0 =C2=A0 ("gl= og" ,glog)
+ =C2=A0 =C2=A0 =C2=A0 ("liburing" ,lib= uring)))
+ =C2=A0 =C2=A0(inputs
+ =C2=A0 =C2=A0 `((&quo= t;bzip2" ,bzip2)
+ =C2=A0 =C2=A0 =C2=A0 ("double-conver= sion" ,double-conversion)
+ =C2=A0 =C2=A0 =C2=A0 ("fmt&= quot; ,fmt)
+ =C2=A0 =C2=A0 =C2=A0 ("libaio" ,libaio)
+ =C2=A0 =C2=A0 =C2=A0 ("libevent" ,libevent)
= + =C2=A0 =C2=A0 =C2=A0 ("libiberty" ,libiberty)
+ =C2= =A0 =C2=A0 =C2=A0 ("libsodium" ,libsodium)
+ =C2=A0 =C2= =A0 =C2=A0 ("libunwind" ,libunwind)
+ =C2=A0 =C2=A0 =C2= =A0 ("lz4" ,lz4)
+ =C2=A0 =C2=A0 =C2=A0 ("openssl&= quot; ,openssl)
+ =C2=A0 =C2=A0 =C2=A0 ("snappy" ,snapp= y)
+ =C2=A0 =C2=A0 =C2=A0 ("zlib" ,zlib)
+ = =C2=A0 =C2=A0 =C2=A0 ("zstd" ,zstd "lib")))
+= =C2=A0 =C2=A0(native-inputs
+ =C2=A0 =C2=A0 `(("googletest&= quot; ,googletest)))
+ =C2=A0 =C2=A0(synopsis "Collection of= C++ components complementing the standard library")
+ =C2= =A0 =C2=A0(description
+ =C2=A0 =C2=A0 "Folly (acronymed loo= sely after Facebook Open Source Library) is a library
+of C++14 c= omponents which complements @code{std} and Boost.")
+ =C2=A0= =C2=A0(home-page "= https://github.com/facebook/folly/wiki")
+ =C2=A0 =C2=A0= ; 32-bit is not supported: https://github.com/facebook/folly/issues/103
+ =C2= =A0 =C2=A0(supported-systems '("aarch64" "x86_64-linux&q= uot;))
+ =C2=A0 =C2=A0(license license:asl2.0)))
diff -= -git a/gnu/packages/patches/folly-add-missing-include.patch b/gnu/packages/= patches/folly-add-missing-include.patch
new file mode 100644
index 0000000000..929239233f
--- /dev/null
+++ b/= gnu/packages/patches/folly-add-missing-include.patch
@@ -0,0 +1,1= 0 @@
+--- a/folly/concurrency/test/AtomicSharedPtrTest.cpp
<= div>++++ b/folly/concurrency/test/AtomicSharedPtrTest.cpp
+@@ -27= ,6 +27,7 @@
+ #include <folly/concurrency/AtomicSharedPtr.h>= ;
+ #include <folly/concurrency/test/AtomicSharedPtrCounted.h&= gt;
+ #include <folly/portability/GTest.h>
++#inc= lude <folly/portability/GFlags.h>
+=C2=A0
+ #incl= ude <folly/test/DeterministicSchedule.h>
+=C2=A0
= --=C2=A0
2.28.0

On Tue, Sep 29, 2020 at 4:46 PM = Ludovic Court=C3=A8s <ludo@gnu.org&g= t; wrote:
Greg Hogan <code@greghogan.com> skribis:

>>From 2835c2ac08db9b5887bcc33a3c15e84f26111864 Mon Sep 17 00:00:00 2= 001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 22 Sep 2020 15:22:32 +0000
> Subject: [PATCH 2/2] gnu: Add folly.
>
> * gnu/packages/cpp.scm (folly): New variable.

[...]

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-name (git-file= -name name version))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "0ppd02s= cbi4a52s99par4i17cys4z8gangpxa86yma48k72z5xvs"))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (patches (search-pat= ches
> "folly-add-missing-include.patch"))))

Looks like your mail client mangled the patch.

> +=C2=A0 =C2=A0 (synopsis "An open-source C++ library developed an= d used at Facebook")

Everything is free software in here, no need to write it.=C2=A0 Also, pleas= e
remove the initial article and somehow say what the library provides in
terms of features:

=C2=A0 https://guix.gnu.org/m= anual/en/html_node/Synopses-and-Descriptions.html

> +=C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0"Folly (acronymed loosely after Facebook Ope= n Source Library) is a
> library
> +=C2=A0 of C++14 components designed with practicality and efficiency = in mind.
> Folly
> +=C2=A0 contains a variety of core library components used extensively= at
> Facebook. In
> +=C2=A0 particular, it's often a dependency of Facebook's othe= r open source C++
> efforts
> +=C2=A0 and place where those projects can share code.
> +
> +=C2=A0 It complements (as opposed to competing against) offerings suc= h as Boost
> and of
> +=C2=A0 course std. In fact, we embark on defining our own component o= nly when
> +=C2=A0 something we need is either not available, or does not meet th= e needed
> +=C2=A0 performance profile. We endeavor to remove things from folly i= f or when
> std or
> +=C2=A0 Boost obsoletes them.
> +
> +=C2=A0 Performance concerns permeate much of Folly, sometimes leading= to
> designs that
> +=C2=A0 are more idiosyncratic than they would otherwise be (see e.g.<= br> > PackedSyncPtr.h,
> +=C2=A0 SmallLocks.h). Good performance at large scale is a unifying t= heme in
> all of Folly.")

I=E2=80=99d strip all but one reference to Facebook, we=E2=80=99re not an a= dvertising
project.=C2=A0 :-)

Nitpick: please remove =E2=80=9Copen source=E2=80=9D, avoid marketing terms=
(=E2=80=9Ccompeting=E2=80=9D, =E2=80=9Cofferings=E2=80=9D, etc.), write @co= de{std}, @file{SmallLocks.h}
and similar.

Could you send an updated patch?

Thank you!

Ludo=E2=80=99.
--000000000000b28d7505b153dc2e--