From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:47512) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihd2P-00022X-HZ for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihd2N-0006SE-N5 for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37903) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihd2M-0006QC-7V for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihd2M-0007IA-3R for guix-patches@gnu.org; Wed, 18 Dec 2019 12:23:02 -0500 Subject: [bug#38625] Fwd: [bug#38625] [PATCH] music.scm: Add glyr Resent-Message-ID: MIME-Version: 1.0 References: <874ky1cjac.fsf@elephly.net> In-Reply-To: From: Riku Viitanen Date: Wed, 18 Dec 2019 18:57:48 +0200 Message-ID: Content-Type: multipart/alternative; boundary="000000000000e02edb0599fd58a3" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 38625@debbugs.gnu.org --000000000000e02edb0599fd58a3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ricardo, and thanks for the feedback! I think all the mentioned issues should now be fixed. I checked some of the source files, and it turns out they say permit any later version of the license, so I changed the license to lgpl3+. Only the README file mentions "just" LGPLv3 without saying anything about later versions, so I thought it meant the same as "only". Here's the new patch in git format: >From 97d4d5d7d16eb87896d81e070510d919118aa622 Mon Sep 17 00:00:00 2001 From: Riku Viitanen Date: Wed, 18 Dec 2019 18:30:14 +0200 Subject: [PATCH] gnu: Add glyr * gnu/packages/music.scm (glyr): New variable --- gnu/packages/music.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index f80fb067e8..0adfa96fbe 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -25,6 +25,7 @@ ;;; Copyright =C2=A9 2019 raingloom ;;; Copyright =C2=A9 2019 David Wilson ;;; Copyright =C2=A9 2019 Alexandros Theodotou +;;; Copyright =C2=A9 2019 Riku Viitanen ;;; ;;; This file is part of GNU Guix. ;;; @@ -5106,3 +5107,37 @@ MIDI drums and comes as two separate drumkits: Black Pearl and Red Zeppelin.") (description "Helm is a cross-platform polyphonic synthesizer available standalone and as an LV2 plugin.") (license license:gpl3+))) + +(define-public glyr + (package + (name "glyr") + (version "1.0.10") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/sahib/glyr.git") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1miwbqzkhg0v3zysrwh60pj9sv6ci4lzq2vq2hhc6pc6hdyh8xyr")))= ) + (build-system cmake-build-system) + (arguments + '(#:tests? #f)) + (inputs + `(("glib" ,glib) + ("curl" ,curl) + ("sqlite" ,sqlite))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (home-page "https://github.com/sahib/glyr") + (synopsis "Search engine for music related metadata") + (description + "Glyr comes both in a command-line interface tool (@command{glyrc}) and +as a C library (libglyr), both with an easy to use interface. The sort of +metadata glyr is searching (and downloading) is usually the data you see i= n +your musicplayer. And indeed, originally it was written to serve as internally +library for a musicplayer, but has been extended to work as a standalone +program which is able to download cover art, lyrics, photos, biographies, +reviews and more.") + (license license:lgpl3+))) --=20 2.24.1 --000000000000e02edb0599fd58a3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ricardo, and thanks for the feedback!

I think= all the mentioned issues should now be fixed.
I checked some= of the source files, and it turns out they say permit any later version of= the license, so I changed the license to lgpl3+.
Only the README= file mentions "just" LGPLv3 without saying anything about later = versions, so I thought it meant the same as "only".

Here's the new patch in git format:

From 97d4d5d7d16eb87896d81e070510d919118aa622 Mon Sep 17 00:00:00 200= 1
From: Riku Viitanen <riku.viitanen0@gmail.com>
Date: Wed, 18 Dec 2019 = 18:30:14 +0200
Subject: [PATCH] gnu: Add glyr

* gnu/packages/musi= c.scm (glyr): New variable
---
=C2=A0gnu/packages/music.scm | 35 ++++= +++++++++++++++++++++++++++++++
=C2=A01 file changed, 35 insertions(+)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index= f80fb067e8..0adfa96fbe 100644
--- a/gnu/packages/music.scm
+++ b/gnu= /packages/music.scm
@@ -25,6 +25,7 @@
=C2=A0;;; Copyright =C2=A9 2019= raingloom <raingloom@protonmail.com>
=C2=A0;;; Copyright =C2=A9 2019 David= Wilson <david@da= viwil.com>
=C2=A0;;; Copyright =C2=A9 2019 Alexandros Theodotou &= lt;alex@zrythm.org= >
+;;; Copyright =C2=A9 2019 Riku Viitanen <riku.viitanen0@gmail.com>=C2=A0;;;
=C2=A0;;; This file is part of GNU Guix.
=C2=A0;;;
@@ -= 5106,3 +5107,37 @@ MIDI drums and comes as two separate drumkits: Black Pea= rl and Red Zeppelin.")
=C2=A0=C2=A0=C2=A0=C2=A0 (description "= Helm is a cross-platform polyphonic synthesizer available standalone
=C2= =A0and as an LV2 plugin.")
=C2=A0=C2=A0=C2=A0=C2=A0 (license licens= e:gpl3+)))
+
+(define-public glyr
+=C2=A0 (package
+=C2=A0=C2= =A0=C2=A0 (name "glyr")
+=C2=A0=C2=A0=C2=A0 (version "1.0= .10")
+=C2=A0=C2=A0=C2=A0 (source (origin
+=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (method git-fetch= )
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (uri (git-reference
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (url "https://github.com/sahib/glyr.git")
+=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit version)))
+=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (file-name (git-file= -name name version))
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (sha256
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (base32
+= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 "1miwbqzkhg0v3zysrwh60pj9sv6ci4lzq2vq2hhc6pc6hdy= h8xyr"))))
+=C2=A0=C2=A0=C2=A0 (build-system cmake-build-system)+=C2=A0=C2=A0=C2=A0 (arguments
+=C2=A0=C2=A0=C2=A0=C2=A0 '(#:tests?= #f))
+=C2=A0=C2=A0=C2=A0 (inputs
+=C2=A0=C2=A0=C2=A0=C2=A0 `(("= glib" ,glib)
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("curl"= ; ,curl)
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ("sqlite" ,sqli= te)))
+=C2=A0=C2=A0=C2=A0 (native-inputs
+=C2=A0=C2=A0=C2=A0=C2=A0 `(= ("pkg-config" ,pkg-config)))
+=C2=A0=C2=A0=C2=A0 (home-page &q= uot;https://git= hub.com/sahib/glyr")
+=C2=A0=C2=A0=C2=A0 (synopsis "Search= engine for music related metadata")
+=C2=A0=C2=A0=C2=A0 (descripti= on
+=C2=A0=C2=A0=C2=A0=C2=A0 "Glyr comes both in a command-line int= erface tool (@command{glyrc}) and
+as a C library (libglyr), both with a= n easy to use interface. The sort of
+metadata glyr is searching (and do= wnloading) is usually the data you see in
+your musicplayer. And indeed,= originally it was written to serve as internally
+library for a musicpl= ayer, but has been extended to work as a standalone
+program which is ab= le to download cover art, lyrics, photos, biographies,
+reviews and more= .")
+=C2=A0=C2=A0=C2=A0 (license license:lgpl3+)))
--
2.24.1=
--000000000000e02edb0599fd58a3--