From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id AMfgJQlF91/6SwAA0tVLHw (envelope-from ) for ; Thu, 07 Jan 2021 17:29:45 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id wJmnIQlF91+sUAAAbx9fmQ (envelope-from ) for ; Thu, 07 Jan 2021 17:29:45 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 561499403A9 for ; Thu, 7 Jan 2021 17:29:45 +0000 (UTC) Received: from localhost ([::1]:38052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxZ6W-000323-6r for larch@yhetil.org; Thu, 07 Jan 2021 12:29:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxZ4u-0000Nv-NA for guix-patches@gnu.org; Thu, 07 Jan 2021 12:28:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxZ4s-00077v-NZ for guix-patches@gnu.org; Thu, 07 Jan 2021 12:28:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kxZ4s-0002mT-JJ for guix-patches@gnu.org; Thu, 07 Jan 2021 12:28:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45632] [PATCH] guix package: Warn if uses has 'guix' package in profile. References: <20210103183202.11224-1-kuba@kadziolka.net> Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 07 Jan 2021 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45632 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "zimoun" Received: via spool by 45632-submit@debbugs.gnu.org id=B45632.161004047310671 (code B ref 45632); Thu, 07 Jan 2021 17:28:02 +0000 Received: (at 45632) by debbugs.gnu.org; 7 Jan 2021 17:27:53 +0000 Received: from localhost ([127.0.0.1]:48503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxZ4j-0002m3-9J for submit@debbugs.gnu.org; Thu, 07 Jan 2021 12:27:53 -0500 Received: from pat.zlotemysli.pl ([37.59.186.212]:37490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kxZ4g-0002lt-B7 for 45632@debbugs.gnu.org; Thu, 07 Jan 2021 12:27:52 -0500 Received: (qmail 6704 invoked by uid 1009); 7 Jan 2021 18:27:48 +0100 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/26041. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.013603 secs); 07 Jan 2021 17:27:48 -0000 Received: from unknown (HELO localhost) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 7 Jan 2021 18:27:47 +0100 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Date: Thu, 07 Jan 2021 18:11:25 +0100 Message-Id: In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45632@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 561499403A9 X-Spam-Score: -1.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: GqSJ6OrwbL7Y On Thu Jan 7, 2021 at 5:39 PM CET, zimoun wrote: > Hi, > > On Sun, 3 Jan 2021 at 19:33, Jakub K=C4=85dzio=C5=82ka > wrote: > > > > * guix/scripts/package.scm (warn-about-guix-in-profile): New procedure. > > (process-actions): Call WARN-ABOUT-GUIX-IN-PROFILE before executing > > transaction. > > --- > > > > Unresolved questions: > > - Is this the right place to put warn-about-guix-in-profile? > > - The warning message seems to be hard-wrapped. Is this the right > > line length? > > - Do we want to make this configurable? Some other warnings are, but in > > those cases it is the threshold that gets configured. In this case, > > there is no threshold. > > What is the use case? I have missed some context. As the actual warning text explains, including the guix package in a profile loaded by default breaks the 'guix pull' update mechanism, as the guix package from the profile will take priority. This is inspired by some tech support on IRC where this turned out to be a root cause of a problem. Moreover, if I'm not missing anything, running 'guix package -u' with such a setup would *downgrade* the guix package each time. > For example, I have the package 'guix' in some of my profiles and I > would be annoyed to be warned. And I have it for good reasons. :-) Okay, I can see now that it is not wise to skimp on configurability for this. Though, I would like to hear more about your usecase - how do you keep your guix updated, for example? > Once the story about extension is good enough, As in adding your own commands under the 'guix $CMD' namespace, or something more sophisticated? For the former, git seems to have a quite good mechanism - we could borrow that. Regards, Jakub K=C4=85dzio=C5=82ka