From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id R3sFB8sNZl+pKgAA0tVLHw (envelope-from ) for ; Sat, 19 Sep 2020 13:55:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oANzAssNZl/efwAA1q6Kng (envelope-from ) for ; Sat, 19 Sep 2020 13:55:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84E979402AF for ; Sat, 19 Sep 2020 13:55:22 +0000 (UTC) Received: from localhost ([::1]:43798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJdKj-0004Xh-59 for larch@yhetil.org; Sat, 19 Sep 2020 09:55:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJdKR-0004S4-6j for guix-patches@gnu.org; Sat, 19 Sep 2020 09:55:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJdKQ-00074I-By for guix-patches@gnu.org; Sat, 19 Sep 2020 09:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJdKQ-00022M-Bh for guix-patches@gnu.org; Sat, 19 Sep 2020 09:55:02 -0400 Subject: bug#42555: [PATCH v2 core-updates] build-system/gnu: strip with --strip-unneeded References: <20200726233850.12321-1-kuba@kadziolka.net> Resent-From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 19 Sep 2020 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42555 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 42555@debbugs.gnu.org, 42555-done@debbugs.gnu.org Mail-Followup-To: 42555@debbugs.gnu.org, kuba@kadziolka.net, kuba@kadziolka.net Received: via spool by 42555-done@debbugs.gnu.org id=D42555.16005236447739 (code D ref 42555); Sat, 19 Sep 2020 13:55:02 +0000 Received: (at 42555-done) by debbugs.gnu.org; 19 Sep 2020 13:54:04 +0000 Received: from localhost ([127.0.0.1]:45838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJdJQ-00020Q-I3 for submit@debbugs.gnu.org; Sat, 19 Sep 2020 09:54:03 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:40546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJdJO-000209-3l for 42555-done@debbugs.gnu.org; Sat, 19 Sep 2020 09:53:59 -0400 Received: (qmail 1895 invoked by uid 1009); 19 Sep 2020 15:53:55 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25932. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.045518 secs); 19 Sep 2020 13:53:55 -0000 Received: from unknown (HELO localhost) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 19 Sep 2020 15:53:55 +0200 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 From: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= Date: Sat, 19 Sep 2020 15:49:31 +0200 Message-Id: In-Reply-To: <87o8m2q6ca.fsf@gnu.org> X-Qmailux-2.08st: added fake MIME-Version header MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: tSkGuxQZXSul On Sat Sep 19, 2020 at 4:49 PM CEST, Ludovic Court=C3=A8s wrote: > Hi Jakub, > > Jakub K=C4=85dzio=C5=82ka skribis: > > > Apart from debug information, one can also strip some symbols. This can > > be a significant difference, the closure of gcc-toolchain@7 got reduced > > by 15 MB in my tests. > > Nice! Now=E2=80=99s a good time to get that patch in on =E2=80=98core-upd= ates=E2=80=99. Thanks. Patch pushed (with a small hiccup...) > > [1]: https://stackoverflow.com/a/52555093 > > Perhaps we can omit this one. In general, I think it=E2=80=99s safer to r= efer > to =E2=80=9Cprimary sources=E2=80=9D as Wikipedians would say. The problem with "primary sources" is that the docs on this are quite sparse. I think this link is much more comprehensive. > > [2]: http://www.linuxfromscratch.org/lfs/view/9.1/chapter05/stripping.h= tml > > [3]: https://www.technovelty.org/linux/stripping-shared-libraries.html > > > > * guix/build/gnu-build-system.scm (strip): Use --strip-unneeded. > > * guix/build-system/gnu.scm (static-package, gnu-build, gnu-cross-build= ): Likewise. > > LGTM! > > For the record, I tried =E2=80=98--strip-all=E2=80=99 before, but that wa= s > problematic > for some reason: > > https://lists.gnu.org/archive/html/guix-devel/2018-03/msg00135.html The docs for --strip-all say "Do not copy relocation and symbol information", so I would expect some relocation and/or linking use case to get broken... Regards, Jakub K=C4=85dzio=C5=82ka