From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UBWNF5k8smYQDgEAqHPOHw:P1 (envelope-from ) for ; Tue, 06 Aug 2024 15:09:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id UBWNF5k8smYQDgEAqHPOHw (envelope-from ) for ; Tue, 06 Aug 2024 17:09:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=P5mhapBj; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=P4V1uOnX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1722956953; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6zHpPqb41RbdD/ExP8Yh8RYfoymi3APSFsk8UUmp8FI=; b=QR80fZZSszsS2/WGJ405ofZwPsI2fVDs84+6eV91+pv+AFtD1Cj6mcGJgWZpqBv1dv4g0W T4v5tbtf4XjnHLqLG8CuOgnkCh2/NeXD1N3/7T/tL11fPkvN3ciXANLcMrp4RxKhNeW0KH XMqupsND83gXyq402WByP8fa2N77CrtHJNd87obZmAtEmUoRttFxoUWGOBhiLy/zWWQ/Bg fbpgeUKPXnDI/Sw9uV7TNq4NY5Mt+VjNuWR597lkeRPePMQ48EKLi4cZB+yCk88Fd/3e4W ND2gahh/rLx+si7SXumyYj+IkIwZFF/xS2em1KLOUZZaqLjwJLUCwN2DEUptlw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=P5mhapBj; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=P4V1uOnX; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1722956953; a=rsa-sha256; cv=none; b=mUuJMaDAQ1r2Hi91Ku1oygs7jucdjxnNH3gRo7swTM33mHr3ePLo6pt0ONA54jVkW8Tv7T ziyOPh6oSY+CiNIkM1nLQE6+KGTPjMjti/Nb58UBgfoBOOoTp80LK7JE0cT1eVI+3JDshO jXYPQVr2VgvR3mFlNBpfZs5MLM0gKcdFqrZzDJefgSDnZWCOLrVc2KkjFzoA4XBEU+bsqN qGqQidii8WoQujxLqj2l/T19xsR0eJ2xe1JJYysDw1ZAPhaBp8wq1hjvPIDOJe4U+2y8m0 YTxJxIkghJszIbIefxSOGxOK/7PJnLl32uMbLNfp7gRwv2amZun5w7OULDyd8w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 09A996D520 for ; Tue, 6 Aug 2024 17:09:13 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbLnk-0005kz-Om; Tue, 06 Aug 2024 11:08:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbLni-0005kG-LH for guix-patches@gnu.org; Tue, 06 Aug 2024 11:08:38 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbLni-0003Ko-CV for guix-patches@gnu.org; Tue, 06 Aug 2024 11:08:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=6zHpPqb41RbdD/ExP8Yh8RYfoymi3APSFsk8UUmp8FI=; b=P5mhapBjwnx7C+qE88IGCIPBv4qcYiGU32sCOIm53LFmI+7MKbP67qhxYIUOz+l78aAskoWH1ztoeiVj2JgDpwFDLjC/KDbMgDAOlwZiMxkWkQ8Em5f8ChLWh6JEcgAdDn7k6VYhu+oGcaC1OruEscRqOvSv9hsxPHrkcXaRyGcHiTeDT4vBL2HBCHCcGtC2UT/bsyNLjoQMAKi9kZpFxQw9FFrjOkopLVFO6bp0ndl0Xt2OnDbyxU3e5kn/4yEgsY5JPlyxUCazFAW7GPIAjJN2BPpSlyBXUJsCy9yPQ/eefsW/QlYjfjmKextwuYv33f6cWfmBGsVTU9Tbhbc4ug==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbLo6-0000SJ-7g for guix-patches@gnu.org; Tue, 06 Aug 2024 11:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72494] [PATCH 0/1] Add C3 References: In-Reply-To: Resent-From: Adam Faiz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Aug 2024 15:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72494 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72494@debbugs.gnu.org Cc: ashvithshetty10@gmail.com Received: via spool by 72494-submit@debbugs.gnu.org id=B72494.17229568841426 (code B ref 72494); Tue, 06 Aug 2024 15:09:02 +0000 Received: (at 72494) by debbugs.gnu.org; 6 Aug 2024 15:08:04 +0000 Received: from localhost ([127.0.0.1]:32875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbLnA-0000Ms-DL for submit@debbugs.gnu.org; Tue, 06 Aug 2024 11:08:04 -0400 Received: from layka.disroot.org ([178.21.23.139]:56486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbLn6-0000LR-Ts for 72494@debbugs.gnu.org; Tue, 06 Aug 2024 11:08:02 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 471D841183; Tue, 6 Aug 2024 17:07:34 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BRH57wvYinR0; Tue, 6 Aug 2024 17:07:33 +0200 (CEST) Date: Tue, 06 Aug 2024 15:07:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1722956853; bh=s0l5/EFkvS1ZPKiWC2nkx/9HkFD57XOP7N+QumRHs+A=; h=Date:From:To:CC:Subject; b=P4V1uOnXn1tJztzzrYIrJWOQ9Z/P2yjOa2R0bHWlCRFnO9pzLPrpt4txY8dYoW2pe icLTlNJ5HSvsRRQgCmcOfAcTP4IFcMO+8wvBOoe8aw4qjkgKCmXWOMEIYr0eegCYO+ jR6ky6Y23gp3POmiwhIiUHzXtf2vHkvEB5pvQ6KXb9tNzCTSDFO2zXEuWchXBaz7a0 7PTOAgPGH2F0CnGungH/udn7wZW/rwGLxm6WymQQXv3ZXF7Qf8/zUeBMh+Fv02c76U qfX/KMFZZzDhzcuZqqRG6krR8Jm3mrBfMocC5oGZBkQz180ApQXu1sWbqiClryXtlF 9NuKXexf1KmeQ== Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adam Faiz X-ACL-Warn: , Adam Faiz via Guix-patches From: Adam Faiz via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -6.94 X-Migadu-Queue-Id: 09A996D520 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -6.94 X-TUID: qfKRkBTXWBRY Hello Ashvith, I'd like to give my feedback on this patch series=2E I'll send an updated = patch series using the suggestions below if I have the time=2E > +(define-public c3c-bootstrap > + (package > + (name "c3c") > + (version "0=2E6=2E1") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github=2Ecom/c3lang/c3c") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 "0xjl3yghyqmqv9118nhcix3xywlpdirqc0dlmdaghdkja0wr19rw")= ) > + (snippet #~(begin > + (use-modules (guix build utils)) > + (substitute* "CMakeLists=2Etxt" > + (("\\$\\{LLVM_LIBRARY_DIRS\\}") > + (string-append #$lld-18 "/lib/ " > + #$llvm-18 "/lib/"))))))) > + (build-system cmake-build-system) > + (arguments > + '(#:configure-flags '("-DCMAKE_INSTALL_LIBDIR=3Dlib") > + ;; TODO: Fix test > + #:tests? #f)) According to its README, the unit tests are run using the built c3c with i= ts compile-test subcommand: `c3c compile-test test/unit`=2E The `check` bui= ld phase needs to be replaced to run this command=2E A patch sent upstream to add a proper `check` target would be good, and th= e test/ subdirectory would probably also need to be specified as part of th= e out-of-tree build=2E > + (inputs (list curl libffi llvm-18 lld-18)) The curl dependency should be removed, since c3c's optional dependency dow= nloading functionality isn't needed in Guix=2E