[bug#39331] [PATCH] gnu: Add emacs-persist and emacs-org-drill

[bug#39331] [PATCH] gnu: Add emacs-persist and emacs-org-drill

[Robert Smith]

* gnu/packages/emacs-xyz.scm (emacs-persist): New variable.
  (emacs-org-drill): New variable.
---
Added emacs-org-drill and its dependency emacs-persist. emacs-org-drill
was previously included in emacs-org-contrib, but was removed in 2019
and placed in a separate melpa package.

 gnu/packages/emacs-xyz.scm | 51 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e834dfffb3..7054bd0d72 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2019 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2019 David Wilson <david@daviwil.com>
 ;;; Copyright © 2020 Paul Garlick <pgarlick@tourbillion-technology.com>
+;;; Copyright © 2020 Robert Smith <robertsmith@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21237,3 +21238,53 @@ mode-line text (lighter) of major and minor modes.")
       (description "@code{unkillable-scratch} helps prevent killing buffers
 matching a given regexp.")
       (license license:gpl2+))))
+
+(define-public emacs-persist
+  (package
+    (name "emacs-persist")
+    (version "0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://elpa.gnu.org/packages/persist-"
+                           version ".tar"))
+       (sha256
+        (base32 "0gpxy41qawzss2526j9a7lys60vqma1lvamn4bfabwza7gfhac0q"))))
+    (build-system emacs-build-system)
+    (home-page "http://elpa.gnu.org/packages/persist.html")
+    (synopsis "Persist Variables between Emacs Sessions")
+    (description
+     "This package provides variables which persist across sessions.
+Values are stored in a directory in `user-emacs-directory', using
+one file per value.  This makes it easy to delete or remove unused
+variables.")
+    (license license:gpl3+)))
+
+(define-public emacs-org-drill
+  (package
+    (name "emacs-org-drill")
+    ;; Latest version in melpa-stable is from 2016
+    (version "20191219.2100")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/org-drill-"
+			   version ".el"))
+       (sha256
+	    (base32 "0nbsn1vi2g68yvy74r3bmywfkgpm4a5nmx5g9sxy5fb185lrkzc8"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-seq" ,emacs-seq)
+       ("emacs-org" ,emacs-org)
+       ("emacs-persist" ,emacs-persist)))
+    (home-page "https://gitlab.com/phillord/org-drill")
+    (synopsis "Self-testing using spaced repetition")
+    (description
+    "Org-Drill is an extension for Org mode. Org-Drill uses a spaced
+repetition algorithm to conduct interactive drill sessions, using org files as
+sources of facts to be memorised. Each topic is treated as a flash card. The
+material to be remembered is presented to the student in random order. The
+student rates his or her recall of each item, and this information is used to
+schedule the item for later revision.")
+    (license license:gpl3+)))
+
-- 
2.25.0

[bug#39331] [PATCH v2] gnu: Add emacs-persist and emacs-org-drill

[Robert Smith]

* gnu/packages/emacs-xyz.scm (emacs-persist): New variable.
  (emacs-org-drill): New variable.
---
style edit, removed some tab characters

 gnu/packages/emacs-xyz.scm | 51 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e834dfffb3..f2fe5c02a5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2019 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2019 David Wilson <david@daviwil.com>
 ;;; Copyright © 2020 Paul Garlick <pgarlick@tourbillion-technology.com>
+;;; Copyright © 2020 Robert Smith <robertsmith@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21237,3 +21238,53 @@ mode-line text (lighter) of major and minor modes.")
       (description "@code{unkillable-scratch} helps prevent killing buffers
 matching a given regexp.")
       (license license:gpl2+))))
+
+(define-public emacs-persist
+  (package
+    (name "emacs-persist")
+    (version "0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://elpa.gnu.org/packages/persist-"
+                           version ".tar"))
+       (sha256
+        (base32 "0gpxy41qawzss2526j9a7lys60vqma1lvamn4bfabwza7gfhac0q"))))
+    (build-system emacs-build-system)
+    (home-page "http://elpa.gnu.org/packages/persist.html")
+    (synopsis "Persist Variables between Emacs Sessions")
+    (description
+     "This package provides variables which persist across sessions.
+Values are stored in a directory in `user-emacs-directory', using
+one file per value.  This makes it easy to delete or remove unused
+variables.")
+    (license license:gpl3+)))
+
+(define-public emacs-org-drill
+  (package
+    (name "emacs-org-drill")
+    ;; Latest version in melpa-stable is from 2016
+    (version "20191219.2100")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://melpa.org/packages/org-drill-"
+                           version ".el"))
+       (sha256
+        (base32 "0nbsn1vi2g68yvy74r3bmywfkgpm4a5nmx5g9sxy5fb185lrkzc8"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-seq" ,emacs-seq)
+       ("emacs-org" ,emacs-org)
+       ("emacs-persist" ,emacs-persist)))
+    (home-page "https://gitlab.com/phillord/org-drill")
+    (synopsis "Self-testing using spaced repetition")
+    (description
+    "Org-Drill is an extension for Org mode. Org-Drill uses a spaced
+repetition algorithm to conduct interactive drill sessions, using org files as
+sources of facts to be memorised. Each topic is treated as a flash card. The
+material to be remembered is presented to the student in random order. The
+student rates his or her recall of each item, and this information is used to
+schedule the item for later revision.")
+    (license license:gpl3+)))
+
-- 
2.25.0

[bug#39331] [PATCH v2] gnu: Add emacs-persist and emacs-org-drill

[Nicolas Goaziou]

Hello,

Robert Smith <robertsmith@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-persist): New variable.
>   (emacs-org-drill): New variable.

Thank you!

Would you mind splitting this into two different patches?

> +    (synopsis "Persist Variables between Emacs Sessions")

I think titlecase is not warranted here:

  Persist variables between Emacs sessions

> +    (description
> +     "This package provides variables which persist across sessions.
> +Values are stored in a directory in `user-emacs-directory', using

@code{user-emacs-directory} may be more appropriate here.

> +    (propagated-inputs
> +     `(("emacs-seq" ,emacs-seq)
> +       ("emacs-org" ,emacs-org)
> +       ("emacs-persist" ,emacs-persist)))

Could you re-order inputs alphabetically?

> +    (home-page "https://gitlab.com/phillord/org-drill")
> +    (synopsis "Self-testing using spaced repetition")
> +    (description
> +    "Org-Drill is an extension for Org mode. Org-Drill uses a spaced

    Org Drill is an....

> +repetition algorithm to conduct interactive drill sessions, using org files as

... using Org files as...

> +sources of facts to be memorised. Each topic is treated as a flash card. The
> +material to be remembered is presented to the student in random order. The
> +student rates his or her recall of each item, and this information is used to
> +schedule the item for later revision.")

You need to put two spaces after full stops.

Regards,

-- 
Nicolas Goaziou

[bug#39331] [PATCH v2] gnu: Add emacs-persist and emacs-org-drill

[Robert Smith]

Sorry for the delay Nicolas, unfortunately I caught the flu and had to
put this on hold for a while.

On Sun Feb 2, 2020 at 3:11 PM Nicolas Goaziou wrote:
> Would you mind splitting this into two different patches?

I've found a few bugs in emacs-org-drill since submitting, and upstream
doesn't seem to be responding to bug requests at the moment. I'm going
to just resubmit emacs-persist for the time being and wait until I hear
back from the emacs-org-drill maintainer before resubmitting that patch.

-Robert

[bug#39331] [PATCH v3] gnu: Add emacs-persist.

[Robert Smith]

* gnu/packages/emacs-xyz.scm (emacs-persist): New variable.
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 9087a8d98c..1cbcf8a91b 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -58,6 +58,7 @@
 ;;; Copyright © 2019 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2019 David Wilson <david@daviwil.com>
 ;;; Copyright © 2020 Paul Garlick <pgarlick@tourbillion-technology.com>
+;;; Copyright © 2020 Robert Smith <robertsmith@posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21455,3 +21456,24 @@ Flyspell's on-the-fly spell checking and extends these checks to also detect
 language.  Auto-dictionary then sets @code{ispell-dictionary} to use the
 detected language.")
     (license license:gpl2+)))
+
+(define-public emacs-persist
+  (package
+    (name "emacs-persist")
+    (version "0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://elpa.gnu.org/packages/persist-"
+                           version ".tar"))
+       (sha256
+        (base32 "0gpxy41qawzss2526j9a7lys60vqma1lvamn4bfabwza7gfhac0q"))))
+    (build-system emacs-build-system)
+    (home-page "http://elpa.gnu.org/packages/persist.html")
+    (synopsis "Persist variables between emacs sessions")
+    (description
+     "This package provides variables which persist across sessions.
+Values are stored in a directory in @code{user-emacs-directory}, using
+one file per value.  This makes it easy to delete or remove unused
+variables.")
+    (license license:gpl3+)))
-- 
2.25.0

[bug#39331] [PATCH v3] gnu: Add emacs-persist.

[Nicolas Goaziou]

Hello,

Robert Smith <robertsmith@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-persist): New variable.

Applied. Thank you!

I'm not closing this bug report in case you want to add Org Drill at
some point. Otherwise, you can also close it, and open a new bug report
for Org Drill.

Regards,

-- 
Nicolas Goaziou

bug#39331: [PATCH v3] gnu: Add emacs-persist

[Robert Smith]

On Mon Feb 17, 2020 at 10:18 AM Nicolas Goaziou wrote:
> I'm not closing this bug report in case you want to add Org Drill at
> some point. Otherwise, you can also close it, and open a new bug report
> for Org Drill.

Still no word from upstream, so I'm closing the bug report.
Hopefully I'll open a new one for org-drill soon.

-Robert