From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OII+AjU4lWC9WgEAgWs5BA (envelope-from ) for ; Fri, 07 May 2021 14:53:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id KD1wOTQ4lWCzQQAAbx9fmQ (envelope-from ) for ; Fri, 07 May 2021 12:53:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9CEAB1B402 for ; Fri, 7 May 2021 14:53:08 +0200 (CEST) Received: from localhost ([::1]:60378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lezyd-0005i2-Pr for larch@yhetil.org; Fri, 07 May 2021 08:53:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lezyY-0005gh-Bb for guix-patches@gnu.org; Fri, 07 May 2021 08:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lezyY-0006Rc-2A for guix-patches@gnu.org; Fri, 07 May 2021 08:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lezyY-0006Qy-0s for guix-patches@gnu.org; Fri, 07 May 2021 08:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48275] [PATCH] gnu: ocaml: Depend on libiberty. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 May 2021 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48275 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= ,48275@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 48275-submit@debbugs.gnu.org id=B48275.162039194824725 (code B ref 48275); Fri, 07 May 2021 12:53:01 +0000 Received: (at 48275) by debbugs.gnu.org; 7 May 2021 12:52:28 +0000 Received: from localhost ([127.0.0.1]:43713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezxz-0006Qj-TT for submit@debbugs.gnu.org; Fri, 07 May 2021 08:52:28 -0400 Received: from lepiller.eu ([89.234.186.109]:36566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lezxx-0006Qa-8F for 48275@debbugs.gnu.org; Fri, 07 May 2021 08:52:26 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 0973d9c8; Fri, 7 May 2021 12:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=uYBpXx+/JQdlvu3xi8BG4RmVRaWEocmQiXysgi8TWmo=; b=ScFySq8 517D2LNco98JAOMp5cw+y73GwdQQczQq9PGEU3QIOsn747V3wsOP452xEKpT4gen 7w3d6raRtYhS0ou2SeKYvC/2F1Xb8KTZK92dbpDZ93ry+gW540io+KPjjKyq+24P tYco8LU209/t0aLjhshtQ3aiHeowBkKCozXHjjGJ+3BIflJvNy5+gJ7nEX+RTn+u GVgZUQs5nuRdlwlrLBlCkSvwpW9MlUdxvj+IQLRdDbWZ8UtorSjDq5cvqyxZ173Q gYrPpJNkAbiqrMzJS0GxM9aGUWU6MH/TwUyPC+KKHk+PtoT/akSKri8nOU6tr4Yp 3Tw4vXnxJQLCpMA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id be289fec (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Fri, 7 May 2021 12:52:22 +0000 (UTC) Date: Fri, 07 May 2021 08:52:13 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20210507122218.25615-1-ludo@gnu.org> References: <20210507122218.25615-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----ZYR170UADF0EET6EMPFL7XI05RCZEM" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620391988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=JAvdZbXEYI5GUf753zRGOfZc/8kGLJMpJOr2um/h5qk=; b=eWwZGtei0goAYfXpZCdjjz3tuPzQT438+ODrlBXBpP5ck/ncmvgGRqAJEMYROjktGvRLXx ftXCOZfymoKSmUpwp9cVbtRM7GGBlvdLGxsjoCHolr9kLGZZk4FjWHAjvErLBQLnI16OOX Dh3GbUE9KM2DkzYk1k/uDXIUv3Y3Hazqn51cOHh+FtZyQct38uMRftAwHhYiPeBjpMmW6+ Kt1Z5WULWrDNE5zZrZDKnu8NdGuKvkKWpM2MihOYrwlaq695PTDg8PMy2hH0DoWmdpQo91 DVUwirkorqVrBP36pEUG3dG+1NhkxvSWOeTpSfHtcufEb7vFyPgyvih4Onq95w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620391988; a=rsa-sha256; cv=none; b=CNaaalIHEDnwA+4QrFS2deAIo1kPmRZl8P04RQ3cNF6vfUMQvs27SXJm0hc8r4585W3Jg6 g8wTR28XbxJ7sR3GOHN8dxPU3kE+Cx31aKIafD3Ew2iBPS1dtc9O/HzrjPgSklmrSkQZJA zKmseZHj/EniHzS2wYkV1PtupqS6VwXkVtF6v4A3JhnKlnW0VxxI/PsCRreMJssRkP6efy 3EgvPBtCzFs8+9KRiqq8JgC2MhR2/FI3WMhmqSGJFf0LUvh+I2V7cJ6briUM7mVgJdXBK7 qbJ6XmqPlAgDtDkSPeER4nZqsoFOZYPoukEB+I2kQPE6BN68MtCTrBZUBYS21g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="ScFySq8 "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.15 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="ScFySq8 "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 9CEAB1B402 X-Spam-Score: 0.15 X-Migadu-Scanner: scn0.migadu.com X-TUID: O4axo6Zh2qbb ------ZYR170UADF0EET6EMPFL7XI05RCZEM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM, thanks ! Le 7 mai 2021 08:22:18 GMT-04:00, "Ludovic Court=C3=A8s" = a =C3=A9crit : >From: Ludovic Court=C3=A8s > >Currently gcc:lib does not include libiberty so this change restores >the >initial intent=2E > >* gnu/packages/ocaml=2Escm (ocaml-4=2E11)[inputs]: Replace "gcc:lib" by >"libiberty"=2E >--- > gnu/packages/ocaml=2Escm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >Hi there! > >I noticed that =E2=80=9Cguix graph ocaml=E2=80=9D looked weird; this chan= ge clarifies >the original intent=2E In fact, the addition of gcc:lib was useless >AFAICS: > >--8<---------------cut here---------------start------------->8--- >$ guix build -e '(@@ (gnu packages commencement) gcc-final)' >/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-lib >/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7=2E5=2E0 >$ ls >/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-lib/lib/*ibert* >ls: ne eblas atingi >'/gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-lib/lib/*ibert= *': >Dosiero a=C5=AD dosierujo ne ekzistas >--8<---------------cut here---------------end--------------->8--- > >With this change I see that libiberty is indeed used while building >ocaml@4=2E11: > >--8<---------------cut here---------------start------------->8--- >=2E=2E/boot/ocamlrun =2E=2E/boot/ocamlc -g -nostdlib -I =2E=2E/boot -use-= prims >=2E=2E/runtime/primitives -I =2E=2E -c -absname -w +a-4-9-41-42-44-45-48 >-strict-sequence -warn-error A -principal -safe-string -strict-formats >-bin-annot -I =2E=2E/utils -I =2E=2E/parsing -I =2E=2E/typing -I =2E=2E/b= ytecomp -I >=2E=2E/middle_end -I =2E=2E/middle_end/closure -I =2E=2E/middle_end/flamb= da -I >=2E=2E/middle_end/flambda/base_types -I =2E=2E/driver -I =2E=2E/toplevel = -I >=2E=2E/file_formats -I =2E=2E/lambda - opnames=2Eml >gcc -O2 -fno-strict-aliasing -fwrapv -Wall >-Wdeclaration-after-statement -fno-common -fexcess-precision=3Dstandard >-fno-tree-vrp -ffunction-sections -o objinfo_helper objinfo_helper=2Eo >-lbfd -ldl -liberty -lz >--8<---------------cut here---------------end--------------->8--- > >There=E2=80=99s no =E2=80=98-liberty=E2=80=99 in the build log of 4=2E09 = though=2E > >According to =E2=80=98guix refresh -l ocaml ocaml@4=2E09=E2=80=99, this c= hange is OK >for =E2=80=98master=E2=80=99=2E > >Thoughts? > >Ludo=E2=80=99=2E > >diff --git a/gnu/packages/ocaml=2Escm b/gnu/packages/ocaml=2Escm >index 427ea38ccc=2E=2E272f5bf268 100644 >--- a/gnu/packages/ocaml=2Escm >+++ b/gnu/packages/ocaml=2Escm >@@ -200,8 +200,7 @@ This package produces a native @command{ocamlc} and >a bytecode @command{ocamllex > ("pkg-config" ,pkg-config))) > (inputs > `(("libx11" ,libx11) >- ;; For libiberty, needed for objdump support=2E >- ("gcc:lib" ,(canonical-package gcc) "lib") >+ ("libiberty" ,libiberty) ;needed for objdump >support >("zlib" ,zlib))) ;also needed for objdump support > (arguments > `(#:phases >--=20 >2=2E31=2E1 ------ZYR170UADF0EET6EMPFL7XI05RCZEM Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM, thanks !

L= e 7 mai 2021 08:22:18 GMT-04:00, "Ludovic Court=C3=A8s" <ludo@gnu=2Eorg&= gt; a =C3=A9crit :
From: Ludovic Court=C3=A8s <ludovic=2Ecourtes@inr=
ia=2Efr>

Currently gcc:lib does not include libiberty so this cha=
nge restores the
initial intent=2E

* gnu/packages/ocaml=2Escm (oc=
aml-4=2E11)[inputs]: Replace "gcc:lib" by
"libiberty"=2E
 gnu/package=
s/ocaml=2Escm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Hi there!

I noticed that =E2=80=9Cguix graph ocaml=E2=80=9D loo=
ked weird; this change clarifies
the original intent=2E  In fact, the ad=
dition of gcc:lib was useless AFAICS:

--8<---------------cut here=
---------------start------------->8---
$ guix build -e '(@@ (gnu pack=
ages commencement) gcc-final)'
/gnu/store/01b4w3m6mp55y531kyi1g8shh722kw=
qm-gcc-7=2E5=2E0-lib
/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7=
=2E5=2E0
$ ls /gnu/store/01b4w3m6mp55y531kyi1g8shh722kwqm-gcc-7=2E5=2E0-=
lib/lib/*ibert*
ls: ne eblas atingi '/gnu/store/01b4w3m6mp55y531kyi1g8sh=
h722kwqm-gcc-7=2E5=2E0-lib/lib/*ibert*': Dosiero a=C5=AD dosierujo ne ekzis=
tas
--8<---------------cut here---------------end--------------->8=
---

With this change I see that libiberty is indeed used while build=
ing
ocaml@4=2E11:

--8<---------------cut here---------------st=
art------------->8---
=2E=2E/boot/ocamlrun =2E=2E/boot/ocamlc -g -nos=
tdlib -I =2E=2E/boot -use-prims =2E=2E/runtime/primitives -I =2E=2E -c -abs=
name -w +a-4-9-41-42-44-45-48 -strict-sequence -warn-error A -principal -sa=
fe-string -strict-formats -bin-annot -I =2E=2E/utils -I =2E=2E/parsing -I =
=2E=2E/typing -I =2E=2E/bytecomp -I =2E=2E/middle_end -I =2E=2E/middle_end/=
closure -I =2E=2E/middle_end/flambda -I =2E=2E/middle_end/flambda/base_type=
s -I =2E=2E/driver -I =2E=2E/toplevel -I =2E=2E/file_formats -I =2E=2E/lamb=
da - opnames=2Eml
gcc  -O2 -fno-strict-aliasing -fwrapv -Wall -Wdeclarat=
ion-after-statement -fno-common -fexcess-precision=3Dstandard -fno-tree-vrp=
 -ffunction-sections -o objinfo_helper objinfo_helper=2Eo -lbfd -ldl  -libe=
rty -lz
--8<---------------cut here---------------end---------------&=
gt;8---

There=E2=80=99s no =E2=80=98-liberty=E2=80=99 in the build l=
og of 4=2E09 though=2E

According to =E2=80=98guix refresh -l ocaml o=
caml@4=2E09=E2=80=99, this change is OK
for =E2=80=98master=E2=80=99=2E<=
br>
Thoughts?

Ludo=E2=80=99=2E

diff --git a/gnu/packages/o=
caml=2Escm b/gnu/packages/ocaml=2Escm
index 427ea38ccc=2E=2E272f5bf268 1=
00644
--- a/gnu/packages/ocaml=2Escm
+++ b/gnu/packages/ocaml=2Escm@@ -200,8 +200,7 @@ This package produces a native @command{ocamlc} and a=
 bytecode @command{ocamllex
        ("pkg-config" ,pkg-config)))
    =
 (inputs
      `(("libx11" ,libx11)
-       ;; For libiberty, needed =
for objdump support=2E
-       ("gcc:lib" ,(canonical-package gcc) "lib"=
)
+       ("libiberty" ,libiberty)               ;needed for objdump sup=
port
        ("zlib" ,zlib)))                       ;also needed for obj=
dump support
     (arguments
      `(#:phases
------ZYR170UADF0EET6EMPFL7XI05RCZEM--