unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: John Kehayias via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Andrew Whatson <whatson@gmail.com>, 49957-done@debbugs.gnu.org
Subject: [bug#49957] [PATCH] gnu: p11-kit: Fix certificate errors from flatpak apps
Date: Mon, 25 Oct 2021 19:33:49 +0000	[thread overview]
Message-ID: <Br6tZRqMBEAbSgh7nqcJkIgiin-ogy54r81SQ1EaTl5sO4xycbqNWVb46anlntbNcswp7lvUq9k0brr-tRdEkstvAdKRzO8sjw6dUSIsW4I=@protonmail.com> (raw)
In-Reply-To: <87h7d4kjdl.fsf@gnu.org>

Hi Ludo’ and Andrew,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Monday, October 25th, 2021 at 3:13 PM, Ludovic Courtès <ludo@gnu.org> wrote:

> Hi,
>
> Andrew Whatson whatson@gmail.com skribis:
>
> > Flatpak has a soft dependency on p11-kit, which was configured without
> > knowledge of the system-wide CA certificate store. This caused some
> > flatpak apps to fail with ERR_CERT_AUTHORITY_INVALID errors.
> >
> > -   gnu/packages/tls.scm (p11-kit): Configure with
> >     /etc/ssl/certs/ca-certificates.crt as a trusted path.
>
> I pushed a similar fix on ‘master’ based on John’s patch as
> b4d29851e412c6f4fea5b2d98160258b9768dee3.
>
> We might as well update the default p11-kit though? (Somehow I was
> assuming it had many dependents, but it only has 80+.)
>

Flatpak's dependency doesn't show up on a guix refresh --list-dependents p11-kit, as it comes through some other package somehow (I never looked how exactly). But I guess that is more "using" than needing to build against? Wondering if there are some hidden runtime cases to look out for. (Probably more relevant when thinking of changing that configure flag?)

For this bug, the fixes that I wrote did need a cleaning out of previous Flatpaks (checking how you launch Flatpak apps as our previous version put the full store path in .desktop files) as p11-kit gets started in some indirect way. I think via D-Bus and its portal, but the system p11-kit could be used instead of the fixed version. I made sure to remove previous Flatpak installs from my profile and did a restart to be sure. Noting here for completeness.

John




  reply	other threads:[~2021-10-25 19:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 14:14 [bug#49957] [PATCH] gnu: p11-kit: Fix certificate errors from flatpak apps Andrew Whatson
2021-09-28  2:26 ` John Kehayias via Guix-patches via
2021-09-28  5:07   ` John Kehayias via Guix-patches via
2021-10-25 19:13 ` bug#49957: " Ludovic Courtès
2021-10-25 19:33   ` John Kehayias via Guix-patches via [this message]
2021-10-27 14:27     ` [bug#49957] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='Br6tZRqMBEAbSgh7nqcJkIgiin-ogy54r81SQ1EaTl5sO4xycbqNWVb46anlntbNcswp7lvUq9k0brr-tRdEkstvAdKRzO8sjw6dUSIsW4I=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=49957-done@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    --cc=ludo@gnu.org \
    --cc=whatson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).