[bug#51587] [PATCH 0/3] Add rss2email.

[bug#51587] [PATCH 0/3] Add rss2email.

[Morgan.J.Smith]

[PATCH 1/3] gnu: Add python-sgmllib3k.
[PATCH 2/3] gnu: python-feedparser: Add input
[PATCH 3/3] gnu: Add rss2email.

[bug#51587] [PATCH 1/3] gnu: Add python-sgmllib3k.

[Morgan.J.Smith]

From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/python-xyz.scm (python-sgmllib3k): New variable.
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 32d6b403d4..d2aca67aca 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -27643,3 +27643,26 @@ (define-public python-ijson
      "Ijson is an iterative JSON parser with standard Python iterator
 interfaces.")
     (license license:bsd-3)))
+
+(define-public python-sgmllib3k
+  (package
+    (name "python-sgmllib3k")
+    (version "1.0.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "sgmllib3k" version))
+        (sha256
+          (base32 "1s8jm3dgqabgf8x96931scji679qkhvczlv3qld4qxpsicfgns3q"))))
+    (build-system python-build-system)
+    ;; Requires a test.html input that is not supplied
+    (arguments
+     `(#:tests? #f))
+    (home-page "https://pypi.org/project/sgmllib3k/")
+    ;; Actual homepage seems to be down
+    ;; (home-page "https://hg.hardcoded.net/sgmllib")
+    (synopsis "Python 3 port of sgmllib")
+    (description "A quick, dirty, unmaintained port of sgmllib to Python 3.
+It is used parse text files formatted in @acronym{SGML,Standard Generalized
+Mark-up Language}.")
+    (license license:bsd-3)))
-- 
2.33.1

[bug#51587] [PATCH 1/3] gnu: Add python-sgmllib3k.

[Vinicius Monego]

Hi,

I added this patch in 51314, and now I also noticed that it was
submitted even earlier in 50853. Maybe we should review that one first?

Em qua, 2021-11-03 às 12:37 -0400, Morgan.J.Smith@outlook.com escreveu:
> From: Morgan Smith <Morgan.J.Smith@outlook.com>
> 
> * gnu/packages/python-xyz.scm (python-sgmllib3k): New variable.
> ---
>  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-
> xyz.scm
> index 32d6b403d4..d2aca67aca 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -27643,3 +27643,26 @@ (define-public python-ijson
>       "Ijson is an iterative JSON parser with standard Python
> iterator
>  interfaces.")
>      (license license:bsd-3)))
> +
> +(define-public python-sgmllib3k
> +  (package
> +    (name "python-sgmllib3k")
> +    (version "1.0.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "sgmllib3k" version))
> +        (sha256
> +          (base32
> "1s8jm3dgqabgf8x96931scji679qkhvczlv3qld4qxpsicfgns3q"))))

Indentation nitpick here in the source.

> +    (build-system python-build-system)
> +    ;; Requires a test.html input that is not supplied
> +    (arguments
> +     `(#:tests? #f))
> +    (home-page "https://pypi.org/project/sgmllib3k/")
> +    ;; Actual homepage seems to be down
> +    ;; (home-page "https://hg.hardcoded.net/sgmllib")
> +    (synopsis "Python 3 port of sgmllib")
> +    (description "A quick, dirty, unmaintained port of sgmllib to
> Python 3.
> +It is used parse text files formatted in @acronym{SGML,Standard
> Generalized
> +Mark-up Language}.")

I think this description doesn't qualify as a full sentence.

> +    (license license:bsd-3)))

[bug#51587] [PATCH v2 0/3] gnu: Add rss2email.

[Morgan.J.Smith]

Thanks for the review!

I looked over both previously submitted sgmllib3k packages and I think my patch is the best as the description mentions SGML.

I fixed the sgmllib3k indentation issue and added a missing word to the description.

For the rss2email patch:
- I added my copyright to mail.scm
- I removed the inputs and outputs from the check phase
- Made the input not propagated. It is indeed a binary that seems to still work this way.
- Fixed that comment
- Slightly modified the description but I'm honestly not sure what the issue is. I'll admit I'm not very good at english so if you could just change it how you see fit that would make me happy


[PATCH v2 1/3] gnu: Add python-sgmllib3k.
[PATCH v2 2/3] gnu: python-feedparser: Add input
[PATCH v2 3/3] gnu: Add rss2email.