[bug#55518] [PATCH] gnu: Add python-gatt.

[bug#55518] [PATCH] gnu: Add python-gatt.

[Wamm K. D]

---
This isn't the end-goal package to add but a dependency.

'Trying to add Siglo so sending this one, first; Siglo will follow.

 gnu/packages/python-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5094ef068c..ee7850b518 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31177,3 +31177,32 @@ (define-public python-deepmerge
      "The @code{deep-merge} Python library provides a toolset to deeply merge
 nested data structures in Python like lists and dictionaries.")
     (license license:expat)))
+
+(define python-gatt
+  (package
+    (name "python-gatt")
+    (version "0.2.7")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "gatt" version))
+              (sha256 (base32
+                       "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
+    (inputs (list python-dbus python-pygobject))
+    (build-system python-build-system)
+    (home-page "https://github.com/getsenic/gatt-python")
+    (synopsis "Bluetooth GATT SDK for Python")
+    (description "The Bluetooth GATT SDK for Python helps you implementing and
+communicating with any Bluetooth Low Energy device that has a GATT profile.  It
+supports:
+@itemize @bullet
+@item Discovering nearby Bluetooth Low Energy devices
+@item Connecting and disconnecting devices
+@item Implementing your custom GATT profile
+@item Accessing all GATT services
+@item Accessing all GATT characteristics
+@item Reading characteristic values
+@item Writing characteristic values
+@item Subscribing for characteristic value change notifications
+@end itemize
+Currently Linux is the only platform supported by this library.")
+    (license license:expat)))
-- 
2.36.0

[bug#55518] [PATCH] gnu: Add python-gatt.

[Jack Hill]

On Thu, 19 May 2022, Wamm K. D wrote:

> ---
> This isn't the end-goal package to add but a dependency.
>
> 'Trying to add Siglo so sending this one, first; Siglo will follow.
>
> gnu/packages/python-xyz.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 5094ef068c..ee7850b518 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -31177,3 +31177,32 @@ (define-public python-deepmerge
>      "The @code{deep-merge} Python library provides a toolset to deeply merge
> nested data structures in Python like lists and dictionaries.")
>     (license license:expat)))
> +
> +(define python-gatt
> +  (package
> +    (name "python-gatt")
> +    (version "0.2.7")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "gatt" version))
> +              (sha256 (base32
> +                       "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
> +    (inputs (list python-dbus python-pygobject))
> +    (build-system python-build-system)
> +    (home-page "https://github.com/getsenic/gatt-python")
> +    (synopsis "Bluetooth GATT SDK for Python")
> +    (description "The Bluetooth GATT SDK for Python helps you implementing and
> +communicating with any Bluetooth Low Energy device that has a GATT profile.  It
> +supports:
> +@itemize @bullet
> +@item Discovering nearby Bluetooth Low Energy devices
> +@item Connecting and disconnecting devices
> +@item Implementing your custom GATT profile
> +@item Accessing all GATT services
> +@item Accessing all GATT characteristics
> +@item Reading characteristic values
> +@item Writing characteristic values
> +@item Subscribing for characteristic value change notifications
> +@end itemize
> +Currently Linux is the only platform supported by this library.")
> +    (license license:expat)))

Cool! I haven't reviewed the package, but it looks straight forward, which 
is promising. However reading this description made me realize that I 
don't know what GATT means. Would it make sense to define it in the 
description (perhaps using texinfo's @acronym syntax)?

Best,
Jack

[bug#55518] [PATCH] gnu: Add python-gatt.

[Wamm K. D]

---
Here we go; would this work? Do I need to include what the acronym means in
every instance of @acronym or does doing so for just the first instance work?

 gnu/packages/python-xyz.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5094ef068c..dcf1bfa9d3 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31177,3 +31177,33 @@ (define-public python-deepmerge
      "The @code{deep-merge} Python library provides a toolset to deeply merge
 nested data structures in Python like lists and dictionaries.")
     (license license:expat)))
+
+(define python-gatt
+  (package
+    (name "python-gatt")
+    (version "0.2.7")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "gatt" version))
+              (sha256 (base32
+                       "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
+    (inputs (list python-dbus python-pygobject))
+    (build-system python-build-system)
+    (home-page "https://github.com/getsenic/gatt-python")
+    (synopsis "Bluetooth GATT SDK for Python")
+    (description "The Bluetooth @acronym{GATT, Generic ATTribute Profile}
+@acronym{SDK, Software Development Kit} for Python helps you implementing and
+communicating with any Bluetooth Low Energy device that has a @acronym{GATT}
+profile.  It supports:
+@itemize @bullet
+@item Discovering nearby Bluetooth Low Energy devices
+@item Connecting and disconnecting devices
+@item Implementing your custom @acronym{GATT} profile
+@item Accessing all @acronym{GATT} services
+@item Accessing all @acronym{GATT} characteristics
+@item Reading characteristic values
+@item Writing characteristic values
+@item Subscribing for characteristic value change notifications
+@end itemize
+Currently, Linux is the only platform supported by this library.")
+    (license license:expat)))
-- 
2.36.0

[bug#55518] [PATCH] gnu: Add python-gatt.

[Tobias Geerinckx-Rice via Guix-patches via]

On 19 May 2022 06:05:22 UTC, "Wamm K. D" <jaft.r@outlook.com> wrote:
>---
>Do I need to include what the acronym means in
>every instance of @acronym or does doing so for just the first instance work?

Just the first occurence in each description.  At least how Guix renders Texinfo (simple & stupid), it would repeat the meaning in brackets every single time.  Not what you want.



Kind regards,

T G-R

Sent on the go.  Excuse or enjoy my brevity.

[bug#55518] [PATCH] gnu: Add python-gatt.

[Jaft]

> On Thursday, May 19, 2022, 08:24:43 AM CDT, Tobias Geerinckx-Rice <me@tobias.gr> wrote: 
>
>
>
>
>
> On 19 May 2022 06:05:22 UTC, "Wamm K. D" <jaft.r@outlook.com> wrote:
>
> >---
> >Do I need to include what the acronym means in
> >every instance of @acronym or does doing so for just the first instance work?
>
>
> Just the first occurence in each description.  At least how Guix renders Texinfo (simple & stupid), it would repeat the meaning in brackets every single time.  Not what you want.

Gotcha; that's what I was figuring but wanted to double check. Thanks a ton for confirming!

Then I think the necessary changes have been made, Jack; lemme know if there's any other adjustments I ought to make.

bug#55518: [PATCH] gnu: Add python-gatt.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

Hi,

I added a commit log and applied with the changes below, as suggested by
Tobias (for the description).

The inputs are propagated because, for instance, the code reads:

--8<---------------cut here---------------start------------->8---
try:
    import dbus
    import dbus.mainloop.glib
except ImportError:
    import sys
    print("Module 'dbus' not found")
    print("Please run: sudo apt-get install python3-dbus")
    print("See also: https://github.com/getsenic/gatt-python#installing-gatt-sdk-for-python")
    sys.exit(1)
--8<---------------cut here---------------end--------------->8---

Thus, if you install python-gatt in a profile, python-dbus should be
propagated as well so it “just works”.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2059 bytes --]

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d706906a9d..fe1896efca 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31806,32 +31806,35 @@ (define-public python-srt
 composing subtitles in the SRT file format.")
     (license license:expat)))
 
-(define python-gatt
+(define-public python-gatt
   (package
     (name "python-gatt")
     (version "0.2.7")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "gatt" version))
-              (sha256 (base32
-                       "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
-    (inputs (list python-dbus python-pygobject))
+              (sha256
+               (base32
+                "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
+    (propagated-inputs (list python-dbus python-pygobject))
     (build-system python-build-system)
     (home-page "https://github.com/getsenic/gatt-python")
     (synopsis "Bluetooth GATT SDK for Python")
     (description "The Bluetooth @acronym{GATT, Generic ATTribute Profile}
-@acronym{SDK, Software Development Kit} for Python helps you implementing and
-communicating with any Bluetooth Low Energy device that has a @acronym{GATT}
+@acronym{SDK, Software Development Kit} for Python helps you implement and
+communicate with any Bluetooth Low Energy device that has a GATT
 profile.  It supports:
+
 @itemize @bullet
 @item Discovering nearby Bluetooth Low Energy devices
 @item Connecting and disconnecting devices
-@item Implementing your custom @acronym{GATT} profile
-@item Accessing all @acronym{GATT} services
-@item Accessing all @acronym{GATT} characteristics
+@item Implementing your custom GATT profile
+@item Accessing all GATT services
+@item Accessing all GATT characteristics
 @item Reading characteristic values
 @item Writing characteristic values
 @item Subscribing for characteristic value change notifications
 @end itemize
+
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))

[bug#55518] [PATCH] gnu: Add python-gatt.

[Wamm K. D.]

On Fri. (May 27, 2022) at 06:02:45 PM -04, Ludovic Courtès <ludo@gnu.org> wrote:
> Hi,
>
> I added a commit log and applied with the changes below, as suggested by
> Tobias (for the description).

…ah; heh, that was definitely not how I'd read his suggestion. I thought
~@acronym~ was used in every case, with the full acronym spelled out
only in first case, so thought I'd gotten it right in my last
patch. Sorry about that.

> The inputs are propagated because, for instance, the code reads:
>
> try:
>     import dbus
>     import dbus.mainloop.glib
> except ImportError:
>     import sys
>     print("Module 'dbus' not found")
>     print("Please run: sudo apt-get install python3-dbus")
>     print("See also: https://github.com/getsenic/gatt-python#installing-gatt-sdk-for-python")
>     sys.exit(1)
>
> Thus, if you install python-gatt in a profile, python-dbus should be
> propagated as well so it “just works”.

Mmm; O. K. That makes sense. Thanks a ton for explaining, Ludo; it's
super appreciated.