From: Wamm K. D. <jaft.r@outlook.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Jean Pierre De Jesus DIAZ <me@jeandudey.tech>,
"Wamm K. D" <jaft.r@outlook.com>,
"56960@debbugs.gnu.org" <56960@debbugs.gnu.org>
Subject: [bug#56960] [PATCH] * gnu: Add siglo.
Date: Sun, 04 Sep 2022 17:27:52 -0500 [thread overview]
Message-ID: <BY5PR07MB7029ABFD1CD3F672E69B5028997C9@BY5PR07MB7029.namprd07.prod.outlook.com> (raw)
In-Reply-To: <87k06o9m89.fsf_-_@gnu.org>
Hey, Ludo.
I will; my spouse recently had surgery so my time's been a tad bit more stretched from other activities.
I'll make sure to get a response, though.
Wamm
On Wed, 31 Aug 2022 15:44:46 -0500,
Ludovic Courtès wrote:
>
> Hi Wamm,
>
> Could you send an updated patch taking into accounts the comments made
> by Jean Pierre and Maxime?
>
> Thanks in advance!
>
> Ludo’.
>
> Jean Pierre De Jesus DIAZ <me@jeandudey.tech> skribis:
>
> > Hello,
> >
> > Just a quick review.
> >
> >>+ (url (string-append "https://github.com/alexr4535/" name "/"))
> >
> > `name' is discouraged from being used on the source URL.
> >
> > If the package name changes, the URL does too. Can't recall where I saw it if
> > on the documentation or IRC.
> >
> >>+ (arguments
> >>+ `(#:glib-or-gtk? #t
> >>+ #:phases
> >>+ (modify-phases %standard-phases
> >
> > You'll probably want to use a list (argument (list ...)) instead of
> > quasi-quoting, and also, use G-Expressions, see (guix)G-Expressions:
> >
> > https://guix.gnu.org/manual/en/html_node/G_002dExpressions.html
> >
> > As the method used for the package is being phased out.
> >
> > For example:
> >
> > (arguments
> > (list #:glib-or-gtk? #t
> > #:phases
> > #~(modify-phases %standard-phases
> > ...)))
> >
> >>+ (wrap-program (string-append (assoc-ref outputs "out")
> >>+ "/bin/siglo")
> >
> > After using G-Expressions, this can be simplified to:
> >
> > (wrap-program (string-append #$output "/bin/siglo")
> > ...)
> >
> >>+ (synopsis "GTK app to sync InfiniTime watch with PinePhone")
> >
> > GTK is an implementation detail, no need to be specified, and if necessary,
> > better suited for the description.
> >
> > See (guix)Synopses and Descriptions:
> >
> > https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
> >
> > For example, variations could include:
> >
> > * "Application to synchronize InfiniTime with PinePhone"
> > * "Synchronize InifniTime with PinePhone"
> > * "Smartwatch synchronization application"
> > * etc.
> >
> > Keep in mind that synopsis != description. Probably someone with more experience
> > than me could correct me on this topic.
> >
> >>+ (description "@code{siglo} is a graphical tool to flash InfiniTime firmware to
> >>+watches running the InfiniTime operating system, via bluetooth.
> >
> > flash -> update (non-technical term).
> > watches -> PineTime watches (or PineTime smartwatches).
> > bluetooth > Bluetooth.
> >
> >>+Users can also sync the time of their watch to the time of the device running
> >>+@code{siglo} as well as check the battery charge of their watch or what version
> >>+of firmware their watch is running.
> >
> > sync -> synchronize.
> >
> > Maybe @itemize or @enumerate could be used to list the features provided, like so:
> >
> > Siglo (or @code{siglo}) provides the following features:
> >
> > @itemize
> > @item Retrieve the version of the InfiniTime firmware running.
> > @item Check the battery charge.
> > @item Synchronize the time.
> > @end itemize
> >
> >>--- a/gnu/packages/flashing-tools.scm
> >>+++ b/gnu/packages/flashing-tools.scm
> >
> > Not entirely sure if this belongs in this category. Or if there's another applicable.
> >
> > —
> > Jean-Pierre De Jesus DIAZ
next prev parent reply other threads:[~2022-09-04 22:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 20:23 [bug#56960] [PATCH] * gnu: Add siglo Wamm K. D
2022-08-11 11:56 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-31 20:44 ` Ludovic Courtès
2022-09-04 22:27 ` Wamm K. D. [this message]
2022-08-11 19:00 ` Maxime Devos
2022-09-26 18:33 ` Wamm K. D.
2023-03-12 2:02 ` Jaft
2023-03-16 10:19 ` Ludovic Courtès
2023-03-17 16:03 ` Jaft
[not found] ` <887796113.1601186.1679068986036@mail.yahoo.com>
2023-05-16 17:19 ` Jaft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR07MB7029ABFD1CD3F672E69B5028997C9@BY5PR07MB7029.namprd07.prod.outlook.com \
--to=jaft.r@outlook.com \
--cc=56960@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=me@jeandudey.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).