unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ekaitz Zarraga <ekaitz@elenq.tech>
To: 47467@debbugs.gnu.org
Subject: [bug#47467] [PATCH]: Fix Blender missing Voxel Remesher
Date: Mon, 29 Mar 2021 14:17:20 +0000	[thread overview]
Message-ID: <BNJM6sgD3qkQEnMpN5ovpwdbPTX2yKVDoJDsFe1MjZRD3tzcxc_1IY5ynTIwFBiFmOpa_9_dRv0h56lq4AXiB94eKAK4nwu9HC801em-EsM=@elenq.tech> (raw)

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

Hi,

According to bug#47463[^1], Blender is missing a dependency that
doesn't allow to run the Voxel Remesher.

This series of patches solve that.

I have a comment on the first one. I'm not sure if I did it right.

I don't see a better way to set the `rpath` correcty. It should
find the lib by itself but the package has an executable as
ouput that doesn't find the library the package itself generates.
Removing the extra phase I added shows the RPATH is set to `lib`
instead to the absolute path of the library so the runpath check
fails to execute.

This is the best way I found to solve that but I'm sure whoever
that gets this patch knows a better way to handle that.

I tested Blender with this and it runs the Voxel Remesher as
expected.

Please, don't hesitate to send me any comment.

Thanks!


[^1]: https://lists.gnu.org/archive/html/bug-guix/2021-03/msg00647.html

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-openvdb.patch --]
[-- Type: text/x-patch; name=0001-gnu-Add-openvdb.patch, Size: 2486 bytes --]

From 9a3bec5d8c19351d106d471a722e7b3d3d0350c0 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Mon, 29 Mar 2021 16:04:23 +0200
Subject: [PATCH 1/2] gnu: Add openvdb.

* gnu/packages/graphics.scm (openvdb): New variable.
---
 gnu/packages/graphics.scm | 44 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 4a301d387a..b4df9f5c04 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -463,6 +463,50 @@ Embree is meant to increase performance of photo-realistic rendering
 applications.")
     (license license:asl2.0)))
 
+
+(define-public openvdb
+  (package
+      (name "openvdb")
+      (version "8.0.1")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                       (url "https://github.com/AcademySoftwareFoundation/openvdb/")
+                       (commit (string-append "v" version))
+                       (recursive? #t)))
+                (file-name (git-file-name name version))
+                (sha256
+                  (base32 "0qzx6l5c183k6j9zki31gg9aixf5s1j46wdi7wr1h3bz7k53syg9"))))
+      (arguments
+        `(#:phases
+          (modify-phases %standard-phases
+            (add-before 'configure 'fix-runpath
+              (lambda* (#:key outputs #:allow-other-keys)
+                (setenv
+                  "LDFLAGS"
+                  (string-append "-Wl,-rpath=" (assoc-ref outputs "out") "/lib/"))
+                #t)))))
+      (build-system cmake-build-system)
+      (native-inputs
+        `(("unzip"    ,unzip)
+          ("pkg-config",pkg-config)))
+      (inputs
+        `(("openexr"  ,openexr)
+          ("boost"    ,boost)
+          ("jemalloc" ,jemalloc)
+          ("c-blosc"  ,c-blosc)
+          ("ilmbase"  ,ilmbase)
+          ("tbb"      ,tbb)))
+      (home-page "https://www.openvdb.org/")
+      (synopsis "Sparse volume data structure and tools")
+      (description "OpenVDB is an open source C++ library comprising a novel
+hierarchical data structure and a large suite of tools for the efficient
+storage and manipulation of sparse volumetric data discretized on
+three-dimensional grids.  It was developed by DreamWorks Animation for use in
+volumetric applications typically encountered in feature film production.")
+      (license license:mpl2.0)))
+
+
 (define-public blender
   (package
     (name "blender")
-- 
2.31.0


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: 0002-gnu-blender-Update-dependencies.patch --]
[-- Type: text/x-patch; name=0002-gnu-blender-Update-dependencies.patch, Size: 1298 bytes --]

From 630ebdeec1b8524d09c811ac93dbbe46d31daa45 Mon Sep 17 00:00:00 2001
From: Ekaitz Zarraga <ekaitz@elenq.tech>
Date: Mon, 29 Mar 2021 16:05:04 +0200
Subject: [PATCH 2/2] gnu: blender: Update dependencies

    * gnu/packages/graphics.scm (blender): Add dependencies and flags
---
 gnu/packages/graphics.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index b4df9f5c04..ddf6a6c2ba 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -534,6 +534,8 @@ volumetric applications typically encountered in feature film production.")
                "-DWITH_INSTALL_PORTABLE=OFF"
                "-DWITH_JACK=ON"
                "-DWITH_MOD_OCEANSIM=ON"
+               "-DWITH_OPENVDB=ON"
+               "-DWITH_TBB=ON"
                "-DWITH_OPENSUBDIV=ON"
                "-DWITH_PYTHON_INSTALL=OFF"
                (string-append "-DPYTHON_LIBRARY=python" ,python-version)
@@ -589,6 +591,8 @@ volumetric applications typically encountered in feature film production.")
        ("pugixml" ,pugixml)
        ("python" ,python)
        ("python-numpy" ,python-numpy)
+       ("openvdb" ,openvdb)
+       ("libxxf86vm" ,libxxf86vm)
        ("tbb" ,tbb)
        ("zlib" ,zlib)
        ("embree" ,embree)))
-- 
2.31.0


             reply	other threads:[~2021-03-29 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 14:17 Ekaitz Zarraga [this message]
2021-03-29 18:17 ` [bug#47467] [PATCH]: Fix Blender missing Voxel Remesher (Follows) Ekaitz Zarraga
2021-04-12 14:14 ` [bug#47467] [PATCH]: Fix Blender missing Voxel Remesher Ricardo Wurmus
2021-04-21 15:36 ` Ekaitz Zarraga
2021-04-21 16:03   ` Ekaitz Zarraga
2021-04-21 16:19     ` bug#47467: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BNJM6sgD3qkQEnMpN5ovpwdbPTX2yKVDoJDsFe1MjZRD3tzcxc_1IY5ynTIwFBiFmOpa_9_dRv0h56lq4AXiB94eKAK4nwu9HC801em-EsM=@elenq.tech' \
    --to=ekaitz@elenq.tech \
    --cc=47467@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).