unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Wamm K. D." <jaft.r@outlook.com>
To: Liliana Marie Prikler <liliana.prikler@ist.tugraz.at>
Cc: 55774@debbugs.gnu.org
Subject: [bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work.
Date: Fri, 03 Jun 2022 08:13:00 -0500	[thread overview]
Message-ID: <BN8PR07MB7027D5E62AE9D9E4CB9692C199A19@BN8PR07MB7027.namprd07.prod.outlook.com> (raw)
In-Reply-To: <5d389f5061f937d238b758b23c61c3621a519b9c.camel@ist.tugraz.at> (Liliana Marie Prikler's message of "Fri, 03 Jun 2022 08:04:10 +0200")

On Fri. (Jun 03, 2022) at 08:04:10 AM +02, Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> wrote:
> Am Freitag, dem 03.06.2022 um 00:02 -0500 schrieb Wamm K. D:
>> * gnu/packages/music.scm (quodlibet): Add dependencies for plugins to
>> work.
> Should be ... (quodlibet)[inputs]: Add ACTUAL_INPUTS...

👍; I'll get that updated.

> YMMV, but it's better for inputs to be sorted alphabetically.  Use line
> comments to demarcate specific features, e.g. 
>   keybinder-3.0 ; keybindings outside of GNOME
>   gtksourceview ; undo, redo, multiline text fields
>   ...
> Don't forget the 79 character limit; when in doubt claim less features.
> If possible, try to line up the comments.

Fair; I'll get those updated, as well. Yeah, I was trying to weigh what
to include vs. not but, due to the installation structure of Guix, you
wouldn't be able to use these features by just installing the
dependencies (leastwise, with just a naïve straightforward install, when
I tried) so I figured they were worth including, from that perspective.

> Also, comments like "musicbrainz plugin needs python-musicbrainz" are
> not as informative as you'd think and can probably be dropped :)

Haha; fair. While I could see repeating "musicbrainz" as being
repetitive, I was figuring it's easy to lose track that the dependency
was present specifically due to a plugin, for future developers who
might work on the package, and was mostly trying to capture it was
plugin-related. Thanks for pointing it out and I'll that adjusted.

I'll try making the updates later tonight; thanks a ton.




  reply	other threads:[~2022-06-03 13:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03  5:02 [bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work Wamm K. D
2022-06-03  6:04 ` Liliana Marie Prikler
2022-06-03 13:13   ` Wamm K. D. [this message]
2022-06-03 13:22     ` Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR07MB7027D5E62AE9D9E4CB9692C199A19@BN8PR07MB7027.namprd07.prod.outlook.com \
    --to=jaft.r@outlook.com \
    --cc=55774@debbugs.gnu.org \
    --cc=liliana.prikler@ist.tugraz.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).