From: Sughosha via Guix-patches via <guix-patches@gnu.org>
To: "rekado@elephly.net" <rekado@elephly.net>
Cc: 56140@debbugs.gnu.org
Subject: [bug#56140] [PATCH v3 0/2] gnu: Add distrho-ports.
Date: Fri, 16 Jun 2023 14:05:03 +0000 [thread overview]
Message-ID: <BL5rIiIpxi3rw9V94VQCh9pKq_ulTAEyDw86DojHzs98ql9GCeJKa7EYA0Pc9IRD88dbtaAEgBwz6JLH5t7NIoAmQnzBNuQpFY5WE9jxRXI=@proton.me> (raw)
In-Reply-To: <o8Acm5cfOaqtnIzq2115gx9xgJ2jE0FcDoyhmSHDnUyYRqrMF8zeNDErpYpVcjmuokpGtGw__RkbqGW5xetv_xl_kkmC88mofx2bh08OU4Q=@proton.me>
Hi Ricardo,
Thanks for reviewing this patch. Following your suggestions made some
improvements.
> > + (native-inputs
> > + (list cmake-minimal
> > + concurrentqueue
> > + nlohmann-json
> > + optional-lite
> > + pkg-config))
>
> Why are these libraries native inputs?
"concurrentqueue", "nlohmann-json" and "optional-lite" were bundled with
the source. I deleted their folders and added them as native-inputs.
> > + ;; Licenses for lv2-ttl-generator, The Function, The Pilgrim,
> > + ;; juce-demo-host and juce-demo-plugin are not declared.
> Then these are nonfree and should be removed.
I found license of lv2-ttl-generator in its upstream and removed plugins
with no license and not included in building.
I also last I improved license definition.
Sughosha (2):
gnu: Add optional-lite.
gnu: Add distrho-ports.
gnu/packages/cpp.scm | 23 ++++++
gnu/packages/music.scm | 154 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 177 insertions(+)
base-commit: 8f0698dde351790e0bc9e905e4cd71902fd55d5f
--
2.40.1
next prev parent reply other threads:[~2023-06-16 14:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 12:36 [bug#56140] [Patches] Add and update music packages Sughosha via Guix-patches via
2022-06-24 8:54 ` [bug#56140] Resending the patches with correcting mistakes Sughosha via Guix-patches via
2022-06-28 7:45 ` [bug#56140] [Patches] Add and update music packages Alice BRENON
2022-06-28 8:30 ` Sughosha via Guix-patches via
2022-06-28 12:40 ` Maxime Devos
2022-07-01 16:04 ` Sughosha via Guix-patches via
2022-07-01 17:29 ` Ricardo Wurmus
2022-07-01 18:05 ` Thorsten Wilms
2023-06-15 16:30 ` [bug#56140] [Patch v2 0/2]: gnu: Add distrho-ports Sughosha via Guix-patches via
2023-06-15 16:32 ` [bug#56140] [Patch v2 1/2]: gnu: Add optional-lite Sughosha via Guix-patches via
2023-06-15 16:34 ` [bug#56140] [Patch v2 2/2]: gnu: Add distrho-ports Sughosha via Guix-patches via
2023-06-15 18:38 ` Ricardo Wurmus
2023-06-16 14:05 ` Sughosha via Guix-patches via [this message]
2023-06-16 14:06 ` [bug#56140] [PATCH v3 1/2] gnu: Add optional-lite Sughosha via Guix-patches via
2023-06-16 14:06 ` [bug#56140] [PATCH v3 2/2] gnu: Add distrho-ports Sughosha via Guix-patches via
2023-06-16 15:02 ` [bug#56140] [PATCH v4 0/2] " Sughosha via Guix-patches via
2023-06-16 15:04 ` [bug#56140] [PATCH v4 2/2] " Sughosha via Guix-patches via
2023-09-02 1:11 ` [bug#56140] Add optional-lite and distrho-ports Vagrant Cascadian
2023-06-16 15:02 ` [bug#56140] [PATCH v4 1/2] gnu: Add optional-lite Sughosha via Guix-patches via
2023-09-02 8:40 ` bug#56140: Add optional-lite and distrho-ports Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BL5rIiIpxi3rw9V94VQCh9pKq_ulTAEyDw86DojHzs98ql9GCeJKa7EYA0Pc9IRD88dbtaAEgBwz6JLH5t7NIoAmQnzBNuQpFY5WE9jxRXI=@proton.me' \
--to=guix-patches@gnu.org \
--cc=56140@debbugs.gnu.org \
--cc=Sughosha@proton.me \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).