From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4P6EAATC4l4hMwAA0tVLHw (envelope-from ) for ; Thu, 11 Jun 2020 23:45:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cEn1NwPC4l6IVwAA1q6Kng (envelope-from ) for ; Thu, 11 Jun 2020 23:45:07 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 641E6940538 for ; Thu, 11 Jun 2020 23:45:07 +0000 (UTC) Received: from localhost ([::1]:52566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjWsb-00075P-Sv for larch@yhetil.org; Thu, 11 Jun 2020 19:45:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjWsY-00075D-DQ for guix-patches@gnu.org; Thu, 11 Jun 2020 19:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjWsY-0002K0-44 for guix-patches@gnu.org; Thu, 11 Jun 2020 19:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjWsY-0005z2-14 for guix-patches@gnu.org; Thu, 11 Jun 2020 19:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41820] [PATCH] file-systems: Add record type for a file system device. Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Jun 2020 23:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41820 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic , Maxim Cournoyer Cc: 41820@debbugs.gnu.org Received: via spool by 41820-submit@debbugs.gnu.org id=B41820.159191905222923 (code B ref 41820); Thu, 11 Jun 2020 23:45:01 +0000 Received: (at 41820) by debbugs.gnu.org; 11 Jun 2020 23:44:12 +0000 Received: from localhost ([127.0.0.1]:38392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjWrj-0005xf-Pw for submit@debbugs.gnu.org; Thu, 11 Jun 2020 19:44:11 -0400 Received: from mx009.vodafonemail.xion.oxcs.net ([153.92.174.39]:28617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjWri-0005xS-IS for 41820@debbugs.gnu.org; Thu, 11 Jun 2020 19:44:11 -0400 Received: from vsmx002.vodafonemail.xion.oxcs.net (unknown [192.168.75.192]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTP id 692726050DB; Thu, 11 Jun 2020 23:44:04 +0000 (UTC) Received: from macbook-pro.kuh-wiese.my-router.de (unknown [145.254.41.74]) by mta-6-out.mta.xion.oxcs.net (Postfix) with ESMTPA id D29356050CF; Thu, 11 Jun 2020 23:43:57 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Stefan In-Reply-To: <87bllqi66g.fsf@gmail.com> Date: Fri, 12 Jun 2020 01:43:57 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <9AAFEFF4-8ACE-4C95-975F-67C3F4FDAF81@vodafonemail.de> <87a72gi4kz.fsf@gmail.com> <1179D890-7D6C-43D8-A286-DA7A0F61D585@vodafonemail.de> <87h7w7cc55.fsf@gnu.org> <92DB8E2B-1CA2-41AE-9265-53C4F5337686@vodafonemail.de> <20200606193721.1e126131@scratchpost.org> <46CD97B3-9994-4AB7-AA7D-4DE39AB7A238@vodafonemail.de> <20200609154400.4c7d2f90@scratchpost.org> <87bllqi66g.fsf@gmail.com> X-Mailer: Apple Mail (2.3124) X-VADE-STATUS: LEGIT X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.99 X-TUID: 0ykNufBhvWbF Hi! Now that the new record is working and seeing the amount of = changes to make this working, I get the impression that this is = unnecessarily complicated. In the end there will be the "--root=3D" option for the kernel, which is = only a plain string. And most of the device record related functions in = the end target to produce a string. And then there is (device-string->file-system-device) in = gnu/build/linux-boot.scm to convert this string back into a device = record. As long as this conversion to and from string is necessary, there is no = real benefit in having different record types for (file-system (device = =E2=80=A6)), it could just be a string. Then there would only be the = need for a simple parser function like (device-string->device-type) to = determine the type of device to be used in places where the type = matters. Bye Stefan