unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: 27250@debbugs.gnu.org, arunisaac@systemreboot.net, nee@cock.li
Subject: bug#27250: [PATCH] gnu: crawl: Update to 0.20.0.
Date: Mon, 05 Jun 2017 11:54:07 -0400	[thread overview]
Message-ID: <B2FCF650-1124-4424-9EBE-4F230BF30E3B@famulari.name> (raw)
In-Reply-To: <92906ae2.AEUAK6w8Z7gAAAAAAAAAAAPHYWoAAAACwQwAAAAAAAW9WABZNWdE@mailjet.com>

Generally, I think it's fine if the patches we include contain whitespace issues.


-------- Original Message --------
From: Arun Isaac <arunisaac@systemreboot.net>
Sent: June 5, 2017 10:14:18 AM EDT
To: nee <nee@cock.li>
Cc: 27250@debbugs.gnu.org
Subject: bug#27250: [PATCH] gnu: crawl: Update to 0.20.0.


Thanks! LGTM. Only one problem: crawl-upgrade-saves.patch seems to have
trailing whitespace, and git is complaining about that. Use `git diff
--check' on your commit to see what I mean. Could you fix this and send
a new patch?

gnu/packages/patches/crawl-upgrade-saves.patch:17: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:32: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:40: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:55: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:63: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:68: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:75: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:81: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:84: trailing whitespace.
++ 
gnu/packages/patches/crawl-upgrade-saves.patch:92: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:100: trailing whitespace.
+  
gnu/packages/patches/crawl-upgrade-saves.patch:111: trailing whitespace.
++ 
gnu/packages/patches/crawl-upgrade-saves.patch:115: trailing whitespace.
+  

  reply	other threads:[~2017-06-05 15:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 13:31 bug#27250: [PATCH] gnu: crawl: Update to 0.20.0 nee
2017-06-05 14:14 ` Arun Isaac
2017-06-05 15:54   ` Leo Famulari [this message]
2017-06-06  8:27     ` Arun Isaac
     [not found]     ` <51e0342f.AEUAK9NcTPcAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABZNmdv@mailjet.com>
2017-06-06 17:56       ` nee
2017-06-07 18:24         ` Arun Isaac
2017-06-07 19:20           ` Leo Famulari
2017-06-08 15:16             ` Arun Isaac
     [not found]             ` <cu78tl25x2y.fsf@systemreboot.net>
2017-06-10 11:39               ` Arun Isaac
     [not found]               ` <5e315f5d.AEAALOqVmtgAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABZO9qA@mailjet.com>
2017-06-10 19:10                 ` nee
2017-06-12  9:36                   ` Arun Isaac
     [not found]         ` <cu7shjbbqqo.fsf@systemreboot.net>
2017-06-07 19:26           ` Arun Isaac
     [not found] ` <4577ad88.AEUAK6w8Z7kAAAAAAAAAAAO0_XAAAAACwQwAAAAAAAW9WABZNWdE@mailjet.com>
2017-06-05 17:41   ` nee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B2FCF650-1124-4424-9EBE-4F230BF30E3B@famulari.name \
    --to=leo@famulari.name \
    --cc=27250@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=nee@cock.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).