unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Vollmert <rob@vllmrt.net>
To: 35859@debbugs.gnu.org
Subject: [bug#35859] improves output in patch 0010
Date: Fri, 24 May 2019 16:58:57 +0200	[thread overview]
Message-ID: <B04A70B6-9CAF-45E0-865C-B7E27F46CD12@vllmrt.net> (raw)
In-Reply-To: <72F268CC-5FB7-421C-B6F7-B47EAAB823C1@vllmrt.net>

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

Patch 0010 adds a logging statement to hackage import.
This is an updated version that provides better output considering
optional cabal reading from standard input.


[-- Attachment #2: 0010-guix-import-hackage-log-when-we-start-with-a-file.patch --]
[-- Type: application/octet-stream, Size: 1190 bytes --]

From c2aae7aa837ac8ac578e0cb46e72e26db08dfca4 Mon Sep 17 00:00:00 2001
From: Robert Vollmert <rob@vllmrt.net>
Date: Sat, 18 May 2019 03:37:27 +0200
Subject: [PATCH 10/13] guix: import: hackage: log when we start with a file

This helps figuring out what errors are in relation to, particularly
during recursive import.

* guix/import/hackage.scm: Log before fetching/parsing a cabal file.
---
 guix/import/hackage.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 0bd9034087..405294d186 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -319,6 +319,10 @@ symbol 'true' or 'false'.  The value associated with other keys has to conform
 to the Cabal file format definition.  The default value associated with the
 keys \"os\", \"arch\" and \"impl\" is \"linux\", \"x86_64\" and \"ghc\"
 respectively."
+   (format (current-error-port)
+     (if port "Importing haskell package from ~a~%"
+              "Importing `~a` from hackage~%")
+     package-name)
    (match
      (if port (read-cabal-and-hash port)
               (hackage-fetch-and-hash package-name))
-- 
2.21.0


      parent reply	other threads:[~2019-05-24 15:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 20:11 [bug#35859] [PATCH] hackage import: Setup.hs generation and revision support Robert Vollmert
2019-05-23  8:50 ` [bug#35859] line ending fix Robert Vollmert
2019-05-23 13:27 ` [bug#35859] fixed patch set, including test fixes Robert Vollmert
2019-05-24 14:56 ` [bug#35859] fixes bug in patch 0003 Robert Vollmert
2019-05-24 14:58 ` Robert Vollmert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B04A70B6-9CAF-45E0-865C-B7E27F46CD12@vllmrt.net \
    --to=rob@vllmrt.net \
    --cc=35859@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).