unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>,
	62171@debbugs.gnu.org
Subject: [bug#62171] [PATCH 0/2] Fix source build of OpenJDK 9 and 10
Date: Tue, 14 Mar 2023 08:02:26 +0100	[thread overview]
Message-ID: <AFB5B803-FAB8-479D-A559-82A59BCB99A5@lepiller.eu> (raw)
In-Reply-To: <20230313234935.39a40ac0@tangletp>

Both LGTM. The snippet doesn't need to end with #t anymore. Also not sure if it's my mail client or the patch, but there's a newline missing at the end of the snippets, before sha256.

Le 13 mars 2023 23:49:35 GMT+01:00, "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de> a écrit :
>This fixes  62071.
>
>Björn Höfling (2):
>  gnu: openjdk9: Build from hg.
>  gnu: openjdk10: Build from hg.
>
> gnu/packages/java.scm | 41 +++++++++++++++++++----------------------
> 1 file changed, 19 insertions(+), 22 deletions(-)
>
>
>base-commit: 5312d798ac36a72d8a977325a7c6ff7647be670a




  parent reply	other threads:[~2023-03-14  7:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 22:49 [bug#62171] [PATCH 0/2] Fix source build of OpenJDK 9 and 10 Björn Höfling
2023-03-13 22:52 ` [bug#62171] [PATCH 1/2] gnu: openjdk9: Build from hg Björn Höfling
2023-03-14  7:02 ` Julien Lepiller [this message]
2023-03-16  9:10   ` bug#62171: [PATCH 0/2] Fix source build of OpenJDK 9 and 10 Björn Höfling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AFB5B803-FAB8-479D-A559-82A59BCB99A5@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=62171@debbugs.gnu.org \
    --cc=bjoern.hoefling@bjoernhoefling.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).