From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0B+QEd5j+GMeXQEAbAwnHQ (envelope-from ) for ; Fri, 24 Feb 2023 08:14:38 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4DxoEd5j+GPmXgEAauVa8A (envelope-from ) for ; Fri, 24 Feb 2023 08:14:38 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0C64013627 for ; Fri, 24 Feb 2023 08:14:38 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVSHP-0006sN-Bg; Fri, 24 Feb 2023 02:14:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVSHL-0006py-Jx for guix-patches@gnu.org; Fri, 24 Feb 2023 02:14:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVSHL-0008BR-4U for guix-patches@gnu.org; Fri, 24 Feb 2023 02:14:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVSHK-0002z5-FJ for guix-patches@gnu.org; Fri, 24 Feb 2023 02:14:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61682] [PATCH v2] gnu: buildah: Add 'buildah' package Resent-From: Zongyuan Li Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 24 Feb 2023 07:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61682 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 61682@debbugs.gnu.org Received: via spool by 61682-submit@debbugs.gnu.org id=B61682.167722279611388 (code B ref 61682); Fri, 24 Feb 2023 07:14:02 +0000 Received: (at 61682) by debbugs.gnu.org; 24 Feb 2023 07:13:16 +0000 Received: from localhost ([127.0.0.1]:35878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVSGZ-0002xc-Sc for submit@debbugs.gnu.org; Fri, 24 Feb 2023 02:13:16 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:44387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVSGW-0002xK-TI for 61682@debbugs.gnu.org; Fri, 24 Feb 2023 02:13:14 -0500 Date: Fri, 24 Feb 2023 07:12:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c0x0o.me; s=protonmail; t=1677222786; x=1677481986; bh=yYar326nYKsnQN07H+q7IFG871USUnCcHDA4Q3tkpz4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Zsg73qnF+7Hh5HasEwX/vLXnFhoVmQPog8Wm5bkBiZ0S5oIXG4T2hI4zrvQdnzhpP jIG0kfApuKZAwhABEUKk9QIZhbKUQgAqPlxPTw6W6XM+HVf57k9hlBht+SzCN+JFqb 0hYbio8KKWHmXkEcp+cEftJ7k9SRDRuwVUXgYad2YXWnZ0T6+2yr54r97NeKSeBrvA uqu7LvUqVkz1W2BE1R0tSN9qCkDl2IyPcWfichvivmrpnaSPsts+43QSC6zuzEnXCl t/WhFYFEAjXV5RKAytiAoxs3O58aOHXpo2qCHxryuSIRl59JycAxSCNYhaMoAXMpPo CRienhFRmqGTw== Message-ID: In-Reply-To: References: <20230223122508.53978-1-zongyuan.li@c0x0o.me> Feedback-ID: 67462066:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Zongyuan Li X-ACL-Warn: , Zongyuan Li via Guix-patches From: Zongyuan Li via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677222878; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yYar326nYKsnQN07H+q7IFG871USUnCcHDA4Q3tkpz4=; b=uOCKHa1T/eMfOXu9f9Cpn6io55QR4XaV7Nu7tKyirXlkiATMoba7XBPRcAKrKdxjMfykmR vqRunyNSkPqxuNzQHZsaFziI9hdv8YSJe2XtvDNkcNEhl9JTY+MYRh7IjYNJis3XngLY8e eWvTkJeZ5nWg2OJoe3knpkvEZRFqT2MYXGja/yXKh1xGnt6JCCN9AxY0FFeizfiQb7ld3R HEb37Rit/ILJjtLdTB3w7VrDm9oLDm2UIgegmRJIqRK9e2pV62llEqDpvvIasjwVaKyThT OLSVwjoAA8JFmPay0xU/QQU/BOEWcVgT+9504buuCovXLA06WV10JGjUUI12xQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677222878; a=rsa-sha256; cv=none; b=b3318Gh6f0Ylvdz356g835oh6VBkLH11MUPTRMlmAJShEBhvPxdXf1aS8gzenZ18fIo26j JmzaJ4ULNSy6xN2Ld0ytSAwTvnMr341bsGeo/VnjoCgcr7KwjGf3TQ3utSFBPbY/esEczy nY+Zt1Elk8uEZgkgSsTw/SRnndIbXKvkYezcsNaZhBj0KFULsXaHftbmD2II8VfX1KcMw3 9uNHhxzDMPsEvAvHebKWVWrwy8/ckqJ94ppNJlfXNU++CvnHLfbARy6g1yh8zscV5Du3T6 iGb5eQ2cFXoXlcbmWro+gqUfKvqXh01BqdvfCEsSAurelcXSbxJhwl0acCVxzg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=c0x0o.me header.s=protonmail header.b=Zsg73qnF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn1.migadu.com X-Spam-Score: -3.68 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=c0x0o.me header.s=protonmail header.b=Zsg73qnF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Spam-Score: -3.68 X-Migadu-Queue-Id: 0C64013627 X-TUID: qiagnnVItX5G Thanks your review! I will try to use go-build-system. I noticed that =E2=80=98podman=E2=80=99 package also uses makefile. Maybe w= e could improve that later too? Li > On Feb 24, 2023, at 13:20, Liliana Marie Prikler wrote: > > Am Donnerstag, dem 23.02.2023 um 12:26 +0000 schrieb Zongyuan Li: >> Introduce new 'buildah' package >> >> Changes since v1: >> >> * fix phase-name typo in modify-phases >> >> * gnu/packages/containers.scm: New 'buildah' package >> --- >> gnu/packages/containers.scm | 68 >> +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 68 insertions(+) >> >> diff --git a/gnu/packages/containers.scm >> b/gnu/packages/containers.scm >> index 50dfa88421..3844e4e700 100644 >> --- a/gnu/packages/containers.scm >> +++ b/gnu/packages/containers.scm >> @@ -41,6 +41,7 @@ (define-module (gnu packages containers) >> #:use-module (gnu packages gnupg) >> #:use-module (gnu packages golang) >> #:use-module (gnu packages linux) >> + #:use-module (gnu packages perl) >> #:use-module (gnu packages python) >> #:use-module (gnu packages networking) >> #:use-module (gnu packages pkg-config) >> @@ -406,3 +407,70 @@ (define-public podman >> volumes mounted into those containers, and pods made from groups of >> containers.") >> (license license:asl2.0))) >> + >> +(define-public buildah >> + (package >> + (name "buildah") >> + (version "1.29.0") >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/containers/buildah") >> + (commit (string-append "v" version)))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + >> "16kc19m5in819624c3np4aqb9hkjc93d34y4958jqy1k3p2p5rir")))) >> + (build-system gnu-build-system) > As fun as it sounds to build Go stuff with just a Makefile, you have a > lot of vendored code unaccounted for. >> + (arguments >> + (list #:make-flags #~(list #$(string-append "CC=3D" >> + (cc-for-target)) >> + (string-append "PREFIX=3D" >> + #$output)) >> + #:tests? #f >> + #:phases #~(modify-phases %standard-phases >> + (delete 'configure) >> + (add-after 'unpack 'set-env >> + (lambda* (#:key inputs #:allow-other-keys) >> + (setenv "HOME" "/tmp"))) >> + (add-after 'unpack 'avoid-building-tools >> + (lambda _ >> + (substitute* "Makefile" >> + (("^docs: install\\.tools") >> + "docs:")))) >> + (add-after 'unpack 'avoid-unnecessary- >> targets >> + (lambda _ >> + (substitute* "Makefile" >> + (("^all: .*") >> + "all: bin/buildah docs")))) >> + (add-after 'unpack 'use-doc-tools >> + (lambda _ >> + (substitute* "docs/Makefile" >> + (("../tests/tools/build/go-md2man") >> + (which "go-md2man"))))) >> + (add-after 'install 'install-completions >> + (lambda _ >> + (invoke "make" "install.completions" >> + (string-append "PREFIX=3D" >> + #$output))))))) >> + (inputs (list btrfs-progs >> + cni-plugins >> + conmon >> + eudev >> + glib >> + go-github-com-go-md2man >> + gpgme >> + libassuan >> + libseccomp >> + lvm2 >> + runc)) >> + (native-inputs (list bats git go-1.18 perl pkg-config)) >> + (synopsis >> + "Facilitates building Open Container Initiative (OCI) container >> images") > Try to stay short in your synopsis. >> + (description >> + "Buildah is an open source, > Buzzword. >> Linux-based tool used to build Open Container >> +Initiative (OCI)-compatible containers. > Perhaps use @abbrev? > >> With Buildah, you can use your >> +favorite tools to create efficient container images from an existing >> base image > Can I use Guix to do that? > > Cheers