From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37492) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hku47-0004v2-0t for guix-patches@gnu.org; Tue, 09 Jul 2019 13:38:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hku44-0008K7-UD for guix-patches@gnu.org; Tue, 09 Jul 2019 13:38:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hku42-0008IA-CZ for guix-patches@gnu.org; Tue, 09 Jul 2019 13:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hku42-0001i4-6s for guix-patches@gnu.org; Tue, 09 Jul 2019 13:38:02 -0400 Subject: [bug#36545] two issues References: In-Reply-To: Resent-Message-ID: From: Robert Vollmert Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Message-Id: Date: Tue, 9 Jul 2019 19:37:03 +0200 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 36545@debbugs.gnu.org Hi John, indeed hoogle would be nice to have. Thanks for packagin it! Two remarks from looking over the patch set: - ghc-mtl shouldn=E2=80=99t be packaged, as it=E2=80=99s a GHC-bundled = library. New versions of `guix import` were updated to take that into account properly, but it should =E2=80=9Cjust work=E2=80=9D to remove patch 0001 = and delete the dependency lines for `ghc-mtl` where they occur. - Is there a particular reason that tests are disabled? The general approach seems to be to build packages with tests unless there=E2=80=99s = a specific reason not to, in which case it would be great if you could add a comment explaining that next to the =E2=80=9C#:tests? #f=E2=80=9D = line. Cheers Robert