From: Robert Vollmert <rob@vllmrt.net>
To: 36545@debbugs.gnu.org
Subject: [bug#36545] two issues
Date: Tue, 9 Jul 2019 19:37:03 +0200 [thread overview]
Message-ID: <A7FEB17C-45D9-4B15-B46C-33553544D765@vllmrt.net> (raw)
In-Reply-To: <CAKf5CqXs_hf9OTFGLezBvX5MeRO4HEPizEon2kCwwU7W-puuzA@mail.gmail.com>
Hi John,
indeed hoogle would be nice to have. Thanks for packagin it!
Two remarks from looking over the patch set:
- ghc-mtl shouldn’t be packaged, as it’s a GHC-bundled library. New
versions of `guix import` were updated to take that into account
properly, but it should “just work” to remove patch 0001 and delete
the dependency lines for `ghc-mtl` where they occur.
- Is there a particular reason that tests are disabled? The general
approach seems to be to build packages with tests unless there’s a
specific reason not to, in which case it would be great if you could
add a comment explaining that next to the “#:tests? #f” line.
Cheers
Robert
next prev parent reply other threads:[~2019-07-09 17:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 6:10 [bug#36545] [PATCH] Add Hoogle John Soo
2019-07-09 17:37 ` Robert Vollmert [this message]
2019-08-15 17:09 ` John Soo
[not found] ` <CAKf5CqUnmr0fuEC6WCnEH1eK30tp4pDsWKW05K0MGq8fL8ZRPg@mail.gmail.com>
2019-08-16 5:58 ` John Soo
2019-08-16 12:22 ` Robert Vollmert
2019-08-16 13:58 ` John Soo
2019-09-03 3:18 ` bug#36545: " Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A7FEB17C-45D9-4B15-B46C-33553544D765@vllmrt.net \
--to=rob@vllmrt.net \
--cc=36545@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).