From: Luis Felipe via Guix-patches via <guix-patches@gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: 69783@debbugs.gnu.org
Subject: [bug#69783] [PATCH]: website: Convert old style sheets into a theme
Date: Thu, 14 Mar 2024 20:16:34 +0000 [thread overview]
Message-ID: <9fdc8464-bd8e-26a4-e14d-d71209b02df5@zoho.com> (raw)
In-Reply-To: <87le6k69cu.fsf@pelzflorian.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 1078 bytes --]
Hi Florian, thank you very much for reviewing.
El 14/03/24 a las 16:56, pelzflorian (Florian Pelz) escribió:
> the patch looks good, although I will not push it as I do not know where
> the CSS file for manuals is set (guix repo? maintenance?). And,
It seems the stylesheets for the manuals are set in
https://git.savannah.gnu.org/cgit/guix.git/tree/doc/build.scm.
> * themes is a name clash with haunt themes
> <https://files.dthompson.us/docs/haunt/latest/Blog.html#index-theme>,
> which may be OK nonetheless. But theme could also be named style or
> something. Or not. The name themes is quite fitting.
Yeah, personally, I don't mind using the |themes| concept for both the
SXML components and the CSS stylesheets because of their relation. But I
wouldn't mind using |styles| if necessary. So, if you prefer the latter,
let me know and I'll update the patch.
> * I wonder, why are static/base/img/icon and scientific-mark.svg created
> and not moved?
Right, they are leftovers. I can provide an updated patch to fix that.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 2881 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2024-03-14 20:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 20:44 [bug#69783] [PATCH]: website: Convert old style sheets into a theme Luis Felipe via Guix-patches via
2024-03-14 16:56 ` pelzflorian (Florian Pelz)
2024-03-14 20:16 ` Luis Felipe via Guix-patches via [this message]
2024-03-15 10:19 ` pelzflorian (Florian Pelz)
2024-03-15 15:33 ` [bug#69783] [PATCH v2] " sirgazil--- via Guix-patches via
2024-03-15 22:51 ` pelzflorian (Florian Pelz)
2024-03-15 19:34 ` [bug#69783] [PATCH] doc: build: Update paths to style sheets sirgazil--- via Guix-patches via
2024-03-16 9:34 ` bug#69783: " Giovanni Biscuolo
2024-03-16 11:09 ` [bug#69783] " pelzflorian (Florian Pelz)
2024-03-16 13:52 ` Luis Felipe via Guix-patches via
2024-03-16 17:47 ` pelzflorian (Florian Pelz)
2024-03-17 10:51 ` Giovanni Biscuolo
2024-03-17 16:52 ` pelzflorian (Florian Pelz)
2024-03-17 17:57 ` pelzflorian (Florian Pelz)
2024-03-17 20:21 ` [bug#69783] [PATCH] hydra: nginx: Adjust to website themes in guix-artwork Florian Pelz
2024-03-24 18:19 ` [bug#69783] [PATCH v2 1/2] hydra: nginx: Redirect 1.4.0 manual resources due to themes move Florian Pelz
2024-03-30 14:28 ` Ludovic Courtès
2024-03-24 18:19 ` [bug#69783] [PATCH v2 2/2] hydra: nginx: Further adjust to website themes in guix-artwork Florian Pelz
2024-03-30 11:00 ` Ludovic Courtès
2024-03-31 10:07 ` bug#69783: " pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fdc8464-bd8e-26a4-e14d-d71209b02df5@zoho.com \
--to=guix-patches@gnu.org \
--cc=69783@debbugs.gnu.org \
--cc=pelzflorian@pelzflorian.de \
--cc=sirgazil@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).