From: Simon South <simon@simonsouth.net>
To: 42093@debbugs.gnu.org
Cc: Simon South <simon@simonsouth.net>
Subject: [bug#42093] [PATCH 1/2] gnu: emacs-nov-el: Use version tag instead of commit.
Date: Sat, 27 Jun 2020 16:11:15 -0400 [thread overview]
Message-ID: <9ee7db8615b71c43ddc1ffbb3c38e218c0580d74.1593287683.git.simon@simonsouth.net> (raw)
In-Reply-To: <cover.1593287683.git.simon@simonsouth.net>
* gnu/packages/emacs-xyz.scm (emacs-nov-el): Remove let binding and associated
comment; correct indentation.
[source]: Use version tag as commit identifier now that upstream has restored
this information.
---
gnu/packages/emacs-xyz.scm | 65 ++++++++++++++++++--------------------
1 file changed, 31 insertions(+), 34 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8b03ce347c..c83a7f5d95 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -12550,39 +12550,36 @@ the format.")
(license license:gpl3+)))
(define-public emacs-nov-el
- ;; Upstream does not tag releases. Specify raw commit hash matching the
- ;; release.
- (let ((commit "ea0c835c1b5e6e70293f4bd64e9c89bdc42f8596"))
- (package
- (name "emacs-nov-el")
- (version "0.3.0")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://depp.brause.cc/nov.el.git")
- (commit commit)))
- (file-name (git-file-name name version))
- (sha256
- (base32 "04phmm14ywgicjsl2bsg6w9rapd71vdkxdp5wp0brj6px27y85jz"))))
- (build-system emacs-build-system)
- (arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'embed-path-to-unzip
- (lambda _
- (substitute* "nov.el"
- (("\\(executable-find \"unzip\"\\)")
- (string-append "\"" (which "unzip") "\"")))
- #t)))))
- (propagated-inputs
- `(("emacs-dash" ,emacs-dash)
- ("emacs-esxml" ,emacs-esxml)))
- (inputs
- `(("unzip" ,unzip)))
- (home-page "https://depp.brause.cc/nov.el/")
- (synopsis "Major mode for reading EPUBs in Emacs")
- (description "@code{nov.el} provides a major mode for reading EPUB
+ (package
+ (name "emacs-nov-el")
+ (version "0.3.0")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://depp.brause.cc/nov.el.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "04phmm14ywgicjsl2bsg6w9rapd71vdkxdp5wp0brj6px27y85jz"))))
+ (build-system emacs-build-system)
+ (arguments
+ `(#:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'embed-path-to-unzip
+ (lambda _
+ (substitute* "nov.el"
+ (("\\(executable-find \"unzip\"\\)")
+ (string-append "\"" (which "unzip") "\"")))
+ #t)))))
+ (propagated-inputs
+ `(("emacs-dash" ,emacs-dash)
+ ("emacs-esxml" ,emacs-esxml)))
+ (inputs
+ `(("unzip" ,unzip)))
+ (home-page "https://depp.brause.cc/nov.el/")
+ (synopsis "Major mode for reading EPUBs in Emacs")
+ (description "@code{nov.el} provides a major mode for reading EPUB
documents.
Features:
@@ -12599,7 +12596,7 @@ Features:
@item Image rescaling
@end itemize
")
- (license license:gpl3+))))
+ (license license:gpl3+)))
(define-public epipe
(package
--
2.26.2
next prev parent reply other threads:[~2020-06-27 20:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 20:08 [bug#42093] [PATCH 0/2] gnu: emacs-nov-el: Update to 0.3.1 Simon South
2020-06-27 20:11 ` Simon South [this message]
2020-06-27 20:11 ` [bug#42093] [PATCH 2/2] " Simon South
2020-06-28 7:54 ` bug#42093: [PATCH 0/2] " Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ee7db8615b71c43ddc1ffbb3c38e218c0580d74.1593287683.git.simon@simonsouth.net \
--to=simon@simonsouth.net \
--cc=42093@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).