From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:37346) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jKn4R-0007AU-4c for guix-patches@gnu.org; Sat, 04 Apr 2020 13:59:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jKn4Q-0007m7-49 for guix-patches@gnu.org; Sat, 04 Apr 2020 13:59:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33239) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jKn4Q-0007m3-0R for guix-patches@gnu.org; Sat, 04 Apr 2020 13:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jKn4P-0006kC-W6 for guix-patches@gnu.org; Sat, 04 Apr 2020 13:59:01 -0400 Subject: [bug#40274] [PATCH v5] gnu: Add kernel-module-loader-service. Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 04 Apr 2020 17:58:09 +0000 From: Brice Waegeneire In-Reply-To: <20200403122044.2f9e2552@scratchpost.org> References: <20200328135908.2540-1-brice@waegenei.re> <20200402123712.338-1-brice@waegenei.re> <20200402155640.121e4879@scratchpost.org> <2b32956fc10fd3012388722e1b00ce21@waegenei.re> <20200403122044.2f9e2552@scratchpost.org> Message-ID: <9ed8ed843f7a66dc306679885a641514@waegenei.re> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: ludo@gnu.org, 40274@debbugs.gnu.org Hello, On 2020-04-03 10:20, Danny Milosavljevic wrote: > On Thu, 02 Apr 2020 17:13:05 +0000 > Brice Waegeneire wrote: >> #+begin_src scheme >> (service modprobe-service-type >> (list (modprobe-entry >> (module "ddcci") >> (load? #t) >> (options '("dyndbg" "delay=120")) >> (alises '("ddc/ci")) >> (install "") ; default >> (remove "")) ; default >> (modprobe-entry >> (module "acpi-call") >> (blacklist? #t)))) > > A service to do that would still be nice. But maybe > "kernel-module-configuration-service" ? A lengthy one but a better one for sure. > (Please don't think I have all the answers, let's see which way is > better) I don't but you seems to have more answers than I have on this specific subject. We are on the same page here, the best interface should be the one that get merged! As you suggested, I choose to go back to the list of string format. It simplified the boilerplate a lot: no record and no helper function. Yet it still allows passing arguments to modules by extending `etc-service-type` to create "/etc/modprobe.d/*.conf" files, and avoids all the pitfalls of the previous method you made me aware off. As `kernel-module-loader-service-type` is extensible it would be possible, in an other patch series, if the need arises, to create a `kernel-module-configuration-service` centralizing loadable modules configuration. But like you noted it would be specific to loadable modules and not built-in ones since `kernel-arguments` is just an OS field, which AFAIK can't be influenced by a service. Thank you for your help Danny. - Brice