unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#73836] [PATCH] gnu: kcolorpicker: Build with -fPIC
@ 2024-10-16  9:12 Doğan Çeçen
  2024-10-16 11:18 ` bug#73836: " Z572
  0 siblings, 1 reply; 2+ messages in thread
From: Doğan Çeçen @ 2024-10-16  9:12 UTC (permalink / raw)
  To: 73836; +Cc: Doğan Çeçen

It fixes linking errors when building kimageannotator:

    ...
    ld:
    /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
    relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
    `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
    not be used when making a shared object; recompile with -fPIC
    ...

* gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
  configure-flags to add -fPIC to CMAKE_CXX_FLAGS.

Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
---
 gnu/packages/kde-frameworks.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index 07b861c672..13d4e24726 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -660,7 +660,8 @@ (define-public kcolorpicker
     (build-system qt-build-system)
     (arguments
      (list #:qtbase qtbase
-           #:configure-flags #~(list "-DBUILD_TESTS=ON"
+           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
+                                     "-DBUILD_TESTS=ON"
                                      "-DBUILD_WITH_QT6=ON")))
     (home-page "https://github.com/ksnip/kColorPicker")
     (synopsis "Color Picker with popup menu")

base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#73836: [PATCH] gnu: kcolorpicker: Build with -fPIC
  2024-10-16  9:12 [bug#73836] [PATCH] gnu: kcolorpicker: Build with -fPIC Doğan Çeçen
@ 2024-10-16 11:18 ` Z572
  0 siblings, 0 replies; 2+ messages in thread
From: Z572 @ 2024-10-16 11:18 UTC (permalink / raw)
  To: Doğan Çeçen; +Cc: 73836-done

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

Doğan Çeçen <sepeth@fastmail.com> writes:

> It fixes linking errors when building kimageannotator:
>
>     ...
>     ld:
>     /gnu/store/...-kcolorpicker-0.3.1/lib/libkColorPicker.a(AbstractPopupMenuButton.cpp.o):
>     relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol
>     `_ZN15QAbstractButton7clickedEb@@Qt_6' which may bind externally can
>     not be used when making a shared object; recompile with -fPIC
>     ...
>
> * gnu/packages/kde-frameworks.scm (kcolorpicker)[arguments]: Adjust
>   configure-flags to add -fPIC to CMAKE_CXX_FLAGS.
>
> Change-Id: I38c77cc641e48b3e992e8f49fd861d9ada818240
> ---
>  gnu/packages/kde-frameworks.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 07b861c672..13d4e24726 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -660,7 +660,8 @@ (define-public kcolorpicker
>      (build-system qt-build-system)
>      (arguments
>       (list #:qtbase qtbase
> -           #:configure-flags #~(list "-DBUILD_TESTS=ON"
> +           #:configure-flags #~(list "-DCMAKE_CXX_FLAGS=-fPIC"
> +                                     "-DBUILD_TESTS=ON"
>                                       "-DBUILD_WITH_QT6=ON")))
>      (home-page "https://github.com/ksnip/kColorPicker")
>      (synopsis "Color Picker with popup menu")
>
> base-commit: 8ffb0c14b8abdbb471788f993a7835add147e3a8
Thanks, push and close.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-10-16 11:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-16  9:12 [bug#73836] [PATCH] gnu: kcolorpicker: Build with -fPIC Doğan Çeçen
2024-10-16 11:18 ` bug#73836: " Z572

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).