unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Newsome <jim@jimnewsome.net>
To: Maxime Devos <maximedevos@telenet.be>, 56684@debbugs.gnu.org
Cc: Jim Newsome <jnewsome@torproject.org>
Subject: [bug#56684] [PATCH 1/3] Bump rust 1.57 -> 1.58
Date: Thu, 21 Jul 2022 19:47:59 -0500	[thread overview]
Message-ID: <9e59f92b-d6dd-897c-8c28-4beea4b7d5f3@jimnewsome.net> (raw)
In-Reply-To: <86c503a4-bd43-6ba8-a307-452c57cf1cfa@telenet.be>

On 7/21/22 19:08, Maxime Devos wrote:
> You aren't bumping the version but adding a new version of the Rust 
> package, the old one is still there. Also, conventionally it is named 
> updating in Guix, and a commit message is missing. For examples see the 
> git history.

Thanks, got it.

> Are all the intermediate steps needed, or could you reduce the number of 
> new intermediate packages?
 >
 > E.g., you could try going directly from 1.57 to 1.60 without
 > intermediate steps. If that's possible, it would be less inefficient to
 > compile.

Good question. I assumed that each version was only compilable from the 
previous version based on that being how the java compiler works, and 
looking at the chain that's already here. From a quick look I don't see 
any documented policy to that effect, though, so maybe it's worth a try.

> Also, there are already patches for updating rust, see 
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54439>. Please look for 
> already existing patches before posting duplicates, to avoid double 
> work, etc.

Oops! It looks like that is both a bit further along and more ambitious 
than my version. It's also been lingering for a while, while guix's 
version of Rust falls further behind, making me wonder if it's worth 
trying to move things up with something closer to my naive approach in 
the meantime.

Still, I'll take a closer look at that and see if there's anything I can 
do to help that one along.

Thank you for the quick feedback!

-Jim




  reply	other threads:[~2022-07-22  0:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 22:01 [bug#56684] [PATCH 1/3] Bump rust 1.57 -> 1.58 Jim Newsome
2022-07-21 22:09 ` [bug#56684] [PATCH 2/3] Bump rust 1.58 -> 1.59 Jim Newsome
2022-07-21 22:09 ` [bug#56684] [PATCH 3/3] Bump rust 1.59 -> 1.60 Jim Newsome
2022-07-21 22:14 ` [bug#56684] This is based on the core-updates branch Jim Newsome
2022-07-22  0:08 ` [bug#56684] [PATCH 1/3] Bump rust 1.57 -> 1.58 Maxime Devos
2022-07-22  0:47   ` Jim Newsome [this message]
2022-07-22  1:33   ` Jim Newsome
2022-07-22  9:07     ` Maxime Devos
2022-08-03  6:54 ` [bug#56684] Cannot bootstrap 1.59/1.60 -> 1.62.1 directly kiasoc5 via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e59f92b-d6dd-897c-8c28-4beea4b7d5f3@jimnewsome.net \
    --to=jim@jimnewsome.net \
    --cc=56684@debbugs.gnu.org \
    --cc=jnewsome@torproject.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).