From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id uGPZCgtHUWVXPwAAauVa8A:P1 (envelope-from ) for ; Sun, 12 Nov 2023 22:43:39 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uGPZCgtHUWVXPwAAauVa8A (envelope-from ) for ; Sun, 12 Nov 2023 22:43:39 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AF71836CCB for ; Sun, 12 Nov 2023 22:43:38 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JQ7SadJc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699825419; a=rsa-sha256; cv=none; b=U+OCdjh78/9BvBj9TScs4Ym7fVz2T0rpxBEzp2/BlfGGH8niBYxpIvYmGPElertibLKIny ILD9KS4exAJjWzkB4FiF1RgfUEDzv2bJsCf8vlZxnEhlRuCyg0OfjVyLkISAo6xMzAL+vO l+jCCW5oOwix4M9+ko9HaT9oHLfK2VkjutUsjKQw8DaGIR+7ApzEHr99JjFCZRLemHhagt gcUvfZzesZK/lKLWIeYIiCj+2BEvvHzSdaQLfFzIwA8qUgtZA7xjh3UbYNlztu6kG/KcUj WsWuNzLkg1uA40PCzklkDym8Mzzjjq9tmV7LyhgtVoh+Y6iI0hgUy4YmOY663Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=JQ7SadJc; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1699825419; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TOJwHylVXffyGpLf5AHOj9OAu2cy9I+w9RqSxMctKq8=; b=rwNTL9XgnoPeyiznvc6aD+LCPZprtDPEwrZI6eN2pGANLqzi5SBqg2wLb68HZqCrOTRkL1 bGrWDZnObwPZ4VHaZxS+44zd39ZACP+7DlRx4KftFUEHAS2s22y1CfufUFhxmFR25zTKK1 rg8aSxNJ7jyMPvbpVxubSW4zVRdrU9LqWPJGUARkLaOHwBScgtTybYi0fhbIoTTb9BRR7X y7n8b6TpyJOmE03NO6s3br4IKS36cdWN2l7OsTIWBIVHbEC8SNyfiCa9l3aqvbQrQkSDbO /anBg8KbnrQMN03bzHqKc7tnVnqdN26Vggi1h5jrBuWm4Gek1d2BjggL4ES+Cg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2IEk-0008Va-0r; Sun, 12 Nov 2023 16:43:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2IEj-0008VR-28 for guix-patches@gnu.org; Sun, 12 Nov 2023 16:43:21 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2IEi-0001T7-QO for guix-patches@gnu.org; Sun, 12 Nov 2023 16:43:20 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2IFN-0002Yv-UJ for guix-patches@gnu.org; Sun, 12 Nov 2023 16:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67114] [PATCH 01/14] gnu: Add emacs-dnt. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 12 Nov 2023 21:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67114 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ian Eure Cc: 67114@debbugs.gnu.org, Katherine Cox-Buday , Andrew Tropin Received: via spool by 67114-submit@debbugs.gnu.org id=B67114.16998253859772 (code B ref 67114); Sun, 12 Nov 2023 21:44:01 +0000 Received: (at 67114) by debbugs.gnu.org; 12 Nov 2023 21:43:05 +0000 Received: from localhost ([127.0.0.1]:57173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2IET-0002XY-AB for submit@debbugs.gnu.org; Sun, 12 Nov 2023 16:43:05 -0500 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:51303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2IEN-0002Wx-OV for 67114@debbugs.gnu.org; Sun, 12 Nov 2023 16:43:03 -0500 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-9e62f903e88so353153866b.2 for <67114@debbugs.gnu.org>; Sun, 12 Nov 2023 13:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699825332; x=1700430132; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=TOJwHylVXffyGpLf5AHOj9OAu2cy9I+w9RqSxMctKq8=; b=JQ7SadJcbXlc41RNCf1qedFunHce45OYUADz2sI92SQ3L06dKvVKo2n6Zu7w9RXXa1 McLIJZgKBDH4A/LAHDo9HlAk3cDDo/mw/hAY1NJegHnS6hNONdZbio2/TsDTvxpKnk+R Y1Rri5e+qHUQtc7ulY9y0QszyvaZ9HJHvXKfg2yo3SVDlx3eKYOmRhf24aNsrILvVxNZ xUxveEg/bC6J12kkFFIj7/pg8NZjgW/v1crRMvRtsCBrDSBHH6xRCDiOJ6p7Pv5j/HZY 1xMNALkTjZ4Z6GeefzeKbhfLs7xorMW/Ye95bMXdcU39wIZnioisjPCuaJRrepeDC/VL lAig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699825332; x=1700430132; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TOJwHylVXffyGpLf5AHOj9OAu2cy9I+w9RqSxMctKq8=; b=iTNplC5ww8s/kO+Kd5uVZraILnWLBy8qMiQzi38VpLd/KCH+I/j/9kaFXD9J8B0HaK FvTUNgc6pSRkH07DTwd5fxi1PENcZbTQvdQVUyqyw/PX7v9ixT2o6cVIp9YG1TVroHU3 PQUPayOY/bp2FaMQ037sKpP0cbvM0ceZodreOpxjuriqJ84qUTCQOnyh8uCdT8OcO30+ jMyEE9fQC2k44CiQYpItCRHGa2JtvlviBJ8NcPEQZuPAgLLJ3zl5EGgWxsoabmH3VsEZ RYzUBZTQBsjFFyTKnkSoCwNKT9S3hFk5QL4WK9JvSn/Iz4OdJyRYJyvsbRF16Z4pBefQ JZ6w== X-Gm-Message-State: AOJu0YzDcjVeGIdv8IdcfByH4EMg20s++eYQrUasLUAzIRdPpAoinUPo sNERE1lWYoIbVJnSbOBDGTA= X-Google-Smtp-Source: AGHT+IGUd+3ktGWftVPkeQ/O0on5IaexhdQ4PvhqQkUdYOIyCV9dp3f5ztbecF0ob942bojxm/NNxg== X-Received: by 2002:a17:906:bc99:b0:9d7:1388:e554 with SMTP id lv25-20020a170906bc9900b009d71388e554mr3396766ejb.17.1699825331701; Sun, 12 Nov 2023 13:42:11 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a14-20020a170906190e00b009c764341f74sm3008353eje.71.2023.11.12.13.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Nov 2023 13:42:10 -0800 (PST) Message-ID: <9e51f76792492efdc2cff756a1cb36e351f119d1.camel@gmail.com> From: Liliana Marie Prikler Date: Sun, 12 Nov 2023 22:42:09 +0100 In-Reply-To: <87sf5a6dts.fsf@retrospec.tv> References: <38d6463959d226a7cf587410063f9c3878d2305f.1699740282.git.ian@retrospec.tv> <87sf5a6dts.fsf@retrospec.tv> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: AF71836CCB X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.00 X-Spam-Score: -2.00 X-TUID: jtvZwbsdrBEa Am Sonntag, dem 12.11.2023 um 10:09 -0800 schrieb Ian Eure: >=20 > Liliana Marie Prikler writes: >=20 > > Am Samstag, dem 11.11.2023 um 14:38 -0800 schrieb Ian Eure: > > > * gnu/packages/emacs-xyz.scm (emacs-dnt): New variable. > > > --- > > > =C2=A0gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ > > > =C2=A01 file changed, 25 insertions(+) > > >=20 > > > diff --git a/gnu/packages/emacs-xyz.scm=20 > > > b/gnu/packages/emacs-xyz.scm > > > index 1319c353cb..4648432441 100644 > > > --- a/gnu/packages/emacs-xyz.scm > > > +++ b/gnu/packages/emacs-xyz.scm > > > @@ -135,6 +135,7 @@ > > > =C2=A0;;; Copyright =C2=A9 2023 Sergiu Ivanov > > > =C2=A0;;; Copyright =C2=A9 2023 Camilo Q.S. (Distopico)=20 > > > > > > =C2=A0;;; Copyright =C2=A9 2023 Thanos Apollo > > > +;;; Copyright =C2=A9 2023 Ian Eure > > > =C2=A0;;; > > > =C2=A0;;; This file is part of GNU Guix. > > > =C2=A0;;; > > > @@ -3294,6 +3295,30 @@ (define-public emacs-eww-lnum > > > =C2=A0incrementally confined in Isearch manner.") > > > =C2=A0=C2=A0=C2=A0=C2=A0 (license license:gpl3+))) > > > =C2=A0 > > > +(define-public emacs-dnt > > > +=C2=A0 (let ((commit "d28d232d682094ab79cfa78c97668c6ebd327c8c") > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (version "0.0.1") > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (revision "1")) > > > +=C2=A0=C2=A0=C2=A0 (package > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (name "emacs-dnt") > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (version (git-version version revisio= n commit)) > > It's better to inline the base version. >=20 > Why?=C2=A0 As a new contributor, I=E2=80=99m genuinely curious. >=20 > I let-bound it because: >=20 > - In the info manual for Guix, two out of three were already. > - You=E2=80=99ll need to update the commit and version at the same time i= n=20 > =C2=A0 many cases, so having them next to each other seems convenient. > - The variable names make it more obvious if arguments to=20 > =C2=A0 git-version get swapped around. You are introducing a gratuitous line, plus making room for confusion between the let-bound version and the syntax-introduced one. The benefit of having "one less place" more often than not doesn't even save you a hunk, whereas in the preferred case for Guix where we'd use actual versions, you'd have to reindent the whole package anyways. Cheer