From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Ian Eure <ian@retrospec.tv>
Cc: 67114@debbugs.gnu.org,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: [bug#67114] [PATCH 01/14] gnu: Add emacs-dnt.
Date: Sun, 12 Nov 2023 22:42:09 +0100 [thread overview]
Message-ID: <9e51f76792492efdc2cff756a1cb36e351f119d1.camel@gmail.com> (raw)
In-Reply-To: <87sf5a6dts.fsf@retrospec.tv>
Am Sonntag, dem 12.11.2023 um 10:09 -0800 schrieb Ian Eure:
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > Am Samstag, dem 11.11.2023 um 14:38 -0800 schrieb Ian Eure:
> > > * gnu/packages/emacs-xyz.scm (emacs-dnt): New variable.
> > > ---
> > > gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
> > > 1 file changed, 25 insertions(+)
> > >
> > > diff --git a/gnu/packages/emacs-xyz.scm
> > > b/gnu/packages/emacs-xyz.scm
> > > index 1319c353cb..4648432441 100644
> > > --- a/gnu/packages/emacs-xyz.scm
> > > +++ b/gnu/packages/emacs-xyz.scm
> > > @@ -135,6 +135,7 @@
> > > ;;; Copyright © 2023 Sergiu Ivanov <sivanov@colimite.fr>
> > > ;;; Copyright © 2023 Camilo Q.S. (Distopico)
> > > <distopico@riseup.net>
> > > ;;; Copyright © 2023 Thanos Apollo <public@thanosapollo.com>
> > > +;;; Copyright © 2023 Ian Eure <ian@retrospec.tv>
> > > ;;;
> > > ;;; This file is part of GNU Guix.
> > > ;;;
> > > @@ -3294,6 +3295,30 @@ (define-public emacs-eww-lnum
> > > incrementally confined in Isearch manner.")
> > > (license license:gpl3+)))
> > >
> > > +(define-public emacs-dnt
> > > + (let ((commit "d28d232d682094ab79cfa78c97668c6ebd327c8c")
> > > + (version "0.0.1")
> > > + (revision "1"))
> > > + (package
> > > + (name "emacs-dnt")
> > > + (version (git-version version revision commit))
> > It's better to inline the base version.
>
> Why? As a new contributor, I’m genuinely curious.
>
> I let-bound it because:
>
> - In the info manual for Guix, two out of three were already.
> - You’ll need to update the commit and version at the same time in
> many cases, so having them next to each other seems convenient.
> - The variable names make it more obvious if arguments to
> git-version get swapped around.
You are introducing a gratuitous line, plus making room for confusion
between the let-bound version and the syntax-introduced one. The
benefit of having "one less place" more often than not doesn't even
save you a hunk, whereas in the preferred case for Guix where we'd use
actual versions, you'd have to reindent the whole package anyways.
Cheer
next prev parent reply other threads:[~2023-11-12 21:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1699740282.git.ian@retrospec.tv>
2023-11-11 22:38 ` [bug#67114] [PATCH 01/14] gnu: Add emacs-dnt Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-12 7:28 ` Liliana Marie Prikler
2023-11-12 17:21 ` Ian Eure
2023-11-12 7:29 ` [bug#67114] " Liliana Marie Prikler
2023-11-12 18:09 ` Ian Eure
2023-11-12 21:42 ` Liliana Marie Prikler [this message]
2023-11-11 22:38 ` [bug#67114] [PATCH 02/14] gnu: Add emacs-geoclue Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 03/14] gnu: Add emacs-9lc-mode Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-12 7:31 ` [bug#67114] " Liliana Marie Prikler
2023-11-12 17:47 ` Ian Eure
2023-11-12 20:42 ` Liliana Marie Prikler
2023-11-11 22:38 ` [bug#67114] [PATCH 04/14] gnu: Add emacs-tl1-mode Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 05/14] gnu: Add emacs-diss Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 06/14] gnu: Add emacs-exwm-mff Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 07/14] gnu: Add emacs-exwm-firefox-core Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 08/14] gnu: Add emacs-exwm-firefox Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 09/14] gnu: Add emacs-exwm-ss Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 10/14] gnu: Add emacs-debase Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-12 7:32 ` [bug#67114] " Liliana Marie Prikler
2023-11-12 18:01 ` Ian Eure
2023-11-13 18:18 ` Liliana Marie Prikler
2023-11-11 22:38 ` [bug#67114] [PATCH 11/14] gnu: Add emacs-discomfort Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-12 7:32 ` [bug#67114] " Liliana Marie Prikler
2023-11-11 22:38 ` [bug#67114] [PATCH 12/14] gnu: Add emacs-shell-here Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 13/14] gnu: Add emacs-hyperspace Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
2023-11-11 22:38 ` [bug#67114] [PATCH 14/14] gnu: Add emacs-nssh Ian Eure
2023-11-12 4:16 ` [bug#67120] " Ian Eure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e51f76792492efdc2cff756a1cb36e351f119d1.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=67114@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=ian@retrospec.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).